gortiz commented on PR #14806:
URL: https://github.com/apache/pinot/pull/14806#issuecomment-2596532599

   @siddharthteotia, although it sounds good, I don't have a clear picture of 
what your suggestion would look like. What seems clear is that significant 
modifications to the current system would be required. This feature deserves a 
design document, which we can use to discuss how to implement it and the 
advantages it could provide.
   
   > I don't want to be anal about it but in general, there is no point in 
emitting a metric which we know may not be always correct to begin with. 
   
   That is never going to be the case, right? We are going to emit the metric 
if and only if we know that is the correct value. Specifically, whenever a 
query succeeds, the number of servers that intervened is known and the value 
matches Alberto's code. When there is an error, 
`brokerResponse.setNumServersResponded(servers.size() - 1)` won't be called, so 
we are not going to send that value.
   
   As said, AFAIK, right now, it is impossible to know how many servers 
intervened on it when a query fails, so this approach is a good (and partial) 
short-term solution. We are never going to send an incorrect metric, but in 
some cases where we don't know the correct value, the metric won't be included. 
That is an improvement over the current state where we never set the metric.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to