davecromberge opened a new pull request, #14856:
URL: https://github.com/apache/pinot/pull/14856

   Aggregation function parameters and dimensions to erase were being extracted 
directly from the task configuration without prepending the merge level key.
   
   For example, the task config is encoded by the Task generator as follows:
   ```
      "hourly.keyA":  "some value",
      "hourly.keyB": "some other value",
      "mergeLevel": "hourly"
   ```
   Any lookups on the configuration during task execution have to include the 
mergeLevel prefix in order to resolve lookups correctly.
   
   There were three options in trying to address this bugfix:
   
   1. Change the encoding of the task config - TaskGenerator would need to 
strip out the merge level prefix and thus make it easier for key extraction.  
Problem is that this could break existing functionality.
   2. Re-encode all keys without the prefix in the task config.  This would 
bloat the config.
   3. Include the merge level prefix in any key lookups - this approach is 
followed in this PR.
   
   This PR should be tagged with `bugfix`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to