Jackie-Jiang commented on code in PR #14797:
URL: https://github.com/apache/pinot/pull/14797#discussion_r1926060053
##########
pinot-query-runtime/src/test/resources/queries/QueryHints.json:
##########
@@ -125,6 +125,14 @@
"description": "Colocated JOIN with partition column and group by
non-partitioned column with stage parallelism",
"sql": "SET stageParallelism=2; SELECT {tbl1}.name, SUM({tbl2}.num)
FROM {tbl1} /*+ tableOptions(partition_function='hashcode',
partition_key='num', partition_size='4') */ JOIN {tbl2} /*+
tableOptions(partition_function='hashcode', partition_key='num',
partition_size='4') */ ON {tbl1}.num = {tbl2}.num GROUP BY {tbl1}.name"
},
+ {
+ "description": "Broadcast JOIN without partition hint",
+ "sql": "SELECT /*+ joinOptions(left_exchange_type = 'local',
right_exchange_type = 'broadcast') */ {tbl1}.num, {tbl1}.name, {tbl2}.num,
{tbl2}.val FROM {tbl1} JOIN {tbl2} ON {tbl1}.num = {tbl2}.num"
Review Comment:
@siddharthteotia We are following this, but the actual problem is that: left
and right exchange should be associated with JOIN instead of table. One example
would be: there is no guarantee that the JOIN is applied to 2 tables. It could
also be applied to the result of a query, or another JOIN etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
