Aatirhassanpir opened a new issue, #14903:
URL: https://github.com/apache/pinot/issues/14903
### Repository Version
[release-1.2.0](https://github.com/apache/pinot/releases/tag/release-1.2.0)
### Key Words / Search Terms
schema validation, DateTimeFieldSpec, exception handling, data processing
errors
### Description
The schema validation logic does not adequately handle validation for
DateTimeFieldSpec. As a result, improperly formatted or invalid datetime fields
may pass the schema validation process, potentially leading to errors during
data processing.
### Expected Behavior
DateTimeFieldSpec should be validated to ensure it follows the correct
format and granularity during schema validation.
Validation should fail gracefully and throw meaningful exceptions rather
than logging errors.
### Actual Behavior
The existing schema validation mechanism for DateTimeFieldSpec fields uses
logging for error handling, which can result in unclear or missed error
messages.
There is insufficient validation of DateTimeFieldSpec fields, leading to
potential misconfigurations in schema definitions.
### Steps to Reproduce
Define a schema containing a DateTimeFieldSpec field with incorrect format
or granularity.
Validate the schema using the existing validation methods.
Observe that the validation might not catch the datetime field issues
properly or may not provide clear feedback via exceptions.
### Potential Fix
Modify the schema validation logic to include a more thorough check of the
DateTimeFieldSpec fields, ensuring they conform to the required format and
granularity.
Refactor the validation code to throw exceptions with clear error messages
instead of logging errors, improving control over error handling.
### Additional Information
The change includes modifications to multiple files, including
SchemaUtils.java, FieldSpecTest.java, and related validation logic files.
This update ensures that invalid datetime field configurations are caught
early in the schema validation process and properly reported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
