somandal commented on code in PR #14894: URL: https://github.com/apache/pinot/pull/14894#discussion_r1927436872
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/provider/PinotClusterConfigChangeListener.java: ########## @@ -0,0 +1,26 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.provider; + +import java.util.Map; + + +public interface PinotClusterConfigChangeListener { + void onChange(Map<String, String> clusterConfigs); Review Comment: I don't fully understand the concern here. We already get all the keys and the change listeners can decide to process whatever they're interested in anyways. Is the concern passing all the keys to each listener? How would you recommend calculating the changed keys here? For changed values or newly added keys it is straightforward, but for deleted ones it gets tricky on how to pass this on to the listeners. Should we pass both changed and deleted? I didn't want to use `prefetch` as this same interface is already used internally and I didn't want to change the behavior for the internal code (I plan to just remove the internal interfaces and replace with usages of this one). with `prefetch` we need to essentially fetch each config key from ZK in the `onChange` then. I'm not sure how that is better than just passing the prefetched configs directly? Is this more about the network overhead? I've updated the javadocs ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPreprocessThrottler.java: ########## @@ -0,0 +1,139 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.utils; + +import com.google.common.annotations.VisibleForTesting; +import java.util.Map; +import org.apache.pinot.common.concurrency.AdjustableSemaphore; +import org.apache.pinot.spi.config.provider.PinotClusterConfigChangeListener; +import org.apache.pinot.spi.utils.CommonConstants; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Used to throttle the total concurrent index rebuilds that can happen on a given Pinot server. + * Code paths that do no need to rebuild the index or which don't happen on the server need not utilize this throttler. + */ +public class SegmentPreprocessThrottler implements PinotClusterConfigChangeListener { + private static final Logger LOGGER = LoggerFactory.getLogger(SegmentPreprocessThrottler.class); + + /** + * If _maxPreprocessConcurrency is <= 0, it means that the cluster is not configured to limit the number of + * index rebuilds that can be executed concurrently. This class sets the semaphore permit to be a large value + * in this scenario. + */ + private int _maxPreprocessConcurrency; + private boolean _relaxThrottling; + private volatile AdjustableSemaphore _semaphore; Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
