Jackie-Jiang commented on code in PR #14893:
URL: https://github.com/apache/pinot/pull/14893#discussion_r1928035732
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/logical/PinotLogicalExchange.java:
##########
@@ -35,38 +36,43 @@
*/
public class PinotLogicalExchange extends Exchange {
private final PinotRelExchangeType _exchangeType;
+ // NOTE: We might change distribution type for local exchange. Store the
keys separately.
+ private final List<Integer> _keys;
private PinotLogicalExchange(RelOptCluster cluster, RelTraitSet traitSet,
RelNode input, RelDistribution distribution,
- PinotRelExchangeType exchangeType) {
+ PinotRelExchangeType exchangeType, List<Integer> keys) {
Review Comment:
Let me put more comments explaining this. We use `SINGLETON` to represent
local exchange, but we also want to support parallelism for local exchange
where keys are needed. We can revisit this as we add more custom distribution
types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
