9aman commented on code in PR #14798:
URL: https://github.com/apache/pinot/pull/14798#discussion_r1931573833
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1361,23 +1394,29 @@ IdealState ensureAllPartitionsConsuming(TableConfig
tableConfig, List<StreamConf
SegmentZKMetadata latestSegmentZKMetadata = entry.getValue();
String latestSegmentName = latestSegmentZKMetadata.getSegmentName();
LLCSegmentName latestLLCSegmentName = new
LLCSegmentName(latestSegmentName);
+ // This is the expected segment status after completion of first of the
3 steps of the segment commit protocol
+ // The status in step one is updated to
+ // 1. DONE for normal consumption
+ // 2. COMMITTING for pauseless consumption
+ Status statusPostSegmentMetadataUpdate =
+ PauselessConsumptionUtils.isPauselessEnabled(tableConfig) ?
Status.COMMITTING : Status.DONE;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
