Jackie-Jiang commented on code in PR #14872:
URL: https://github.com/apache/pinot/pull/14872#discussion_r1932820252
##########
pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java:
##########
@@ -50,12 +53,14 @@ public class SegmentPurger {
private final Schema _schema;
private final RecordPurger _recordPurger;
private final RecordModifier _recordModifier;
-
+ private SegmentGeneratorConfig _segmentGeneratorConfig;
+ private final SegmentGeneratorCustomConfigs _segmentGeneratorCustomConfigs;
Review Comment:
(minor) Switch these 2 to keep `final` fields together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
