[
https://issues.apache.org/jira/browse/PIRK-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382165#comment-15382165
]
ASF GitHub Bot commented on PIRK-2:
-----------------------------------
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/7
[PIRK-2] Enhance Pallier acquisition of PRNG provider.
As suggested, this moves the spec for the secure random into the Pirk
properties file.
Note that I have left the provider commented out at the moment, to ensure
it works on a broad selection of Java runtimes, and is as close to the original
code intent as possible.
In production users would likely specify a secure system PRNG, or specify
both algorithm and provider in the Pirk properties file. Therefore I would not
object to commenting out both properties by default ;-)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk pirk-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 15f98ec9da94d3780b6cd9e4e9093a3f6e2f2972
Author: Tim Ellison <[email protected]>
Date: 2016-07-14T08:57:14Z
[PIRK-2] Load Pallier's PRNG statically and from any provider.
commit 063f12d5fc189426bf5537844aac7c81da13b28b
Author: Tim Ellison <[email protected]>
Date: 2016-07-18T11:17:26Z
Merge branch 'master' of https://github.com/apache/incubator-pirk into
pirk-2
commit 74d06d83d63b1ee57addb0dfbcee33693fbe9fe7
Author: Tim Ellison <[email protected]>
Date: 2016-07-18T11:54:17Z
Move the selection of secure PRNG to the properties file.
----
> Enhance Pallier acquisition of PRNG provider
> --------------------------------------------
>
> Key: PIRK-2
> URL: https://issues.apache.org/jira/browse/PIRK-2
> Project: PIRK
> Issue Type: Bug
> Reporter: Tim Ellison
> Assignee: Tim Ellison
>
> {{org.apache.pirk.encryption.Pallier}} has a hard coded requirement for the
> {{NativePRNG}} algorithm to be supplied by the {{SUN}} provider. This causes
> the {{test.general.PaillierTest}} to fail on IBM's Java implementation.
> The implementation should allow the provider to be configured by the
> java.security properties of the runtime to allow for provider optimizations,
> etc.
> Furthermore, the instantiation of a provider is relatively (CPU) expensive,
> so reusing the PRNG is preferable to acquiring it each time a value is
> required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)