[ 
https://issues.apache.org/jira/browse/PIRK-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502817#comment-15502817
 ] 

ASF GitHub Bot commented on PIRK-63:
------------------------------------

Github user tellison commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/93#discussion_r79352002
  
    --- Diff: 
src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java ---
    @@ -49,83 +41,111 @@
     public class ResponderDriver
     {
       private static final Logger logger = 
LoggerFactory.getLogger(ResponderDriver.class);
    +  // ClassNames to instantiate Platforms using the platform CLI
    +  private final static String MAPREDUCE_LAUNCHER = 
"org.apache.pirk.responder.wideskies.mapreduce.MapReduceResponderLauncher";
    +  private final static String SPARK_LAUNCHER = 
"org.apache.pirk.responder.wideskies.spark.SparkResponderLauncher";
    +  private final static String SPARKSTREAMING_LAUNCHER = 
"org.apache.pirk.responder.wideskies.spark.streaming.SparkStreamingResponderLauncher";
    +  private final static String STANDALONE_LAUNCHER = 
"org.apache.pirk.responder.wideskies.standalone.StandaloneResponderLauncher";
    +  private final static String STORM_LAUNCHER = 
"org.apache.pirk.responder.wideskies.storm.StormResponderLauncher";
     
    --- End diff --
    
    I'm confused by this, I though the goal of PIRK-63 was to avoid having to 
change the ResponderDriver each time a new responder type is introduced?


> Generalize ResponderDriver to use accept a RespondLauncher class
> ----------------------------------------------------------------
>
>                 Key: PIRK-63
>                 URL: https://issues.apache.org/jira/browse/PIRK-63
>             Project: PIRK
>          Issue Type: Improvement
>          Components: Responder
>    Affects Versions: 0.1.0
>            Reporter: DarinJ
>            Assignee: DarinJ
>            Priority: Minor
>             Fix For: 0.0.1
>
>
> Currently as discussed on the mailing list, the ResponderDriver uses a switch 
> statement based off a string in the CLI or properties file to determine the 
> framework to launch.  This is require a code change to the ResponderDriver 
> for every framework added.
> The solution is to create a ResponderLauncher Interface which each framework 
> overrides.
> {quote}
> public interface ResponderLauncher {
>   public run()
> }
> {quote}
> To do this, we the change the string specifying the framework to the name of 
> the class implementing ResponderLauncher i.e. SparkResponderLauncher and 
> instantiate via reflection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to