[
https://issues.apache.org/jira/browse/PIRK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602923#comment-15602923
]
ASF GitHub Bot commented on PIRK-78:
------------------------------------
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/112
[PIRK-78] Create a QuerySchema builder for assembling new schemas.
- Define the new QuerySchemaBuilder type.
- Remove QuerySchema building responsibilities from the loader.
- Tidy-up LoadQuerySchema tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk PIRK-78
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit 539259b57d8e7d60cc5110e609df45bad3112238
Author: Tim Ellison <t.p.elli...@gmail.com>
Date: 2016-10-24T19:00:19Z
[PIRK-78] Create a QuerySchema builder for assembling new schemas.
- Define the new QuerySchemaBuilder type.
- Remove QuerySchema building responsibilities from the loader.
- Tidy-up LoadQuerySchema tests.
----
> Create a new QuerySchema builder to separate from representation
> ----------------------------------------------------------------
>
> Key: PIRK-78
> URL: https://issues.apache.org/jira/browse/PIRK-78
> Project: PIRK
> Issue Type: Improvement
> Reporter: Tim Ellison
>
> Presently, Pirk has a QuerySchemaLoader that reads an XML formatted stream
> and builds a new QuerySchema.
> In order to separate the representation of the schema in XML from the logic
> of assembling a new schema such as validating the values, a new
> QuerySchemaBuilder is to be introduced. The QuerySchemaLoader will then
> delegate the creation to the new builder, and other representations can also
> use the builder to create a new QuerySchema without having to go via XML.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
