[ 
https://issues.apache.org/jira/browse/PIRK-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob Wilder closed PIRK-57.
----------------------------
    Resolution: Won't Fix

Moving to checkstyle would take a huge amount of refactoring of the code and 
changes to our commit workflow with marginal gain. 
We should continue enforcing the Eclipse style file. 

> Use the checkstyle maven plugin to enforce Pirk code style conventions
> ----------------------------------------------------------------------
>
>                 Key: PIRK-57
>                 URL: https://issues.apache.org/jira/browse/PIRK-57
>             Project: PIRK
>          Issue Type: Improvement
>            Reporter: Jacob Wilder
>            Assignee: Jacob Wilder
>            Priority: Minor
>             Fix For: 0.1.1
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I'll covert the eclipse-pirk-codestyle.xml into a checkstyle.xml and 
> integrate it with maven using the [Apache Maven Checkstyle Plugin 
> |https://maven.apache.org/plugins/maven-checkstyle-plugin/]. 
> I'm thinking of doing this as two Pull Requests. 
> 1) Add checkstyle and make it possible to check for compliance with {{mvn 
> verify}}
> 2) Make the codebase pass the new {{mvn verify}}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to