Author: rwhitcomb
Date: Mon Aug  5 22:50:22 2013
New Revision: 1510791

URL: http://svn.apache.org/r1510791
Log:
Add some warning suppression about [unchecked] heap pollution from varargs
messages.  These are now showing up with the Java 1.7 compiler.

Modified:
    pivot/trunk/core/src/org/apache/pivot/collections/ArrayAdapter.java
    pivot/trunk/core/src/org/apache/pivot/collections/ArrayList.java
    pivot/trunk/core/src/org/apache/pivot/collections/HashMap.java
    pivot/trunk/core/src/org/apache/pivot/collections/HashSet.java
    pivot/trunk/core/src/org/apache/pivot/collections/LinkedList.java

Modified: pivot/trunk/core/src/org/apache/pivot/collections/ArrayAdapter.java
URL: 
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/ArrayAdapter.java?rev=1510791&r1=1510790&r2=1510791&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/ArrayAdapter.java 
(original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/ArrayAdapter.java Mon Aug 
 5 22:50:22 2013
@@ -28,6 +28,7 @@ public class ArrayAdapter<T> implements 
 
     private T[] array;
 
+    @SuppressWarnings({"unchecked", "varargs"})
     public ArrayAdapter(T... array) {
         if (array == null) {
             throw new IllegalArgumentException();

Modified: pivot/trunk/core/src/org/apache/pivot/collections/ArrayList.java
URL: 
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/ArrayList.java?rev=1510791&r1=1510790&r2=1510791&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/ArrayList.java (original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/ArrayList.java Mon Aug  5 
22:50:22 2013
@@ -153,6 +153,7 @@ public class ArrayList<T> implements Lis
         items = new Object[capacity];
     }
 
+    @SuppressWarnings({"unchecked", "varargs"})
     public ArrayList(T... items) {
         this(items, 0, items.length);
     }

Modified: pivot/trunk/core/src/org/apache/pivot/collections/HashMap.java
URL: 
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/HashMap.java?rev=1510791&r1=1510790&r2=1510791&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/HashMap.java (original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/HashMap.java Mon Aug  5 
22:50:22 2013
@@ -123,6 +123,7 @@ public class HashMap<K, V> implements Ma
         rehash(capacity);
     }
 
+    @SafeVarargs
     public HashMap(Pair<K, V>... entries) {
         this(Math.max((int)(entries.length / DEFAULT_LOAD_FACTOR) + 1, 
DEFAULT_CAPACITY));
 

Modified: pivot/trunk/core/src/org/apache/pivot/collections/HashSet.java
URL: 
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/HashSet.java?rev=1510791&r1=1510790&r2=1510791&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/HashSet.java (original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/HashSet.java Mon Aug  5 
22:50:22 2013
@@ -87,9 +87,9 @@ public class HashSet<E> implements Set<E
         }
     }
 
+    @SafeVarargs
     public HashSet(E... elements) {
-        for (int i = 0; i < elements.length; i++) {
-            E element = elements[i];
+        for (E element : elements) {
             add(element);
         }
     }

Modified: pivot/trunk/core/src/org/apache/pivot/collections/LinkedList.java
URL: 
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/LinkedList.java?rev=1510791&r1=1510790&r2=1510791&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/LinkedList.java (original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/LinkedList.java Mon Aug  
5 22:50:22 2013
@@ -248,9 +248,10 @@ public class LinkedList<T> implements Li
         this.comparator = comparator;
     }
 
+    @SafeVarargs
     public LinkedList(T... items) {
-        for (int i = 0; i < items.length; i++) {
-            add(items[i]);
+        for (T item : items) {
+            add(item);
         }
     }
 


Reply via email to