This is an automated email from the ASF dual-hosted git repository. sruehl pushed a change to branch feature/Beckhoff_ADS_protocol in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git.
from ad93bf0 + implement basic fake serialization for ADS. + Fixed tests and protocol implementation new 87c4def reduce timeout to improve test performance. new 83a4a0c added tests for ADS protocol The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: ...adStateRequest.java => ADSAbstractRequest.java} | 25 +-- ...dStateRequest.java => ADSAbstractResponse.java} | 25 +-- .../commands/ADSAddDeviceNotificationRequest.java | 28 ++- .../commands/ADSAddDeviceNotificationResponse.java | 19 +- .../ADSDeleteDeviceNotificationRequest.java | 9 +- .../ADSDeleteDeviceNotificationResponse.java | 17 +- .../api/commands/ADSDeviceNotificationRequest.java | 11 +- .../commands/ADSDeviceNotificationResponse.java | 5 +- .../ads/api/commands/ADSReadDeviceInfoRequest.java | 3 +- .../api/commands/ADSReadDeviceInfoResponse.java | 25 ++- .../java/ads/api/commands/ADSReadRequest.java | 11 +- .../java/ads/api/commands/ADSReadResponse.java | 22 ++- .../java/ads/api/commands/ADSReadStateRequest.java | 3 +- .../ads/api/commands/ADSReadStateResponse.java | 17 +- .../java/ads/api/commands/ADSReadWriteRequest.java | 15 +- .../ads/api/commands/ADSReadWriteResponse.java | 23 ++- .../ads/api/commands/ADSWriteControlRequest.java | 12 +- .../ads/api/commands/ADSWriteControlResponse.java | 17 +- .../java/ads/api/commands/ADSWriteRequest.java | 13 +- .../java/ads/api/commands/ADSWriteResponse.java | 18 +- .../api/commands/types/AdsNotificationSample.java | 8 + .../java/ads/api/commands/types/AdsReturnCode.java | 10 +- .../ads/api/commands/types/AdsStampHeader.java | 9 + .../plc4x/java/ads/api/commands/types/Data.java | 5 + .../plc4x/java/ads/api/commands/types/Device.java | 4 +- .../java/ads/api/commands/types/MajorVersion.java | 4 +- .../java/ads/api/commands/types/MinorVersion.java | 4 +- .../java/ads/api/commands/types/TimeStamp.java | 29 ++- .../plc4x/java/ads/api/generic/AMSHeader.java | 15 ++ .../plc4x/java/ads/api/generic/AMSTCPHeader.java | 18 +- .../plc4x/java/ads/api/generic/AMSTCPPaket.java | 11 +- .../generic/calculated/CalculatedAMSHeader.java | 15 ++ .../generic/calculated/CalculatedAMSTCPHeader.java | 15 +- .../plc4x/java/ads/api/generic/types/AMSNetId.java | 4 +- .../plc4x/java/ads/api/generic/types/State.java | 2 + .../plc4x/java/ads/api/util/ByteReadable.java | 5 +- .../apache/plc4x/java/ads/api/util/ByteValue.java | 17 +- .../ads/api/util/UnsignedShortLEByteValue.java | 4 +- .../apache/plc4x/java/ads/netty/ADSProtocol.java | 37 ++-- .../plc4x/java/ads/netty/Plc4XADSProtocol.java | 14 +- plc4j/protocols/ads/src/site/asciidoc/index.adoc | 2 + .../apache/plc4x/java/ads/ADSPlcDriverTest.java | 2 +- .../plc4x/java/ads/netty/ADSProtocolTest.java | 199 +++++++++++++++++++++ .../apache/plc4x/java/ads/util/TcpHexDumper.java | 10 +- 44 files changed, 643 insertions(+), 118 deletions(-) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/commands/{ADSReadStateRequest.java => ADSAbstractRequest.java} (65%) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/commands/{ADSReadStateRequest.java => ADSAbstractResponse.java} (70%) create mode 100644 plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/netty/ADSProtocolTest.java -- To stop receiving notification emails like this one, please contact sru...@apache.org.