This is an automated email from the ASF dual-hosted git repository. sruehl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git.
from 933adbe fixed digest calculation due to short overflow new 7450252 simplified ADS Return code enum new bffaebe suppress unused warnings for static defined constants new 9799a98 simplified AMSTcpPacket new b4c71ec introduced new protocol layer ads2payload and removed dependency from serial to tcp The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../java/ads/api/commands/types/AdsReturnCode.java | 229 +++++++++++---------- .../plc4x/java/ads/api/commands/types/Data.java | 9 + .../java/ads/api/commands/types/IndexGroup.java | 1 + .../java/ads/api/commands/types/IndexOffset.java | 1 + .../plc4x/java/ads/api/generic/AmsPacket.java | 11 - .../plc4x/java/ads/api/generic/types/AmsPort.java | 1 + .../plc4x/java/ads/api/serial/AmsSerialFrame.java | 20 +- .../plc4x/java/ads/api/serial/types/UserData.java | 9 + .../plc4x/java/ads/api/tcp/AmsTCPPacket.java | 50 ++--- .../ads/api/{serial => tcp}/types/UserData.java | 11 +- .../apache/plc4x/java/ads/api/util/ByteValue.java | 12 +- .../ads/connection/AdsSerialPlcConnection.java | 6 +- .../java/ads/connection/AdsTcpPlcConnection.java | 6 +- ...s2TcpProtocol.java => Ads2PayloadProtocol.java} | 29 +-- ...alProtocol.java => Payload2SerialProtocol.java} | 46 +---- .../java/ads/protocol/Payload2TcpProtocol.java | 58 ++++++ ...ProtocolTest.java => AbstractProtocolTest.java} | 77 +------ .../java/ads/protocol/Ads2PayloadProtocolTest.java | 99 +++++++++ .../java/ads/protocol/Ads2TcpProtocolTest.java | 203 ------------------ .../ads/protocol/Payload2SerialProtocolTest.java | 105 ++++++++++ .../java/ads/protocol/Payload2TcpProtocolTest.java | 104 ++++++++++ ...rotocolTest.java => Plc4x2AdsProtocolTest.java} | 4 +- 22 files changed, 574 insertions(+), 517 deletions(-) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{serial => tcp}/types/UserData.java (86%) rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/{Ads2TcpProtocol.java => Ads2PayloadProtocol.java} (94%) rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/{Ads2SerialProtocol.java => Payload2SerialProtocol.java} (69%) create mode 100644 plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2TcpProtocol.java rename plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/protocol/{Ads2SerialProtocolTest.java => AbstractProtocolTest.java} (67%) create mode 100644 plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/protocol/Ads2PayloadProtocolTest.java delete mode 100644 plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/protocol/Ads2TcpProtocolTest.java create mode 100644 plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocolTest.java create mode 100644 plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/protocol/Payload2TcpProtocolTest.java rename plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/protocol/{Plc4X2Ads2TcpProtocolTest.java => Plc4x2AdsProtocolTest.java} (99%) -- To stop receiving notification emails like this one, please contact sru...@apache.org.