This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git

commit 856878a253b8f7548a125629d3b68959281bb2dd
Author: Sebastian Rühl <sru...@apache.org>
AuthorDate: Thu Mar 15 15:48:19 2018 +0100

    proberly release used bytebuffers
---
 .../java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java  | 1 +
 .../java/org/apache/plc4x/java/ads/protocol/Payload2TcpProtocol.java     | 1 +
 2 files changed, 2 insertions(+)

diff --git 
a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java
 
b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java
index 5f1d04b..30a166c 100644
--- 
a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java
+++ 
b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java
@@ -41,6 +41,7 @@ public class Payload2SerialProtocol extends 
MessageToMessageCodec<ByteBuf, ByteB
         out.add(AmsSerialFrame.of(FragmentNumber.of((byte) 0), 
UserData.of(amsPacket)).getByteBuf());
         // TODO: we need to remember the fragment and maybe even need to spilt 
up the package
         // TODO: if we exceed 255 byte
+        amsPacket.release();
     }
 
     @Override
diff --git 
a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2TcpProtocol.java
 
b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2TcpProtocol.java
index 8b723e8..a12c867 100644
--- 
a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2TcpProtocol.java
+++ 
b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2TcpProtocol.java
@@ -37,6 +37,7 @@ public class Payload2TcpProtocol extends 
MessageToMessageCodec<ByteBuf, ByteBuf>
     @Override
     protected void encode(ChannelHandlerContext channelHandlerContext, ByteBuf 
amsPacket, List<Object> out) throws Exception {
         out.add(AmsTCPPacket.of(UserData.of(amsPacket)).getByteBuf());
+        amsPacket.release();
     }
 
     @SuppressWarnings("unchecked")

-- 
To stop receiving notification emails like this one, please contact
sru...@apache.org.

Reply via email to