This is an automated email from the ASF dual-hosted git repository.
cdutz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
The following commit(s) were added to refs/heads/master by this push:
new cefb6b6 - Removed a now obsolete TODO
cefb6b6 is described below
commit cefb6b6d470936be1c219cbbac36061c4e06fb78
Author: Christofer Dutz <christofer.d...@c-ware.de>
AuthorDate: Thu Apr 12 16:24:37 2018 +0200
- Removed a now obsolete TODO
---
.../org/apache/plc4x/java/isotp/netty/model/params/TsapParameter.java | 2 --
1 file changed, 2 deletions(-)
diff --git
a/plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/isotp/netty/model/params/TsapParameter.java
b/plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/isotp/netty/model/params/TsapParameter.java
index 6439008..f521828 100644
---
a/plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/isotp/netty/model/params/TsapParameter.java
+++
b/plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/isotp/netty/model/params/TsapParameter.java
@@ -20,8 +20,6 @@ package org.apache.plc4x.java.isotp.netty.model.params;
/**
* Base class for calling and called TSAPs
- * TODO: I find it strange to have these parameters directly relate to S7
specifics as they should not need to be known in the IsoTP protocol.
- * Optionally it might be a good idea to have some mechanism
*/
public abstract class TsapParameter implements Parameter {
--
To stop receiving notification emails like this one, please contact
cd...@apache.org.
