This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git.
from 864bd96 fixed some sonar bugs (equals, hashcode, serializable)
new 96eaca6 fixed sonar warning about not serializable fields
new 8b8a938 fixed some bugs while working on coverage
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../api/commands/AdsDeviceNotificationRequest.java | 2 +-
.../java/ads/api/commands/AdsReadResponse.java | 17 +++++++----
.../java/ads/api/commands/AdsReadWriteRequest.java | 2 +-
.../ads/api/commands/AdsReadWriteResponse.java | 2 +-
.../ads/api/commands/AdsWriteControlRequest.java | 2 +-
.../java/ads/api/commands/AdsWriteRequest.java | 2 +-
.../java/ads/api/commands/UnknownCommand.java | 11 ++++---
.../api/commands/types/AdsNotificationSample.java | 2 +-
.../java/ads/api/commands/types/AdsState.java | 2 +-
.../plc4x/java/ads/api/generic/AmsHeader.java | 34 ++++++++++++++--------
.../java/ads/api/serial/types/FragmentNumber.java | 12 ++++++++
.../java/ads/api/serial/types/ReceiverAddress.java | 12 ++++++++
.../ads/api/serial/types/TransmitterAddress.java | 12 ++++++++
.../java/ads/api/serial/types/UserDataLength.java | 12 ++++++++
.../types/CommandTypesFactoryMethodTest.java | 11 +++++++
.../ads/api/generic/GenericFactoryMethodTest.java | 6 +---
.../java/ads/api/generic/types/AmsPortTest.java | 9 +++++-
.../SerialFactoryMethodTest.java} | 29 +++++++-----------
.../types/GenericTypesFactoryMethodTest.java | 22 +++++++-------
.../TcpFactoryMethodTest.java} | 8 ++---
.../types/GenericTypesFactoryMethodTest.java | 15 ++++------
21 files changed, 146 insertions(+), 78 deletions(-)
copy
plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/api/{generic/GenericFactoryMethodTest.java
=> serial/SerialFactoryMethodTest.java} (76%)
copy plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/api/{generic
=> serial}/types/GenericTypesFactoryMethodTest.java (85%)
copy
plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/api/{generic/GenericFactoryMethodTest.java
=> tcp/TcpFactoryMethodTest.java} (92%)
copy plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/api/{generic
=> tcp}/types/GenericTypesFactoryMethodTest.java (90%)
--
To stop receiving notification emails like this one, please contact
sru...@apache.org.
