[incubator-plc4x] branch master updated: [ADS] added TODO: about broken multiplicator

[sruehl]

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/master by this push:
     new a4c4797  [ADS] added TODO: about broken multiplicator
a4c4797 is described below

commit a4c4797f92bd9b079137258d46c3a3941384ff29
Author: Sebastian Rühl <sru...@apache.org>
AuthorDate: Thu Aug 23 10:16:43 2018 +0200

    [ADS] added TODO: about broken multiplicator
---
 .../main/java/org/apache/plc4x/java/ads/protocol/Plc4x2AdsProtocol.java  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Plc4x2AdsProtocol.java
 
b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Plc4x2AdsProtocol.java
index c0c0fbf..6e86460 100644
--- 
a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Plc4x2AdsProtocol.java
+++ 
b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Plc4x2AdsProtocol.java
@@ -183,6 +183,7 @@ public class Plc4x2AdsProtocol extends 
MessageToMessageCodec<AmsPacket, PlcReque
         Invoke invokeId = Invoke.of(correlationBuilder.incrementAndGet());
         IndexGroup indexGroup = IndexGroup.of(adsAddress.getIndexGroup());
         IndexOffset indexOffset = IndexOffset.of(adsAddress.getIndexOffset());
+        // TODO: multiplicator is missing is missing. So an integer 4Bytes and 
10 of them should be 40 Bytes not one.
         Length length = Length.of(readRequestItem.getSize());
         AmsPacket amsPacket = AdsReadRequest.of(targetAmsNetId, targetAmsPort, 
sourceAmsNetId, sourceAmsPort, invokeId, indexGroup, indexOffset, length);
         LOGGER.debug("encoded read request {}", amsPacket);