This is an automated email from the ASF dual-hosted git repository.
tmitsch pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
The following commit(s) were added to refs/heads/develop by this push:
new c95f302 fixed one more sonar-bug
c95f302 is described below
commit c95f302a385a007986d63443d309639c13d5831b
Author: Tim Mitsch <[email protected]>
AuthorDate: Mon Mar 11 22:19:09 2019 +0100
fixed one more sonar-bug
---
.../src/main/java/org/apache/plc4x/Plc4xSchemaFactory.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git
a/integrations/apache-calcite/src/main/java/org/apache/plc4x/Plc4xSchemaFactory.java
b/integrations/apache-calcite/src/main/java/org/apache/plc4x/Plc4xSchemaFactory.java
index 3a96d5f..7e229fb 100644
---
a/integrations/apache-calcite/src/main/java/org/apache/plc4x/Plc4xSchemaFactory.java
+++
b/integrations/apache-calcite/src/main/java/org/apache/plc4x/Plc4xSchemaFactory.java
@@ -24,11 +24,14 @@ import org.apache.calcite.schema.SchemaPlus;
import org.apache.commons.lang3.Validate;
import org.apache.plc4x.java.scraper.config.ScraperConfiguration;
import org.apache.plc4x.java.scraper.exception.ScraperException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import java.io.IOException;
import java.util.Map;
public class Plc4xSchemaFactory implements SchemaFactory {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(Plc4xSchemaFactory.class);
@Override
public Schema create(SchemaPlus parentSchema, String name, Map<String,
Object> operand) {
@@ -56,6 +59,7 @@ public class Plc4xSchemaFactory implements SchemaFactory {
try {
return new Plc4xSchema(configuration, parsedLimit);
} catch (ScraperException e) {
+ LOGGER.warn("Could not evaluate Plc4xSchema",e);
//ToDo Exception, but interface does not accept ... null is fishy
return null;
}