This is an automated email from the ASF dual-hosted git repository. tmitsch pushed a commit to branch feature/improve-scraper-tim in repository https://gitbox.apache.org/repos/asf/plc4x.git
commit 4fd496c92d9de17147ea1cfe8a0144d9b4a59a14 Author: Tim Mitsch <[email protected]> AuthorDate: Sun Aug 11 16:22:51 2019 +0200 minor change --- .../config/triggeredscraper/TriggeredJobConfigurationBuilder.java | 1 - .../scraper/config/triggeredscraper/TriggeredScraperConfiguration.java | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/TriggeredJobConfigurationBuilder.java b/plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/TriggeredJobConfigurationBuilder.java index afcb852..817c3c9 100644 --- a/plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/TriggeredJobConfigurationBuilder.java +++ b/plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/TriggeredJobConfigurationBuilder.java @@ -19,7 +19,6 @@ package org.apache.plc4x.java.scraper.config.triggeredscraper; -import org.apache.commons.lang3.Validate; import org.apache.plc4x.java.scraper.exception.ScraperConfigurationException; import java.util.ArrayList; diff --git a/plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/TriggeredScraperConfiguration.java b/plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/TriggeredScraperConfiguration.java index 1051b17..40e66ee 100644 --- a/plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/TriggeredScraperConfiguration.java +++ b/plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/triggeredscraper/TriggeredScraperConfiguration.java @@ -61,7 +61,6 @@ public class TriggeredScraperConfiguration { public TriggeredScraperConfiguration(@JsonProperty(value = "sources", required = true) Map<String, String> sources, @JsonProperty(value = "jobs", required = true) List<TriggeredJobConfiguration> jobConfigurations) { checkNoUnreferencedSources(sources, jobConfigurations); - // TODO Warning on too many sources?! this.sources = sources; this.jobConfigurations = jobConfigurations; } @@ -123,7 +122,7 @@ public class TriggeredScraperConfiguration { public List<ScrapeJob> getJobs() throws ScraperException { List<ScrapeJob> scrapeJobs = new ArrayList<>(); for(JobConfiguration jobConfiguration:jobConfigurations){ - if(jobConfiguration instanceof JobConfigurationImpl){ + if(jobConfiguration instanceof TriggeredJobConfiguration){ JobConfigurationImpl jobConfigurationImpl = (JobConfigurationImpl)jobConfiguration; scrapeJobs.add(new ScrapeJobImpl(jobConfiguration.getName(), jobConfigurationImpl.getScrapeRate(),
