[plc4x] branch develop updated: test(plc4go/api): added test for plc_value

[sruehl]

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new 51cab70029 test(plc4go/api): added test for plc_value
51cab70029 is described below

commit 51cab70029ad3ba423c361681cdf8d4897ed2386
Author: Sebastian Rühl <sru...@apache.org>
AuthorDate: Wed May 24 16:59:47 2023 +0200

    test(plc4go/api): added test for plc_value
---
 plc4go/pkg/api/values/plc_value.go  |  2 +-
 plc4go/pkg/api/values/value_test.go | 78 +++++++++++++++++++++++++++++++++++++
 2 files changed, 79 insertions(+), 1 deletion(-)

diff --git a/plc4go/pkg/api/values/plc_value.go 
b/plc4go/pkg/api/values/plc_value.go
index bc938b6b16..d110b303d6 100644
--- a/plc4go/pkg/api/values/plc_value.go
+++ b/plc4go/pkg/api/values/plc_value.go
@@ -258,7 +258,7 @@ func (p PlcValueType) String() string {
        return "Unknown"
 }
 
-func PlcValueByName(value string) (PlcValueType, bool) {
+func PlcValueByName(value string) (valueType PlcValueType, ok bool) {
        switch value {
        case "NULL":
                return NULL, true
diff --git a/plc4go/pkg/api/values/value_test.go 
b/plc4go/pkg/api/values/value_test.go
new file mode 100644
index 0000000000..234cf1fde5
--- /dev/null
+++ b/plc4go/pkg/api/values/value_test.go
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package values
+
+import (
+       "fmt"
+       "github.com/stretchr/testify/assert"
+       "testing"
+)
+
+func TestValues(t *testing.T) {
+       values := []PlcValueType{
+               NULL,
+               BOOL,
+               BYTE,
+               WORD,
+               DWORD,
+               LWORD,
+               USINT,
+               UINT,
+               UDINT,
+               ULINT,
+               SINT,
+               INT,
+               DINT,
+               LINT,
+               REAL,
+               LREAL,
+               CHAR,
+               WCHAR,
+               STRING,
+               WSTRING,
+               TIME,
+               LTIME,
+               DATE,
+               LDATE,
+               TIME_OF_DAY,
+               LTIME_OF_DAY,
+               DATE_AND_TIME,
+               LDATE_AND_TIME,
+               Struct,
+               List,
+               RAW_BYTE_ARRAY,
+               0xFF,
+       }
+       for _, value := range values {
+               t.Run(fmt.Sprintf("value %d", value), func(t *testing.T) {
+                       valueString := value.String()
+                       assert.NotEmpty(t, valueString)
+                       valueType, ok := PlcValueByName(valueString)
+                       expectedValue := value
+                       expectedOk := true
+                       if value == 0xff {
+                               expectedValue = NULL
+                               expectedOk = false
+                       }
+                       assert.Equal(t, expectedValue, valueType, "value type 
not equals")
+                       assert.Equal(t, expectedOk, ok, "ok state doesn't 
match")
+               })
+       }
+}