IsmoLeszczynski opened a new pull request, #2192: URL: https://github.com/apache/plc4x/pull/2192
This PR addresses both #2060 and #2059. https://github.com/apache/plc4x/commit/66467ef22a3b78f6b928cd7c2c7eff6d0c233904 : The ModbusOptimizer handling for reading Coils and Discrete Inputs didn't check if the response was actually an array of booleans, always returning only the first bit instead of a list of bits in such cases. I added support for checking should the response be handled as a `PlcBOOL` or `PlcList`. https://github.com/apache/plc4x/commit/cdebad657006d633c7fa5599361f56f6e7f35049 : The driver originally had support for Byte Swapping, but it the world of Modbus there is also need for Word Swapping, and even a combination of both. I extended the `ModbusByteOrder` to include the new variations. Given, having the different variations in the enum isn't perfect, but it required the least changes and won't break anything. Alternatively these could be as separate options, but I don't think it's worth the effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
