JonasH-munters commented on PR #2251: URL: https://github.com/apache/plc4x/pull/2251#issuecomment-3274633500
I assumed that the intention was there to support a consumer per tag since `PlcSubscriptionRequest` defines, for each method adding a tag/tagAddress, a method for adding them together with a consumer as well. And since it was so easy for me to implement fully that strengthened that reasoning about the intention here. If you know some reason to not allow implementing consumers per tag that would be unfortunate since I'd have to solve my use case in some other way, but I'd just have to adapt :D In that case I'm assuming that at least the consumer for the whole request is intended to be registered with the Subscription. In any case, if any of the types of consumers that can be added to the request shouldn't be used in the subscription might I suggest logging a message or something to the developer so that they can see that they are trying to do something that won't have an effect? That'd have saved me time at least when I was troubleshooting why all the consumers I added were never called. (getting a bit ahead of things since this last paragraph is irrelevant if this PR is accepted as is). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
