chrisdutz commented on PR #2407: URL: https://github.com/apache/plc4x/pull/2407#issuecomment-3705039703
Admittedly I don't quite understand that change ... the plugin is only used (except for the mspec-tests) inside the update-generated-code profile. Also do we run the code generation in a preparation step before starting the release:prepare & repease:perform steps. As far as I can see it, only the "apache-release" profile is enabled when building the jars for maven central. (That might have been different in the past, but should be that way now) Could you elaborate a bit on why this change is needed? Even if it's a trivial change, I can see "skip-code-generation" is being defined and set to false, but it's not used anywhere, so removing the property all together seems to make more sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
