splatch commented on code in PR #2458:
URL: https://github.com/apache/plc4x/pull/2458#discussion_r2836638474
##########
protocols/opcua/src/main/xslt/opc-manual.xsl:
##########
@@ -225,7 +225,7 @@
[typeSwitch encodingMask.xmlBody, encodingMask.binaryBody
['false', 'true' BinaryExtensionObjectWithMask
[implicit int 32 bodyLength 'body == null ? 0 :
body.lengthInBytes']
- [simple ExtensionObjectDefinition('extensionId') body]
+ [manual ExtensionObjectDefinition body
'STATIC_CALL("parseExtensionObjectBody", readBuffer, extensionId, bodyLength)'
'STATIC_CALL("serializeExtensionObjectBody", writeBuffer, body)' 'body == null
? 0 : body.lengthInBits']
Review Comment:
I understand reason for the change, but better move needed logic and
`UnknownExtensionObject` to mspec, so it will be portable across languages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
