chrisdutz commented on PR #2605: URL: https://github.com/apache/plc4x/pull/2605#issuecomment-4738662261
Hi Prashant, welcome to the PLC4X project :-) Regarding your proposed changes ... you refer to two simple types of issue, but provide what looks to me as a complete rewrite of the COTP transport. As this technically has no correlation with the PlcValue types and I don't quite see how these changes fix what you propose they do. However this seems to be a pattern, having a look at other PRs you submitted to other projects. So let me give you this bit of advice: Start with small PRs, fix one atomic issue at a time, don't rewrite big portions of code without any form of interaction with the community before. I will not accept this PR without any form of clarification from your side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
