Author: yegor
Date: Wed Oct 10 11:09:48 2012
New Revision: 1396543
URL: http://svn.apache.org/viewvc?rev=1396543&view=rev
Log:
Bugzilla >53974 - Avoid exception when constructing HSSFWorbook on Google App
Engine
Modified:
poi/trunk/src/documentation/content/xdocs/status.xml
poi/trunk/src/java/org/apache/poi/hssf/model/InternalWorkbook.java
Modified: poi/trunk/src/documentation/content/xdocs/status.xml
URL:
http://svn.apache.org/viewvc/poi/trunk/src/documentation/content/xdocs/status.xml?rev=1396543&r1=1396542&r2=1396543&view=diff
==============================================================================
--- poi/trunk/src/documentation/content/xdocs/status.xml (original)
+++ poi/trunk/src/documentation/content/xdocs/status.xml Wed Oct 10 11:09:48
2012
@@ -34,6 +34,7 @@
<changes>
<release version="3.9-beta1" date="2012-??-??">
+ <action dev="poi-developers" type="fix">53974 - Avoid NPE when
constructing HSSFWorbook on Google App Engine</action>
<action dev="poi-developers" type="fix">53568 - Fixed null returned
by XSSFPicture.getPictureData()</action>
<action dev="poi-developers" type="fix">53950 - fixed
setForceFormulaRecalculation to reset workbook-level "manual" flag</action>
<action dev="poi-developers" type="fix">52211 - avoid unnessary
re-coverting content types to US-ASCII, it can cause exceptions on ibm
mainframes</action>
Modified: poi/trunk/src/java/org/apache/poi/hssf/model/InternalWorkbook.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/model/InternalWorkbook.java?rev=1396543&r1=1396542&r2=1396543&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/model/InternalWorkbook.java
(original)
+++ poi/trunk/src/java/org/apache/poi/hssf/model/InternalWorkbook.java Wed Oct
10 11:09:48 2012
@@ -1094,12 +1094,17 @@ public final class InternalWorkbook {
private static WriteAccessRecord createWriteAccess() {
WriteAccessRecord retval = new WriteAccessRecord();
+ String defaultUserName = "POI";
try {
- retval.setUsername(System.getProperty("user.name"));
+ String username = System.getProperty("user.name");
+ // Google App engine returns null for user.name, see Bug 53974
+ if(username == null) username = defaultUserName;
+
+ retval.setUsername(username);
} catch (AccessControlException e) {
// AccessControlException can occur in a restricted context
// (client applet/jws application or restricted security
server)
- retval.setUsername("POI");
+ retval.setUsername(defaultUserName);
}
return retval;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
