Author: nick
Date: Mon May  6 16:53:04 2013
New Revision: 1479639

URL: http://svn.apache.org/r1479639
Log:
Fix #54891 - correct javadoc on HSSF + SS (XSSF was correct) for 
Row.createCell(int,int)

Modified:
    poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java
    poi/trunk/src/java/org/apache/poi/ss/usermodel/Row.java

Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java?rev=1479639&r1=1479638&r2=1479639&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFRow.java Mon May  6 
16:53:04 2013
@@ -129,8 +129,10 @@ public final class HSSFRow implements Ro
     /**
      * Use this to create new cells within the row and return it.
      * <p>
-     * The cell that is returned is a CELL_TYPE_BLANK. The type can be changed
-     * either through calling setCellValue or setCellType.
+     * The cell that is returned will be of the requested type.
+     * The type can be changed either through calling setCellValue 
+     *  or setCellType, but there is a small overhead to doing this,
+     *  so it is best to create of the required type up front.
      *
      * @param columnIndex - the column number this cell represents
      *

Modified: poi/trunk/src/java/org/apache/poi/ss/usermodel/Row.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/Row.java?rev=1479639&r1=1479638&r2=1479639&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/usermodel/Row.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/usermodel/Row.java Mon May  6 16:53:04 
2013
@@ -40,13 +40,22 @@ public interface Row extends Iterable<Ce
     /**
      * Use this to create new cells within the row and return it.
      * <p>
-     * The cell that is returned is a {@link Cell#CELL_TYPE_BLANK}. The type 
can be changed
-     * either through calling setCellValue or setCellType.
+     * The cell that is returned will be of the requested type.
+     * The type can be changed either through calling setCellValue 
+     *  or setCellType, but there is a small overhead to doing this,
+     *  so it is best to create of the required type up front.
      *
      * @param column - the column number this cell represents
+     * @param type - the cell's data type
      * @return Cell a high level representation of the created cell.
      * @throws IllegalArgumentException if columnIndex < 0 or greate than a 
maximum number of supported columns
      * (255 for *.xls, 1048576 for *.xlsx)
+     * @see Cell#CELL_TYPE_BLANK
+     * @see Cell#CELL_TYPE_BOOLEAN
+     * @see Cell#CELL_TYPE_ERROR
+     * @see Cell#CELL_TYPE_FORMULA
+     * @see Cell#CELL_TYPE_NUMERIC
+     * @see Cell#CELL_TYPE_STRING
      */
     Cell createCell(int column, int type);
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to