Author: centic
Date: Sun May 17 21:26:31 2015
New Revision: 1679903

URL: http://svn.apache.org/r1679903
Log:
Move location where document is held and adjust constructors and 
class-hierarchy accordingly

Modified:
    poi/trunk/src/java/org/apache/poi/POIOLE2TextExtractor.java
    poi/trunk/src/java/org/apache/poi/POITextExtractor.java
    
poi/trunk/src/java/org/apache/poi/hpsf/extractor/HPSFPropertiesExtractor.java
    
poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
    poi/trunk/src/ooxml/java/org/apache/poi/POIXMLTextExtractor.java

Modified: poi/trunk/src/java/org/apache/poi/POIOLE2TextExtractor.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/POIOLE2TextExtractor.java?rev=1679903&r1=1679902&r2=1679903&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/POIOLE2TextExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/POIOLE2TextExtractor.java Sun May 17 
21:26:31 2015
@@ -33,16 +33,28 @@ import org.apache.poi.poifs.filesystem.D
  * @see org.apache.poi.hwpf.extractor.WordExtractor
  */
 public abstract class POIOLE2TextExtractor extends POITextExtractor {
+       /** The POIDocument that's open */
+       protected POIDocument document;
+
        /**
         * Creates a new text extractor for the given document
         * 
         * @param document The POIDocument to use in this extractor.
         */
        public POIOLE2TextExtractor(POIDocument document) {
-               super(document);
+               this.document = document;
        }
 
        /**
+        * Creates a new text extractor, using the same
+        *  document as another text extractor. Normally
+        *  only used by properties extractors.
+        */
+       protected POIOLE2TextExtractor(POIOLE2TextExtractor otherExtractor) {
+               this.document = otherExtractor.document;
+       }
+       
+       /**
         * Returns the document information metadata for the document
         * 
      * @return The Document Summary Information or null 

Modified: poi/trunk/src/java/org/apache/poi/POITextExtractor.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/POITextExtractor.java?rev=1679903&r1=1679902&r2=1679903&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/POITextExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/POITextExtractor.java Sun May 17 21:26:31 
2015
@@ -31,24 +31,6 @@ import java.io.IOException;
  * @see org.apache.poi.hwpf.extractor.WordExtractor
  */
 public abstract class POITextExtractor implements Closeable {
-       /** The POIDocument that's open */
-       protected POIDocument document;
-
-       /**
-        * Creates a new text extractor for the given document
-        */
-       public POITextExtractor(POIDocument document) {
-               this.document = document;
-       }
-       /**
-        * Creates a new text extractor, using the same
-        *  document as another text extractor. Normally
-        *  only used by properties extractors.
-        */
-       protected POITextExtractor(POITextExtractor otherExtractor) {
-               this.document = otherExtractor.document;
-       }
-       
        /**
         * Retrieves all the text from the document.
         * How cells, paragraphs etc are separated in the text

Modified: 
poi/trunk/src/java/org/apache/poi/hpsf/extractor/HPSFPropertiesExtractor.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hpsf/extractor/HPSFPropertiesExtractor.java?rev=1679903&r1=1679902&r2=1679903&view=diff
==============================================================================
--- 
poi/trunk/src/java/org/apache/poi/hpsf/extractor/HPSFPropertiesExtractor.java 
(original)
+++ 
poi/trunk/src/java/org/apache/poi/hpsf/extractor/HPSFPropertiesExtractor.java 
Sun May 17 21:26:31 2015
@@ -23,6 +23,7 @@ import java.io.IOException;
 import java.util.Iterator;
 
 import org.apache.poi.POIDocument;
+import org.apache.poi.POIOLE2TextExtractor;
 import org.apache.poi.POITextExtractor;
 import org.apache.poi.hpsf.CustomProperties;
 import org.apache.poi.hpsf.DocumentSummaryInformation;
@@ -39,10 +40,10 @@ import org.apache.poi.poifs.filesystem.P
  *  build in and custom, returning them in
  *  textual form.
  */
-public class HPSFPropertiesExtractor extends POITextExtractor {
+public class HPSFPropertiesExtractor extends POIOLE2TextExtractor {
     private Closeable toClose;
 
-    public HPSFPropertiesExtractor(POITextExtractor mainExtractor) {
+    public HPSFPropertiesExtractor(POIOLE2TextExtractor mainExtractor) {
         super(mainExtractor);
     }
     public HPSFPropertiesExtractor(POIDocument doc) {

Modified: 
poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java?rev=1679903&r1=1679902&r2=1679903&view=diff
==============================================================================
--- 
poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java 
(original)
+++ 
poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java 
Sun May 17 21:26:31 2015
@@ -21,6 +21,7 @@ import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.poi.POIDocument;
 import org.apache.poi.POIOLE2TextExtractor;
 import org.apache.poi.hpsf.DocumentSummaryInformation;
 import org.apache.poi.hpsf.SummaryInformation;
@@ -75,7 +76,7 @@ public class EventBasedExcelExtractor ex
 
     public EventBasedExcelExtractor( DirectoryNode dir )
     {
-        super( null );
+        super( (POIDocument)null );
         _dir = dir;
     }
 

Modified: poi/trunk/src/ooxml/java/org/apache/poi/POIXMLTextExtractor.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/POIXMLTextExtractor.java?rev=1679903&r1=1679902&r2=1679903&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/POIXMLTextExtractor.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/POIXMLTextExtractor.java Sun May 17 
21:26:31 2015
@@ -32,8 +32,6 @@ public abstract class POIXMLTextExtracto
         * Creates a new text extractor for the given document
         */
        public POIXMLTextExtractor(POIXMLDocument document) {
-               super((POIDocument)null);
-
                _document = document;
        }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to