Author: kiwiwings
Date: Sat Aug 15 13:05:00 2015
New Revision: 1696050
URL: http://svn.apache.org/r1696050
Log:
FindBugs - DLS_DEAD_LOCAL_STORE
Modified:
poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java
poi/trunk/src/java/org/apache/poi/poifs/storage/DataInputBlock.java
poi/trunk/src/scratchpad/src/org/apache/poi/hdf/extractor/WordDocument.java
Modified: poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java?rev=1696050&r1=1696049&r2=1696050&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java
(original)
+++ poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java Sat
Aug 15 13:05:00 2015
@@ -328,8 +328,7 @@ public class DataSpaceMapUtils {
public static String readUtf8LPP4(LittleEndianInput is) {
int length = is.readInt();
if (length == 0 || length == 4) {
- @SuppressWarnings("unused")
- int skip = is.readInt(); // ignore
+ /* int skip = */ is.readInt();
return length == 0 ? null : "";
}
Modified: poi/trunk/src/java/org/apache/poi/poifs/storage/DataInputBlock.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/storage/DataInputBlock.java?rev=1696050&r1=1696049&r2=1696050&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/storage/DataInputBlock.java
(original)
+++ poi/trunk/src/java/org/apache/poi/poifs/storage/DataInputBlock.java Sat Aug
15 13:05:00 2015
@@ -79,7 +79,7 @@ public final class DataInputBlock {
// simple case - will always be one byte in each block
int i = prevBlock._buf.length-1;
- int b0 = prevBlock._buf[i++] & 0xFF;
+ int b0 = prevBlock._buf[i] & 0xFF;
int b1 = _buf[_readIndex++] & 0xFF;
return (b1 << 8) + (b0 << 0);
}
Modified:
poi/trunk/src/scratchpad/src/org/apache/poi/hdf/extractor/WordDocument.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hdf/extractor/WordDocument.java?rev=1696050&r1=1696049&r2=1696050&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hdf/extractor/WordDocument.java
(original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hdf/extractor/WordDocument.java
Sat Aug 15 13:05:00 2015
@@ -1485,16 +1485,16 @@ public final class WordDocument {
_headerBuffer.append("</fo:simple-page-master>\r\n");
return thisPage;
}
- @SuppressWarnings("unused")
+
private void addBorder(StringBuffer buf, short[] brc, String where)
{
if((brc[0] & 0xff00) != 0 && brc[0] != -1)
{
- int type = (brc[0] & 0xff00) >> 8;
+ // int type = (brc[0] & 0xff00) >> 8;
float width = (brc[0] & 0x00ff)/8.0f;
String style = getBorderStyle(brc[0]);
String color = getColor(brc[1] & 0x00ff);
- String thickness = getBorderThickness(brc[0]);
+ // String thickness = getBorderThickness(brc[0]);
buf.append("border-" + where + "-style=\"" + style + "\"\r\n");
buf.append("border-" + where + "-color=\"" + color + "\"\r\n");
buf.append("border-" + where + "-width=\"" + width + "pt\"\r\n");
@@ -1520,22 +1520,22 @@ public final class WordDocument {
t.printStackTrace();
}
}
- private String getBorderThickness(int style)
- {
- switch(style)
- {
- case 1:
- return "medium";
- case 2:
- return "thick";
- case 3:
- return "medium";
- case 5:
- return "thin";
- default:
- return "medium";
- }
- }
+// private String getBorderThickness(int style)
+// {
+// switch(style)
+// {
+// case 1:
+// return "medium";
+// case 2:
+// return "thick";
+// case 3:
+// return "medium";
+// case 5:
+// return "thin";
+// default:
+// return "medium";
+// }
+// }
private String getColor(int ico)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
