Author: kiwiwings
Date: Wed Mar 16 21:46:28 2016
New Revision: 1735312
URL: http://svn.apache.org/viewvc?rev=1735312&view=rev
Log:
findbugs fixes
Modified:
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/EMF.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/WMF.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfHeader.java
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/EMF.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/EMF.java?rev=1735312&r1=1735311&r2=1735312&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/EMF.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/EMF.java Wed Mar 16
21:46:28 2016
@@ -76,7 +76,8 @@ public final class EMF extends Metafile
InputStream is = new ByteArrayInputStream( rawdata );
Header header = new Header();
header.read(rawdata, CHECKSUM_SIZE);
- is.skip(header.getSize() + CHECKSUM_SIZE);
+ long len = is.skip(header.getSize() + CHECKSUM_SIZE);
+ assert(len == header.getSize() + CHECKSUM_SIZE);
InflaterInputStream inflater = new InflaterInputStream( is );
byte[] chunk = new byte[4096];
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/WMF.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/WMF.java?rev=1735312&r1=1735311&r2=1735312&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/WMF.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/WMF.java Wed Mar 16
21:46:28 2016
@@ -46,7 +46,8 @@ public final class WMF extends Metafile
InputStream is = new ByteArrayInputStream( rawdata );
Header header = new Header();
header.read(rawdata, CHECKSUM_SIZE*uidInstanceCount);
- is.skip(header.getSize() + CHECKSUM_SIZE*uidInstanceCount);
+ long len = is.skip(header.getSize() +
CHECKSUM_SIZE*uidInstanceCount);
+ assert(len == header.getSize() + CHECKSUM_SIZE*uidInstanceCount);
NativeHeader aldus = new NativeHeader(header.bounds);
aldus.write(out);
Modified:
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfHeader.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfHeader.java?rev=1735312&r1=1735311&r2=1735312&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfHeader.java
(original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfHeader.java Wed
Mar 16 21:46:28 2016
@@ -70,7 +70,8 @@ public class HwmfHeader {
bytesLeft -= LittleEndianConsts.SHORT_SIZE;
if (bytesLeft > 0) {
- leis.skip(bytesLeft);
+ long len = leis.skip(bytesLeft);
+ assert(len == bytesLeft);
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
