Author: kiwiwings
Date: Sun Jun 19 01:06:55 2016
New Revision: 1749116
URL: http://svn.apache.org/viewvc?rev=1749116&view=rev
Log:
findbugs fixes - ME_MUTABLE_ENUM_FIELD
Modified:
poi/trunk/src/java/org/apache/poi/sl/usermodel/PresetColor.java
poi/trunk/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
Modified: poi/trunk/src/java/org/apache/poi/sl/usermodel/PresetColor.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/sl/usermodel/PresetColor.java?rev=1749116&r1=1749115&r2=1749116&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/sl/usermodel/PresetColor.java (original)
+++ poi/trunk/src/java/org/apache/poi/sl/usermodel/PresetColor.java Sun Jun 19
01:06:55 2016
@@ -247,9 +247,9 @@ public enum PresetColor {
MenuHighlight (0xff3399ff, 174, "menuHighlight")
;
- public Color color;
- public int nativeId;
- public String ooxmlId;
+ public final Color color;
+ public final int nativeId;
+ public final String ooxmlId;
PresetColor(Integer rgb, int nativeId, String ooxmlId) {
this.color = (rgb == null) ? null : new Color(rgb, true);
Modified:
poi/trunk/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java?rev=1749116&r1=1749115&r2=1749116&view=diff
==============================================================================
---
poi/trunk/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
(original)
+++
poi/trunk/src/java/org/apache/poi/ss/usermodel/ConditionalFormattingThreshold.java
Sun Jun 19 01:06:55 2016
@@ -43,7 +43,7 @@ public interface ConditionalFormattingTh
FORMULA(7, "formula");
/** Numeric ID of the type */
- public int id;
+ public final int id;
/** Name (system) of the type */
public final String name;
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java?rev=1749116&r1=1749115&r2=1749116&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java
(original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfFill.java Sun
Jun 19 01:06:55 2016
@@ -57,7 +57,7 @@ public class HwmfFill {
;
- int flag;
+ public final int flag;
ColorUsage(int flag) {
this.flag = flag;
}
@@ -208,8 +208,8 @@ public class HwmfFill {
*/
WINDING(0x0002, Path2D.WIND_NON_ZERO);
- public int wmfFlag;
- public int awtFlag;
+ public final int wmfFlag;
+ public final int awtFlag;
HwmfPolyfillMode(int wmfFlag, int awtFlag) {
this.wmfFlag = wmfFlag;
this.awtFlag = awtFlag;
Modified:
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java?rev=1749116&r1=1749115&r2=1749116&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
(original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfPenStyle.java
Sun Jun 19 01:06:55 2016
@@ -41,8 +41,8 @@ public class HwmfPenStyle implements Clo
/** Line ends at end point*/
FLAT(2, BasicStroke.CAP_BUTT);
- public int wmfFlag;
- public int awtFlag;
+ public final int wmfFlag;
+ public final int awtFlag;
HwmfLineCap(int wmfFlag, int awtFlag) {
this.wmfFlag = wmfFlag;
this.awtFlag = awtFlag;
@@ -67,8 +67,8 @@ public class HwmfPenStyle implements Clo
*/
MITER(2, BasicStroke.JOIN_MITER);
- public int wmfFlag;
- public int awtFlag;
+ public final int wmfFlag;
+ public final int awtFlag;
HwmfLineJoin(int wmfFlag, int awtFlag) {
this.wmfFlag = wmfFlag;
this.awtFlag = awtFlag;
@@ -121,8 +121,8 @@ public class HwmfPenStyle implements Clo
USERSTYLE(0x0007, null);
- public int wmfFlag;
- public float[] dashes;
+ public final int wmfFlag;
+ public final float[] dashes;
HwmfLineDash(int wmfFlag, float... dashes) {
this.wmfFlag = wmfFlag;
this.dashes = dashes;
Modified:
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java?rev=1749116&r1=1749115&r2=1749116&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
(original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfRecordType.java
Sun Jun 19 01:06:55 2016
@@ -95,8 +95,8 @@ public enum HwmfRecordType {
,textOut(0x0521, HwmfText.WmfTextOut.class)
;
- public int id;
- public Class<? extends HwmfRecord> clazz;
+ public final int id;
+ public final Class<? extends HwmfRecord> clazz;
HwmfRecordType(int id, Class<? extends HwmfRecord> clazz) {
this.id = id;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org
