Author: nick
Date: Fri Feb 10 14:02:12 2017
New Revision: 1782472
URL: http://svn.apache.org/viewvc?rev=1782472&view=rev
Log:
Add a possible future TODO
Modified:
poi/trunk/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java
Modified: poi/trunk/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java?rev=1782472&r1=1782471&r2=1782472&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java
(original)
+++ poi/trunk/src/java/org/apache/poi/poifs/nio/FileBackedDataSource.java Fri
Feb 10 14:02:12 2017
@@ -88,6 +88,11 @@ public class FileBackedDataSource extend
throw new IndexOutOfBoundsException("Position " + position + " past
the end of the file");
}
+ // TODO Could we do the read-only case with MapMode.PRIVATE instead?
+ // See
https://docs.oracle.com/javase/7/docs/api/java/nio/channels/FileChannel.MapMode.html#PRIVATE
+ // Or should we have 3 modes instead of the current boolean -
+ // read-write, read-only, read-to-write-elsewhere?
+
// Do we read or map (for read/write)?
ByteBuffer dst;
if (writable) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
