Author: onealj
Date: Thu Feb 16 06:15:13 2017
New Revision: 1783174

URL: http://svn.apache.org/viewvc?rev=1783174&view=rev
Log:
OLD_FILES, EXPECTED_FAILURES, and IGNORED do not need to be modified when 
executing TestAllFiles

Modified:
    poi/trunk/src/integrationtest/org/apache/poi/TestAllFiles.java

Modified: poi/trunk/src/integrationtest/org/apache/poi/TestAllFiles.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/integrationtest/org/apache/poi/TestAllFiles.java?rev=1783174&r1=1783173&r2=1783174&view=diff
==============================================================================
--- poi/trunk/src/integrationtest/org/apache/poi/TestAllFiles.java (original)
+++ poi/trunk/src/integrationtest/org/apache/poi/TestAllFiles.java Thu Feb 16 
06:15:13 2017
@@ -177,12 +177,15 @@ public class TestAllFiles {
         HANDLERS.put("spreadsheet/test_properties1", new NullFileHandler());
     }
 
+    private static final Set<String> unmodifiableHashSet(String... a) {
+        return Collections.unmodifiableSet(hashSet(a));
+    }
     private static final Set<String> hashSet(String... a) {
         return new HashSet<String>(Arrays.asList(a));
     }
 
     // Old Word Documents where we can at least extract some text
-    private static final Set<String> OLD_FILES = hashSet(
+    private static final Set<String> OLD_FILES = unmodifiableHashSet(
         "document/Bug49933.doc",
         "document/Bug51944.doc",
         "document/Word6.doc",
@@ -194,7 +197,7 @@ public class TestAllFiles {
         "document/52117.doc"
     );
 
-    private static final Set<String> EXPECTED_FAILURES = hashSet(
+    private static final Set<String> EXPECTED_FAILURES = unmodifiableHashSet(
         // password protected files
         "spreadsheet/password.xls",
         "spreadsheet/protected_passtika.xlsx",
@@ -284,7 +287,7 @@ public class TestAllFiles {
         "spreadsheet/ConditionalFormattingSamples.xls"
     );
 
-    private static final Set<String> IGNORED = hashSet(
+    private static final Set<String> IGNORED = unmodifiableHashSet(
         // need JDK8+ - https://bugs.openjdk.java.net/browse/JDK-8038081
         "slideshow/42474-2.ppt",
         // OPC handler works / XSSF handler fails



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to