Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/EllipticalArcTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/EllipticalArcTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/EllipticalArcTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/EllipticalArcTo.java Sat Sep 16 08:22:59 2017 @@ -30,36 +30,36 @@ import com.microsoft.schemas.office.visi public class EllipticalArcTo implements GeometryRow { - EllipticalArcTo _master = null; + EllipticalArcTo _master; // The x-coordinate of the ending vertex on an arc. - Double x = null; + Double x; // The y-coordinate of the ending vertex on an arc. - Double y = null; + Double y; // The x-coordinate of the arc's control point; a point on the arc. The // control point is best located about halfway between the beginning and // ending vertices of the arc. Otherwise, the arc may grow to an extreme // size in order to pass through the control point, with unpredictable // results. - Double a = null; + Double a; // The y-coordinate of an arc's control point. - Double b = null; + Double b; // The angle of an arc's major axis relative to the x-axis of its parent // shape. - Double c = null; + Double c; // The ratio of an arc's major axis to its minor axis. Despite the usual // meaning of these words, the "major" axis does not have to be greater than // the "minor" axis, so this ratio does not have to be greater than 1. // Setting this cell to a value less than or equal to 0 or greater than 1000 // can lead to unpredictable results. - Double d = null; + Double d; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas @@ -129,7 +129,7 @@ public class EllipticalArcTo implements _master = (EllipticalArcTo) row; } - public static int draw = 0; + public static int draw; @Override public void addToPath(java.awt.geom.Path2D.Double path, XDGFShape parent) {
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/InfiniteLine.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/InfiniteLine.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/InfiniteLine.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/InfiniteLine.java Sat Sep 16 08:22:59 2017 @@ -31,25 +31,25 @@ import com.microsoft.schemas.office.visi */ public class InfiniteLine implements GeometryRow { - InfiniteLine _master = null; + InfiniteLine _master; // An x-coordinate of a point on the infinite line; paired with y-coordinate // represented by the Y cell. - Double x = null; + Double x; // A y-coordinate of a point on the infinite line; paired with x-coordinate // represented by the X cell. - Double y = null; + Double y; // An x-coordinate of a point on the infinite line; paired with y-coordinate // represented by the B cell. - Double a = null; + Double a; // A y-coordinate of a point on an infinite line; paired with x-coordinate // represented by the A cell. - Double b = null; + Double b; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/LineTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/LineTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/LineTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/LineTo.java Sat Sep 16 08:22:59 2017 @@ -26,12 +26,12 @@ import com.microsoft.schemas.office.visi public class LineTo implements GeometryRow { - LineTo _master = null; + LineTo _master; - Double x = null; - Double y = null; + Double x; + Double y; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/MoveTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/MoveTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/MoveTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/MoveTo.java Sat Sep 16 08:22:59 2017 @@ -31,12 +31,12 @@ import com.microsoft.schemas.office.visi */ public class MoveTo implements GeometryRow { - MoveTo _master = null; + MoveTo _master; - Double x = null; - Double y = null; + Double x; + Double y; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/NURBSTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/NURBSTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/NURBSTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/NURBSTo.java Sat Sep 16 08:22:59 2017 @@ -33,30 +33,30 @@ import com.microsoft.schemas.office.visi public class NURBSTo implements GeometryRow { - NURBSTo _master = null; + NURBSTo _master; // The x-coordinate of the last control point of a NURBS. - Double x = null; + Double x; // The y-coordinate of the last control point of a NURBS. - Double y = null; + Double y; // The second to the last knot of the NURBS. - Double a = null; + Double a; // The last weight of the NURBS. - Double b = null; + Double b; // The first knot of the NURBS. - Double c = null; + Double c; // The first weight of the NURBS. - Double d = null; + Double d; // A NURBS formula. - String e = null; + String e; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java Sat Sep 16 08:22:59 2017 @@ -27,18 +27,18 @@ import com.microsoft.schemas.office.visi public class PolyLineTo implements GeometryRow { - PolyLineTo _master = null; + PolyLineTo _master; // The x-coordinate of the ending vertex of a polyline. - Double x = null; + Double x; // The y-coordinate of the ending vertex of a polyline. - Double y = null; + Double y; // The polyline formula - String a = null; + String a; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelCubBezTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelCubBezTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelCubBezTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelCubBezTo.java Sat Sep 16 08:22:59 2017 @@ -26,35 +26,35 @@ import com.microsoft.schemas.office.visi public class RelCubBezTo implements GeometryRow { - RelCubBezTo _master = null; + RelCubBezTo _master; // The x-coordinate of the ending vertex of a cubic Bezier curve relative to // the width of the shape. - Double x = null; + Double x; // The y-coordinate of the ending vertex of a cubic Bezier curve relative to // the height of the shape. - Double y = null; + Double y; // The x-coordinate of the curve's beginning control point relative to the // shape's width; a point on the arc. The control point is best located // between the beginning and ending vertices of the arc. - Double a = null; + Double a; // The y-coordinate of a curve's beginning control point relative to the // shape's height. - Double b = null; + Double b; // The x-coordinate of the curve's ending control point relative to the // shape's width; a point on the arc. The control point is best located // between the beginning control point and ending vertices of the arc. - Double c = null; + Double c; // The y-coordinate of a curve's ending control point relative to the // shape's height. - Double d = null; + Double d; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelEllipticalArcTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelEllipticalArcTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelEllipticalArcTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelEllipticalArcTo.java Sat Sep 16 08:22:59 2017 @@ -26,32 +26,32 @@ import com.microsoft.schemas.office.visi public class RelEllipticalArcTo implements GeometryRow { - RelEllipticalArcTo _master = null; + RelEllipticalArcTo _master; // The x-coordinate of the ending vertex on an arc relative to the width of // the shape. - Double x = null; + Double x; // The y-coordinate of the ending vertex on an arc relative to the height of // the shape. - Double y = null; + Double y; // The x-coordinate of the arc's control point relative to the shape's // width; a point on the arc. - Double a = null; + Double a; // The y-coordinate of an arc's control point relative to the shape's width. - Double b = null; + Double b; // The angle of an arc's major axis relative to the x-axis of its parent. - Double c = null; + Double c; // The ratio of an arc's major axis to its minor axis. Despite the usual // meaning of these words, the "major" axis does not have to be greater than // the "minor" axis, so this ratio does not have to be greater than 1. - Double d = null; + Double d; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelLineTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelLineTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelLineTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelLineTo.java Sat Sep 16 08:22:59 2017 @@ -30,12 +30,12 @@ import com.microsoft.schemas.office.visi */ public class RelLineTo implements GeometryRow { - RelLineTo _master = null; + RelLineTo _master; - Double x = null; - Double y = null; + Double x; + Double y; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelMoveTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelMoveTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelMoveTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelMoveTo.java Sat Sep 16 08:22:59 2017 @@ -26,12 +26,12 @@ import com.microsoft.schemas.office.visi public class RelMoveTo implements GeometryRow { - RelMoveTo _master = null; + RelMoveTo _master; - Double x = null; - Double y = null; + Double x; + Double y; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelQuadBezTo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelQuadBezTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelQuadBezTo.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelQuadBezTo.java Sat Sep 16 08:22:59 2017 @@ -31,26 +31,26 @@ import com.microsoft.schemas.office.visi */ public class RelQuadBezTo implements GeometryRow { - RelQuadBezTo _master = null; + RelQuadBezTo _master; // The x-coordinate of the ending vertex of a quadratic Bezier curve // relative to the width of the shape. - Double x = null; + Double x; // The y-coordinate of the ending vertex of a quadratic Bezier curve // relative to the height of the shape. - Double y = null; + Double y; // The x-coordinate of the curve's control point relative to the shape's // width; a point on the arc. The control point is best located about // halfway between the beginning and ending vertices of the arc. - Double a = null; + Double a; // The y-coordinate of a curve's control point relative to the shape's // height. - Double b = null; + Double b; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineKnot.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineKnot.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineKnot.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineKnot.java Sat Sep 16 08:22:59 2017 @@ -30,18 +30,18 @@ import com.microsoft.schemas.office.visi */ public class SplineKnot implements GeometryRow { - SplineKnot _master = null; + SplineKnot _master; // The x-coordinate of a control point. - Double x = null; + Double x; // The y-coordinate of a control point. - Double y = null; + Double y; // One of the spline's knots (other than the last one or the first two). - Double a = null; + Double a; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineStart.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineStart.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineStart.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineStart.java Sat Sep 16 08:22:59 2017 @@ -29,27 +29,27 @@ import com.microsoft.schemas.office.visi */ public class SplineStart implements GeometryRow { - SplineStart _master = null; + SplineStart _master; // The x-coordinate of a spline's second control point. - Double x = null; + Double x; // The y-coordinate of a spline's second control point. - Double y = null; + Double y; // The second knot of the spline. - Double a = null; + Double a; // The first knot of a spline. - Double b = null; + Double b; // The last knot of a spline. - Double c = null; + Double c; // The degree of a spline (an integer from 1 to 25). - Integer d = null; + Integer d; - Boolean deleted = null; + Boolean deleted; // TODO: support formulas Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/shape/ShapeDebuggerRenderer.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/shape/ShapeDebuggerRenderer.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/shape/ShapeDebuggerRenderer.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/shape/ShapeDebuggerRenderer.java Sat Sep 16 08:22:59 2017 @@ -25,7 +25,7 @@ import org.apache.poi.xdgf.usermodel.XDG public class ShapeDebuggerRenderer extends ShapeRenderer { - ShapeVisitorAcceptor _debugAcceptor = null; + ShapeVisitorAcceptor _debugAcceptor; public ShapeDebuggerRenderer() { super(); Modified: poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java Sat Sep 16 08:22:59 2017 @@ -49,8 +49,8 @@ public class XSLFPowerPointExtractor ext private XMLSlideShow slideshow; private boolean slidesByDefault = true; - private boolean notesByDefault = false; - private boolean masterByDefault = false; + private boolean notesByDefault; + private boolean masterByDefault; public XSLFPowerPointExtractor(XMLSlideShow slideshow) { super(slideshow); Modified: poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFPictureData.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFPictureData.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFPictureData.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFPictureData.java Sat Sep 16 08:22:59 2017 @@ -43,10 +43,10 @@ import org.apache.poi.util.Units; */ @Beta public final class XSLFPictureData extends POIXMLDocumentPart implements PictureData { - private Long checksum = null; + private Long checksum; // original image dimensions (for formats supported by BufferedImage) - private Dimension origSize = null; + private Dimension origSize; private int index = -1; /** Modified: poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTableCell.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTableCell.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTableCell.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTableCell.java Sat Sep 16 08:22:59 2017 @@ -69,14 +69,14 @@ import org.openxmlformats.schemas.drawin * Represents a cell of a table in a .pptx presentation */ public class XSLFTableCell extends XSLFTextShape implements TableCell<XSLFShape,XSLFTextParagraph> { - private CTTableCellProperties _tcPr = null; + private CTTableCellProperties _tcPr; private final XSLFTable table; - private int row = 0, col = 0; + private int row, col; /** * Volatile/temporary anchor - e.g. for rendering */ - private Rectangle2D anchor = null; + private Rectangle2D anchor; /*package*/ XSLFTableCell(CTTableCell cell, XSLFTable table){ super(cell, table.getSheet()); Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBCommentsTable.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBCommentsTable.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBCommentsTable.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBCommentsTable.java Sat Sep 16 08:22:59 2017 @@ -42,9 +42,9 @@ public class XSSFBCommentsTable extends //these are all used only during parsing, and they are mutable! private int authorId = -1; - private CellAddress cellAddress = null; - private XSSFBCellRange cellRange = null; - private String comment = null; + private CellAddress cellAddress; + private XSSFBCellRange cellRange; + private String comment; private StringBuilder authorBuffer = new StringBuilder(); Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBSheetHandler.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBSheetHandler.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBSheetHandler.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBSheetHandler.java Sat Sep 16 08:22:59 2017 @@ -47,9 +47,9 @@ public class XSSFBSheetHandler extends X private int lastEndedRow = -1; private int lastStartedRow = -1; - private int currentRow = 0; + private int currentRow; private byte[] rkBuffer = new byte[8]; - private XSSFBCellRange hyperlinkCellRange = null; + private XSSFBCellRange hyperlinkCellRange; private StringBuilder xlWideStringBuffer = new StringBuilder(); private final XSSFBCellHeader cellBuffer = new XSSFBCellHeader(); Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBStylesTable.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBStylesTable.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBStylesTable.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBStylesTable.java Sat Sep 16 08:22:59 2017 @@ -40,8 +40,8 @@ public class XSSFBStylesTable extends XS private final SortedMap<Short, String> numberFormats = new TreeMap<Short,String>(); private final List<Short> styleIds = new ArrayList<Short>(); - private boolean inCellXFS = false; - private boolean inFmts = false; + private boolean inCellXFS; + private boolean inFmts; public XSSFBStylesTable(InputStream is) throws IOException { super(is); parse(); Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/XSSFBReader.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/XSSFBReader.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/XSSFBReader.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/XSSFBReader.java Sat Sep 16 08:22:59 2017 @@ -183,7 +183,7 @@ public class XSSFBReader extends XSSFRea static { RECORDS.set(XSSFBRecordType.BrtAbsPath15.getId()); } - private String path = null; + private String path; public PathExtractor(InputStream is) { super(is, RECORDS); } Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFBEventBasedExcelExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFBEventBasedExcelExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFBEventBasedExcelExtractor.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFBEventBasedExcelExtractor.java Sat Sep 16 08:22:59 2017 @@ -51,7 +51,7 @@ public class XSSFBEventBasedExcelExtract XSSFRelation.XLSB_BINARY_WORKBOOK }; - private boolean handleHyperlinksInCells = false; + private boolean handleHyperlinksInCells; public XSSFBEventBasedExcelExtractor(String path) throws XmlException, OpenXML4JException, IOException { super(path); Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFEventBasedExcelExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFEventBasedExcelExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFEventBasedExcelExtractor.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFEventBasedExcelExtractor.java Sat Sep 16 08:22:59 2017 @@ -65,9 +65,9 @@ public class XSSFEventBasedExcelExtracto private Locale locale; private boolean includeTextBoxes = true; private boolean includeSheetNames = true; - private boolean includeCellComments = false; + private boolean includeCellComments; private boolean includeHeadersFooters = true; - private boolean formulasNotResults = false; + private boolean formulasNotResults; private boolean concatenatePhoneticRuns = true; public XSSFEventBasedExcelExtractor(String path) throws XmlException, OpenXML4JException, IOException { Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java Sat Sep 16 08:22:59 2017 @@ -59,7 +59,7 @@ import org.apache.poi.util.Internal; // untrackedColumns stores columns have been explicitly untracked so they aren't implicitly re-tracked by trackAllColumns // Using a HashSet instead of a TreeSet because we don't care about order. private final Set<Integer> untrackedColumns = new HashSet<Integer>(); - private boolean trackAllColumns = false; + private boolean trackAllColumns; /** * Tuple to store the column widths considering and not considering merged cells Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java Sat Sep 16 08:22:59 2017 @@ -42,8 +42,8 @@ public class SXSSFRow implements Row, Co private final SortedMap<Integer, SXSSFCell> _cells = new TreeMap<Integer, SXSSFCell>(); private short _style = -1; // index of cell style in style table private short _height = -1; // row height in twips (1/20 point) - private boolean _zHeight = false; // row zero-height (this is somehow different than being hidden) - private int _outlineLevel = 0; // Outlining level of the row, when outlining is on + private boolean _zHeight; // row zero-height (this is somehow different than being hidden) + private int _outlineLevel; // Outlining level of the row, when outlining is on // use Boolean to have a tri-state for on/off/undefined private Boolean _hidden = UNDEFINED; private Boolean _collapsed = UNDEFINED; @@ -490,7 +490,7 @@ public class SXSSFRow implements Row, Co public class CellIterator implements Iterator<Cell> { final int maxColumn = getLastCellNum(); //last column PLUS ONE - int pos = 0; + int pos; @Override public boolean hasNext() Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java Sat Sep 16 08:22:59 2017 @@ -70,9 +70,9 @@ public class SXSSFSheet implements Sheet private final SheetDataWriter _writer; private int _randomAccessWindowSize = SXSSFWorkbook.DEFAULT_WINDOW_SIZE; private final AutoSizeColumnTracker _autoSizeColumnTracker; - private int outlineLevelRow = 0; + private int outlineLevelRow; private int lastFlushedRowNumber = -1; - private boolean allFlushed = false; + private boolean allFlushed; public SXSSFSheet(SXSSFWorkbook workbook, XSSFSheet xSheet) throws IOException { _workbook = workbook; Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java Sat Sep 16 08:22:59 2017 @@ -56,7 +56,7 @@ public abstract class BaseXSSFEvaluation // lazily populated. This should only be accessed through getTableCache // keys are lower-case to make this a quasi-case-insensitive map - private Map<String, XSSFTable> _tableCache = null; + private Map<String, XSSFTable> _tableCache; protected BaseXSSFEvaluationWorkbook(XSSFWorkbook book) { Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFConnector.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFConnector.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFConnector.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFConnector.java Sat Sep 16 08:22:59 2017 @@ -42,7 +42,7 @@ import org.apache.poi.util.Internal; */ public final class XSSFConnector extends XSSFShape { - private static CTConnector prototype = null; + private static CTConnector prototype; private CTConnector ctShape; Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java Sat Sep 16 08:22:59 2017 @@ -83,7 +83,7 @@ public final class XSSFDrawing extends P * Root element of the SpreadsheetML Drawing part */ private CTDrawing drawing; - private long numOfGraphicFrames = 0L; + private long numOfGraphicFrames; protected static final String NAMESPACE_A = XSSFRelation.NS_DRAWINGML; protected static final String NAMESPACE_C = XSSFRelation.NS_CHART; Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java Sat Sep 16 08:22:59 2017 @@ -43,7 +43,7 @@ import org.w3c.dom.NodeList; */ public final class XSSFGraphicFrame extends XSSFShape { - private static CTGraphicalObjectFrame prototype = null; + private static CTGraphicalObjectFrame prototype; private CTGraphicalObjectFrame graphicFrame; Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFObjectData.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFObjectData.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFObjectData.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFObjectData.java Sat Sep 16 08:22:59 2017 @@ -57,7 +57,7 @@ public class XSSFObjectData extends XSSF /** * A default instance of CTShape used for creating new shapes. */ - private static CTShape prototype = null; + private static CTShape prototype; private CTOleObject oleObject; Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java Sat Sep 16 08:22:59 2017 @@ -60,7 +60,7 @@ public final class XSSFPicture extends X /** * A default instance of CTShape used for creating new shapes. */ - private static CTPicture prototype = null; + private static CTPicture prototype; /** * This object specifies a picture object and all its properties Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFShapeGroup.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFShapeGroup.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFShapeGroup.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFShapeGroup.java Sat Sep 16 08:22:59 2017 @@ -42,7 +42,7 @@ import org.openxmlformats.schemas.drawin * specified just as they normally would. */ public final class XSSFShapeGroup extends XSSFShape implements ShapeContainer<XSSFShape> { - private static CTGroupShape prototype = null; + private static CTGroupShape prototype; private CTGroupShape ctGroup; Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSimpleShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSimpleShape.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSimpleShape.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSimpleShape.java Sat Sep 16 08:22:59 2017 @@ -46,7 +46,7 @@ public class XSSFSimpleShape extends XSS /** * A default instance of CTShape used for creating new shapes. */ - private static CTShape prototype = null; + private static CTShape prototype; /** * Xml bean that stores properties of this shape Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/extensions/XSSFHeaderFooter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/extensions/XSSFHeaderFooter.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/extensions/XSSFHeaderFooter.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/extensions/XSSFHeaderFooter.java Sat Sep 16 08:22:59 2017 @@ -124,7 +124,7 @@ public abstract class XSSFHeaderFooter i private HeaderFooterHelper helper; private CTHeaderFooter headerFooter; - private boolean stripFields = false; + private boolean stripFields; /** * Create an instance of XSSFHeaderFooter from the supplied XML bean Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/extractor/XWPFWordExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xwpf/extractor/XWPFWordExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xwpf/extractor/XWPFWordExtractor.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xwpf/extractor/XWPFWordExtractor.java Sat Sep 16 08:22:59 2017 @@ -53,7 +53,7 @@ public class XWPFWordExtractor extends P }; private XWPFDocument document; - private boolean fetchHyperlinks = false; + private boolean fetchHyperlinks; private boolean concatenatePhoneticRuns = true; public XWPFWordExtractor(OPCPackage container) throws XmlException, OpenXML4JException, IOException { Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/PositionInParagraph.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/PositionInParagraph.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/PositionInParagraph.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/PositionInParagraph.java Sat Sep 16 08:22:59 2017 @@ -25,7 +25,7 @@ package org.apache.poi.xwpf.usermodel; * 3rd CharacterPosition */ public class PositionInParagraph { - private int posRun = 0, posText = 0, posChar = 0; + private int posRun, posText, posChar; public PositionInParagraph() { } Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java Sat Sep 16 08:22:59 2017 @@ -64,12 +64,12 @@ public class XWPFTableCell implements IB } private final CTTc ctTc; - protected List<XWPFParagraph> paragraphs = null; - protected List<XWPFTable> tables = null; - protected List<IBodyElement> bodyElements = null; + protected List<XWPFParagraph> paragraphs; + protected List<XWPFTable> tables; + protected List<IBodyElement> bodyElements; protected IBody part; - private XWPFTableRow tableRow = null; + private XWPFTableRow tableRow; /** * If a table cell does not include at least one block-level element, then this document shall be considered corrupt Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java Sat Sep 16 08:22:59 2017 @@ -101,8 +101,8 @@ public class TestSignatureInfo { private static final POIDataSamples testdata = POIDataSamples.getXmlDSignInstance(); private static Calendar cal; - private KeyPair keyPair = null; - private X509Certificate x509 = null; + private KeyPair keyPair; + private X509Certificate x509; @AfterClass public static void removeUserLocale() { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/sl/draw/TestDrawPictureShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/sl/draw/TestDrawPictureShape.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/sl/draw/TestDrawPictureShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/sl/draw/TestDrawPictureShape.java Sat Sep 16 08:22:59 2017 @@ -42,7 +42,7 @@ import org.junit.Test; public class TestDrawPictureShape { final static POIDataSamples ssSamples = POIDataSamples.getSlideShowInstance(); - private static boolean xslfOnly = false; + private static boolean xslfOnly; @BeforeClass public static void checkHslf() { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java Sat Sep 16 08:22:59 2017 @@ -43,7 +43,7 @@ import org.junit.runners.Parameterized.P */ @RunWith(Parameterized.class) public class TestPPTX2PNG { - private static boolean xslfOnly = false; + private static boolean xslfOnly; private static final POIDataSamples samples = POIDataSamples.getSlideShowInstance(); private static final File basedir = null; private static final String files = Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java Sat Sep 16 08:22:59 2017 @@ -49,7 +49,7 @@ import org.openxmlformats.schemas.presen import org.openxmlformats.schemas.presentationml.x2006.main.STPlaceholderType; public class TestXSLFTextShape { - private static boolean xslfOnly = false; + private static boolean xslfOnly; @BeforeClass public static void checkHslf() { Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/HDGFLZWCompressor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/HDGFLZWCompressor.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/HDGFLZWCompressor.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/HDGFLZWCompressor.java Sat Sep 16 08:22:59 2017 @@ -44,21 +44,21 @@ import java.io.OutputStream; // And how long it is // (Un-compressed codes are 1 byte each, compressed codes // are two) - private int bufferLen = 0; + private int bufferLen; // The raw length of a code is limited to 4 bits + 2 private byte[] rawCode = new byte[18]; // And how much we're using - private int rawCodeLen = 0; + private int rawCodeLen; // How far through the input and output streams we are - private int posInp = 0; - private int posOut = 0; + private int posInp; + private int posOut; // What the next mask byte to output will be - private int nextMask = 0; + private int nextMask; // And how many bits we've already set - private int maskBitsSet = 0; + private int maskBitsSet; public HDGFLZWCompressor() {} Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/streams/CompressedStreamStore.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/streams/CompressedStreamStore.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/streams/CompressedStreamStore.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/streams/CompressedStreamStore.java Sat Sep 16 08:22:59 2017 @@ -34,7 +34,7 @@ public final class CompressedStreamStore * real contents in the de-compressed data */ private byte[] blockHeader = new byte[4]; - private boolean blockHeaderInContents = false; + private boolean blockHeaderInContents; protected byte[] _getCompressedContents() { return compressedContents; } protected byte[] _getBlockHeader() { return blockHeader; } Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hemf/extractor/HemfExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hemf/extractor/HemfExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hemf/extractor/HemfExtractor.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hemf/extractor/HemfExtractor.java Sat Sep 16 08:22:59 2017 @@ -59,7 +59,7 @@ public class HemfExtractor implements It private class HemfRecordIterator implements Iterator<HemfRecord> { - private HemfRecord currentRecord = null; + private HemfRecord currentRecord; HemfRecordIterator() { //queue the first non-header record Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java Sat Sep 16 08:22:59 2017 @@ -35,7 +35,7 @@ import org.apache.poi.poifs.filesystem.P */ public final class PublisherTextExtractor extends POIOLE2TextExtractor { private HPBFDocument doc; - private boolean hyperlinksByDefault = false; + private boolean hyperlinksByDefault; public PublisherTextExtractor(HPBFDocument doc) { super(doc); Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java Sat Sep 16 08:22:59 2017 @@ -66,7 +66,7 @@ public abstract class Metafile extends H /** * Reserved. Always 0. */ - private int compression = 0; + private int compression; /** * Reserved. Always 254. Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/extractor/PowerPointExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/extractor/PowerPointExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/extractor/PowerPointExtractor.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/extractor/PowerPointExtractor.java Sat Sep 16 08:22:59 2017 @@ -58,9 +58,9 @@ public final class PowerPointExtractor e private final List<HSLFSlide> _slides; private boolean _slidesByDefault = true; - private boolean _notesByDefault = false; - private boolean _commentsByDefault = false; - private boolean _masterByDefault = false; + private boolean _notesByDefault; + private boolean _commentsByDefault; + private boolean _masterByDefault; /** * Basic extractor. Returns all the text, and optionally all the notes Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/textproperties/TextPropCollection.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/textproperties/TextPropCollection.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/textproperties/TextPropCollection.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/textproperties/TextPropCollection.java Sat Sep 16 08:22:59 2017 @@ -93,9 +93,9 @@ public class TextPropCollection { // indentLevel is only valid for paragraph collection // if it's set to -1, it must be omitted - see 2.9.36 TextMasterStyleLevel - private short indentLevel = 0; + private short indentLevel; private final Map<String,TextProp> textProps = new HashMap<String,TextProp>(); - private int maskSpecial = 0; + private int maskSpecial; private final TextPropType textPropType; /** Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/EscherPlaceholder.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/EscherPlaceholder.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/EscherPlaceholder.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/EscherPlaceholder.java Sat Sep 16 08:22:59 2017 @@ -32,9 +32,9 @@ public class EscherPlaceholder extends E public static final String RECORD_DESCRIPTION = "msofbtClientTextboxPlaceholder"; private int position = -1; - private byte placementId = 0; - private byte size = 0; - private short unused = 0; + private byte placementId; + private byte size; + private short unused; public EscherPlaceholder() {} Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/OEPlaceholderAtom.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/OEPlaceholderAtom.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/OEPlaceholderAtom.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/OEPlaceholderAtom.java Sat Sep 16 08:22:59 2017 @@ -53,7 +53,7 @@ public final class OEPlaceholderAtom ext private int placementId; private int placeholderId; private int placeholderSize; - private short unusedShort = 0; + private short unusedShort; /** Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/SSSlideInfoAtom.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/SSSlideInfoAtom.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/SSSlideInfoAtom.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/SSSlideInfoAtom.java Sat Sep 16 08:22:59 2017 @@ -118,18 +118,18 @@ public class SSSlideInfoAtom extends Rec * before advancing to the next presentation slide. It MUST be greater than or equal to 0 and * less than or equal to 86399000. It MUST be ignored unless AUTO_ADVANCE_BIT is TRUE. */ - private int _slideTime = 0; + private int _slideTime; /** * A SoundIdRef that specifies which sound to play when the transition starts. */ - private int _soundIdRef = 0; + private int _soundIdRef; /** * A byte that specifies the variant of effectType. In combination of the effectType * there are further restriction and specification of this field. */ - private short _effectDirection = 0; // byte + private short _effectDirection; // byte /** * A byte that specifies which transition is used when transitioning to the @@ -137,18 +137,18 @@ public class SSSlideInfoAtom extends Rec * determined by the rendering application. As such, the same transition can have * many variations depending on the implementation. */ - private short _effectType = 0; // byte + private short _effectType; // byte /** * Various flags - see bitmask for more details */ - private short _effectTransitionFlags = 0; + private short _effectTransitionFlags; /** * A byte value that specifies how long the transition takes to run. * (0x00 = 0.75 seconds, 0x01 = 0.5 seconds, 0x02 = 0.25 seconds) */ - private short _speed = 0; // byte + private short _speed; // byte private byte[] _unused; // 3-byte public SSSlideInfoAtom() { Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java Sat Sep 16 08:22:59 2017 @@ -55,7 +55,7 @@ public final class StyleTextPropAtom ext * Only set to true once setParentTextSize(int) is called. * Until then, no stylings will have been decoded */ - private boolean initialised = false; + private boolean initialised; /** * The list of all the different paragraph stylings we code for. Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/TextSpecInfoRun.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/TextSpecInfoRun.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/TextSpecInfoRun.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/TextSpecInfoRun.java Sat Sep 16 08:22:59 2017 @@ -120,7 +120,7 @@ public class TextSpecInfoRun { private short bidi = -1; private int pp10extMask = -1; - private byte[] smartTagsBytes = null; + private byte[] smartTagsBytes; /** * Inits a TextSpecInfoRun with default values Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFFontInfo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFFontInfo.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFFontInfo.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFFontInfo.java Sat Sep 16 08:22:59 2017 @@ -35,7 +35,7 @@ import org.apache.poi.util.BitFieldFacto public class HSLFFontInfo implements FontInfo { public enum FontRenderType { - raster, device, truetype; + raster, device, truetype } /** A bit that specifies whether a subset of this font is embedded. */ @@ -51,7 +51,7 @@ public class HSLFFontInfo implements Fon private FontRenderType renderType = FontRenderType.truetype; private FontFamily family = FontFamily.FF_SWISS; private FontPitch pitch = FontPitch.VARIABLE; - private boolean isSubsetted = false; + private boolean isSubsetted; private boolean isSubstitutable = true; /** Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowEncrypted.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowEncrypted.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowEncrypted.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowEncrypted.java Sat Sep 16 08:22:59 2017 @@ -56,7 +56,7 @@ public class HSLFSlideShowEncrypted impl DocumentEncryptionAtom dea; EncryptionInfo _encryptionInfo; // Cipher cipher = null; - ChunkedCipherOutputStream cyos = null; + ChunkedCipherOutputStream cyos; private static final BitField fieldRecInst = new BitField(0xFFF0); Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java Sat Sep 16 08:22:59 2017 @@ -861,7 +861,7 @@ public final class HSLFSlideShowImpl ext } private static class CountingOS extends OutputStream { - int count = 0; + int count; @Override public void write(int b) throws IOException { Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java Sat Sep 16 08:22:59 2017 @@ -103,7 +103,7 @@ public final class HSLFTextParagraph imp private StyleTextProp9Atom styleTextProp9Atom; - private boolean _dirty = false; + private boolean _dirty; private final List<HSLFTextParagraph> parentList; Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hsmf/MAPIMessage.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hsmf/MAPIMessage.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hsmf/MAPIMessage.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hsmf/MAPIMessage.java Sat Sep 16 08:22:59 2017 @@ -85,7 +85,7 @@ public class MAPIMessage extends POIRead private RecipientChunks[] recipientChunks; private AttachmentChunks[] attachmentChunks; - private boolean returnNullOnMissingChunk = false; + private boolean returnNullOnMissingChunk; /** * Constructor for creating new files. Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/AbstractExcelConverter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/AbstractExcelConverter.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/AbstractExcelConverter.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/AbstractExcelConverter.java Sat Sep 16 08:22:59 2017 @@ -57,9 +57,9 @@ public abstract class AbstractExcelConve private boolean outputColumnHeaders = true; - private boolean outputHiddenColumns = false; + private boolean outputHiddenColumns; - private boolean outputHiddenRows = false; + private boolean outputHiddenRows; private boolean outputLeadingSpacesAsNonBreaking = true; Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/ExcelToHtmlConverter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/ExcelToHtmlConverter.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/ExcelToHtmlConverter.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/ExcelToHtmlConverter.java Sat Sep 16 08:22:59 2017 @@ -158,9 +158,9 @@ public class ExcelToHtmlConverter extend return doc; } - private String cssClassContainerCell = null; + private String cssClassContainerCell; - private String cssClassContainerDiv = null; + private String cssClassContainerDiv; private String cssClassPrefixCell = "c"; @@ -174,7 +174,7 @@ public class ExcelToHtmlConverter extend private final HtmlDocumentFacade htmlDocumentFacade; - private boolean useDivsToSpan = false; + private boolean useDivsToSpan; public ExcelToHtmlConverter( Document doc ) { Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfDrawProperties.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfDrawProperties.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfDrawProperties.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfDrawProperties.java Sat Sep 16 08:22:59 2017 @@ -41,24 +41,24 @@ import org.apache.poi.hwmf.record.HwmfTe public class HwmfDrawProperties { private final Rectangle2D window; - private Rectangle2D viewport = null; + private Rectangle2D viewport; private final Point2D location; private HwmfMapMode mapMode = HwmfMapMode.MM_ANISOTROPIC; private HwmfColorRef backgroundColor = new HwmfColorRef(Color.BLACK); private HwmfBrushStyle brushStyle = HwmfBrushStyle.BS_SOLID; private HwmfColorRef brushColor = new HwmfColorRef(Color.BLACK); private HwmfHatchStyle brushHatch = HwmfHatchStyle.HS_HORIZONTAL; - private BufferedImage brushBitmap = null; + private BufferedImage brushBitmap; private double penWidth = 1; private HwmfPenStyle penStyle = HwmfPenStyle.valueOf(0); private HwmfColorRef penColor = new HwmfColorRef(Color.BLACK); private double penMiterLimit = 10; private HwmfBkMode bkMode = HwmfBkMode.OPAQUE; private HwmfPolyfillMode polyfillMode = HwmfPolyfillMode.WINDING; - private Shape region = null; - private List<PaletteEntry> palette = null; - private int paletteOffset = 0; - private HwmfFont font = null; + private Shape region; + private List<PaletteEntry> palette; + private int paletteOffset; + private HwmfFont font; private HwmfColorRef textColor = new HwmfColorRef(Color.BLACK); private HwmfTextAlignment textAlignLatin = HwmfTextAlignment.LEFT; private HwmfTextVerticalAlignment textVAlignLatin = HwmfTextVerticalAlignment.TOP; Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfSLImageRenderer.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfSLImageRenderer.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfSLImageRenderer.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfSLImageRenderer.java Sat Sep 16 08:22:59 2017 @@ -39,8 +39,8 @@ import org.apache.poi.util.Units; * via reflection */ public class HwmfSLImageRenderer implements ImageRenderer { - HwmfPicture image = null; - double alpha = 0; + HwmfPicture image; + double alpha; @Override public void loadImage(InputStream data, String contentType) throws IOException { Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmapDib.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmapDib.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmapDib.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmapDib.java Sat Sep 16 08:22:59 2017 @@ -210,7 +210,7 @@ public class HwmfBitmapDib { private long headerColorImportant = -1; private Color colorTable[]; @SuppressWarnings("unused") - private int colorMaskR=0,colorMaskG=0,colorMaskB=0; + private int colorMaskR,colorMaskG,colorMaskB; // size of header and color table, for start of image data calculation private int introSize; Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToFoConverter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToFoConverter.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToFoConverter.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToFoConverter.java Sat Sep 16 08:22:59 2017 @@ -109,7 +109,7 @@ public class WordToFoConverter extends A private AtomicInteger internalLinkCounter = new AtomicInteger( 0 ); - private boolean outputCharactersLanguage = false; + private boolean outputCharactersLanguage; private Set<String> usedIds = new LinkedHashSet<String>(); Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToTextConverter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToTextConverter.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToTextConverter.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToTextConverter.java Sat Sep 16 08:22:59 2017 @@ -126,9 +126,9 @@ public class WordToTextConverter extends private AtomicInteger noteCounters = new AtomicInteger( 1 ); - private Element notes = null; + private Element notes; - private boolean outputSummaryInformation = false; + private boolean outputSummaryInformation; private final TextDocumentFacade textDocumentFacade; Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/FontTable.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/FontTable.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/FontTable.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/FontTable.java Sat Sep 16 08:22:59 2017 @@ -46,7 +46,7 @@ public final class FontTable private int fcSttbfffn;// table stream offset for sttbfffn // FFN structure containing strings of font names - private Ffn[] _fontNames = null; + private Ffn[] _fontNames; public FontTable(byte[] buf, int offset, int lcbSttbfffn) Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/BookmarksImpl.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/BookmarksImpl.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/BookmarksImpl.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/BookmarksImpl.java Sat Sep 16 08:22:59 2017 @@ -122,9 +122,9 @@ public class BookmarksImpl implements Bo private final BookmarksTables bookmarksTables; - private Map<Integer, List<GenericPropertyNode>> sortedDescriptors = null; + private Map<Integer, List<GenericPropertyNode>> sortedDescriptors; - private int[] sortedStartPositions = null; + private int[] sortedStartPositions; public BookmarksImpl( BookmarksTables bookmarksTables ) { Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HWPFList.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HWPFList.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HWPFList.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HWPFList.java Sat Sep 16 08:22:59 2017 @@ -48,7 +48,7 @@ import org.apache.poi.hwpf.sprm.Paragrap */ public final class HWPFList { - private boolean _ignoreLogicalLeftIdentation = false; + private boolean _ignoreLogicalLeftIdentation; private LFO _lfo; private LFOData _lfoData; private ListData _listData; Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HeaderStories.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HeaderStories.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HeaderStories.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HeaderStories.java Sat Sep 16 08:22:59 2017 @@ -37,7 +37,7 @@ public final class HeaderStories { private Range headerStories; private PlexOfCps plcfHdd; - private boolean stripFields = false; + private boolean stripFields; public HeaderStories(HWPFDocument doc) { this.headerStories = doc.getHeaderStoryRange(); Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/NotesImpl.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/NotesImpl.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/NotesImpl.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/NotesImpl.java Sat Sep 16 08:22:59 2017 @@ -28,7 +28,7 @@ import org.apache.poi.hwpf.model.NotesTa */ public class NotesImpl implements Notes { - private Map<Integer, Integer> anchorToIndexMap = null; + private Map<Integer, Integer> anchorToIndexMap; private final NotesTables notesTables; Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/ParagraphProperties.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/ParagraphProperties.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/ParagraphProperties.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/ParagraphProperties.java Sat Sep 16 08:22:59 2017 @@ -23,7 +23,7 @@ public final class ParagraphProperties e Cloneable { - private boolean jcLogical = false; + private boolean jcLogical; public ParagraphProperties() { Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/PictureRunMapper.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/PictureRunMapper.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/PictureRunMapper.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/PictureRunMapper.java Sat Sep 16 08:22:59 2017 @@ -45,7 +45,7 @@ public class PictureRunMapper { private Map<Integer, Picture> lookup; private List<Picture> nonU1based; private List<Picture> all; - private int pn = 0; + private int pn; public PictureRunMapper(HWPFDocument doc) { picturesTable = doc.getPicturesTable(); Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Table.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Table.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Table.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Table.java Sat Sep 16 08:22:59 2017 @@ -23,7 +23,7 @@ public final class Table extends Range { private ArrayList<TableRow> _rows; - private boolean _rowsFound = false; + private boolean _rowsFound; private int _tableLevel; Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/TableRow.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/TableRow.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/TableRow.java (original) +++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/TableRow.java Sat Sep 16 08:22:59 2017 @@ -39,7 +39,7 @@ public final class TableRow extends Rang private final static char TABLE_CELL_MARK = '\u0007'; private TableCell[] _cells; - private boolean _cellsFound = false; + private boolean _cellsFound; int _levelNum; private SprmBuffer _papx; Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hdgf/streams/StreamTest.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hdgf/streams/StreamTest.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hdgf/streams/StreamTest.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hdgf/streams/StreamTest.java Sat Sep 16 08:22:59 2017 @@ -26,7 +26,7 @@ import org.apache.poi.hdgf.pointers.Poin public abstract class StreamTest { public static class TestPointer extends Pointer { private final boolean compressed; - protected boolean hasPointers = false; + protected boolean hasPointers; public TestPointer(boolean compressed, int offset, int length, int type, short format) { this.compressed = compressed; setOffset(offset); Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hwmf/TestHwmfParsing.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hwmf/TestHwmfParsing.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hwmf/TestHwmfParsing.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hwmf/TestHwmfParsing.java Sat Sep 16 08:22:59 2017 @@ -158,7 +158,7 @@ public class TestHwmfParsing { outdir.mkdirs(); final String startFile = ""; File files[] = indir.listFiles(new FileFilter() { - boolean foundStartFile = false; + boolean foundStartFile; @Override public boolean accept(File pathname) { foundStartFile |= startFile.isEmpty() || pathname.getName().contains(startFile); Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestCHPBinTable.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestCHPBinTable.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestCHPBinTable.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestCHPBinTable.java Sat Sep 16 08:22:59 2017 @@ -28,7 +28,7 @@ import org.apache.poi.hwpf.model.io.HWPF public final class TestCHPBinTable extends TestCase { - private CHPBinTable _cHPBinTable = null; + private CHPBinTable _cHPBinTable; private HWPFDocFixture _hWPFDocFixture; private final TextPieceTable fakeTPT = new TextPieceTable() { Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestDocumentProperties.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestDocumentProperties.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestDocumentProperties.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestDocumentProperties.java Sat Sep 16 08:22:59 2017 @@ -28,7 +28,7 @@ import org.junit.Test; // TODO: Add DocumentProperties#equals ??? public final class TestDocumentProperties { - private DocumentProperties _documentProperties = null; + private DocumentProperties _documentProperties; private HWPFDocFixture _hWPFDocFixture; @Test Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFileInformationBlock.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFileInformationBlock.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFileInformationBlock.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFileInformationBlock.java Sat Sep 16 08:22:59 2017 @@ -26,7 +26,7 @@ import org.junit.Before; import org.junit.Test; public final class TestFileInformationBlock { - private FileInformationBlock _fileInformationBlock = null; + private FileInformationBlock _fileInformationBlock; private HWPFDocFixture _hWPFDocFixture; @Test Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFontTable.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFontTable.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFontTable.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFontTable.java Sat Sep 16 08:22:59 2017 @@ -29,7 +29,7 @@ import org.junit.Before; import org.junit.Test; public final class TestFontTable { - private FontTable _fontTable = null; + private FontTable _fontTable; private HWPFDocFixture _hWPFDocFixture; @Test Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestPlexOfCps.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestPlexOfCps.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestPlexOfCps.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestPlexOfCps.java Sat Sep 16 08:22:59 2017 @@ -25,7 +25,7 @@ import org.apache.poi.util.LittleEndian; public final class TestPlexOfCps extends TestCase { - private PlexOfCps _plexOfCps = null; + private PlexOfCps _plexOfCps; private HWPFDocFixture _hWPFDocFixture; public void testWriteRead() { Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestStyleSheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestStyleSheet.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestStyleSheet.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestStyleSheet.java Sat Sep 16 08:22:59 2017 @@ -29,7 +29,7 @@ import org.junit.Before; import org.junit.Test; public final class TestStyleSheet { - private StyleSheet _styleSheet = null; + private StyleSheet _styleSheet; private HWPFDocFixture _hWPFDocFixture; @Test Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/usermodel/TestBorderCode.java URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/usermodel/TestBorderCode.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/usermodel/TestBorderCode.java (original) +++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/usermodel/TestBorderCode.java Sat Sep 16 08:22:59 2017 @@ -27,7 +27,7 @@ import org.apache.poi.hwpf.HWPFTestDataS */ public final class TestBorderCode extends TestCase { - private int pos = 0; + private int pos; private Range range; public void test() { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java Sat Sep 16 08:22:59 2017 @@ -420,7 +420,7 @@ public final class TestCellStyle extends private static class CellFormatBugExample extends Thread { private final String fileName; - private Throwable exception = null; + private Throwable exception; public CellFormatBugExample(String fileName) { this.fileName = fileName; Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java Sat Sep 16 08:22:59 2017 @@ -51,7 +51,7 @@ import org.junit.Test; * */ public final class TestFormulaEvaluatorBugs { - private static boolean OUTPUT_TEST_FILES = false; + private static boolean OUTPUT_TEST_FILES; private static String tmpDirName; @BeforeClass Modified: poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java (original) +++ poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java Sat Sep 16 08:22:59 2017 @@ -193,7 +193,7 @@ public final class TestRawDataBlock exte private final Random rnd = new Random(); private final byte[] data; private final int chunkSize; - private int pos = 0; + private int pos; public SlowInputStream(byte[] data, int chunkSize) { this.chunkSize = chunkSize; Modified: poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java Sat Sep 16 08:22:59 2017 @@ -54,8 +54,8 @@ public class TestCellWalk extends TestCa private static class CountCellHandler implements CellHandler { - private int cellsVisited = 0; - private long ordinalNumberSum = 0L; + private int cellsVisited; + private long ordinalNumberSum; @Override public void onCell(Cell cell, CellWalkContext ctx) { Modified: poi/trunk/src/testcases/org/apache/poi/util/TestIOUtils.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/util/TestIOUtils.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/util/TestIOUtils.java (original) +++ poi/trunk/src/testcases/org/apache/poi/util/TestIOUtils.java Sat Sep 16 08:22:59 2017 @@ -42,7 +42,7 @@ import org.junit.Test; */ public final class TestIOUtils { - static File TMP = null; + static File TMP; static final long LENGTH = new Random().nextInt(10000); @BeforeClass @@ -176,8 +176,8 @@ public final class TestIOUtils { * as requested. This tests that the fallback to read() works. */ private static class WonkyInputStream extends InputStream { - int skipCalled = 0; - int readCalled = 0; + int skipCalled; + int readCalled; @Override public int read() throws IOException { Modified: poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java?rev=1808510&r1=1808509&r2=1808510&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java (original) +++ poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java Sat Sep 16 08:22:59 2017 @@ -29,7 +29,7 @@ import org.junit.Test; */ public final class TestPOILogger extends POILogger { private String lastLog = ""; - private Throwable lastEx = null; + private Throwable lastEx; /** * Test different types of log output. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
