Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotEquals; @@ -57,7 +58,7 @@ public final class TestExternalNameRecor assertEquals("FDS", enr.getText()); // bug 44695 - TestcaseRecordInputStream.confirmRecordEncoding(0x0023, dataFDS, enr.serialize()); + confirmRecordEncoding(0x0023, dataFDS, enr.serialize()); } @Test @@ -81,7 +82,7 @@ public final class TestExternalNameRecor assertFalse(enr.isPicureLink()); assertTrue(enr.isStdDocumentNameIdentifier()); - TestcaseRecordInputStream.confirmRecordEncoding(0x0023, dataAutoDocName, enr.serialize()); + confirmRecordEncoding(0x0023, dataAutoDocName, enr.serialize()); } @Test @@ -96,7 +97,7 @@ public final class TestExternalNameRecor assertFalse(enr.isPicureLink()); assertFalse(enr.isStdDocumentNameIdentifier()); - TestcaseRecordInputStream.confirmRecordEncoding(0x0023, dataPlainName, enr.serialize()); + confirmRecordEncoding(0x0023, dataPlainName, enr.serialize()); } @Test @@ -121,7 +122,7 @@ public final class TestExternalNameRecor ExternalNameRecord enr = createSimpleENR(dataDDE); assertEquals("010672AT0 MUNI,[RTG_MOODY_UNDERLYING,RTG_SP_UNDERLYING]", enr.getText()); - TestcaseRecordInputStream.confirmRecordEncoding(0x0023, dataDDE, enr.serialize()); + confirmRecordEncoding(0x0023, dataDDE, enr.serialize()); } @Test
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java Fri Jan 3 23:30:36 2020 @@ -18,6 +18,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotEquals; @@ -67,6 +68,7 @@ public final class TestFontRecord { assertEquals(21 + 4, record.getRecordSize()); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { // .fontheight = c8 @@ -96,7 +98,7 @@ public final class TestFontRecord { record.setFontName("Arial"); byte [] recordBytes = record.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(0x31, data, recordBytes); + confirmRecordEncoding(0x31, data, recordBytes); } @Test @@ -150,6 +152,6 @@ public final class TestFontRecord { assertEquals(0, fr.getFontName().length()); byte[] recordBytes = fr.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(SID, emptyNameData, recordBytes); + confirmRecordEncoding(SID, emptyNameData, recordBytes); } } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java Fri Jan 3 23:30:36 2020 @@ -16,6 +16,7 @@ ==================================================================== */ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotEquals; @@ -453,12 +454,13 @@ public final class TestHyperlinkRecord { } + @SuppressWarnings("squid:S2699") @Test public void testReserializeTargetFrame() { RecordInputStream in = TestcaseRecordInputStream.create(HyperlinkRecord.sid, dataTargetFrame); HyperlinkRecord hr = new HyperlinkRecord(in); byte[] ser = hr.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(HyperlinkRecord.sid, dataTargetFrame, ser); + confirmRecordEncoding(HyperlinkRecord.sid, dataTargetFrame, ser); } @Test @@ -467,7 +469,7 @@ public final class TestHyperlinkRecord { RecordInputStream in = TestcaseRecordInputStream.create(HyperlinkRecord.sid, dataLinkToWorkbook); HyperlinkRecord hr = new HyperlinkRecord(in); byte[] ser = hr.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(HyperlinkRecord.sid, dataLinkToWorkbook, ser); + confirmRecordEncoding(HyperlinkRecord.sid, dataLinkToWorkbook, ser); assertNotEquals("Identified bug in reading workbook link", "YEARFR~1.XLS", hr.getAddress()); assertEquals("yearfracExamples.xls", hr.getAddress()); } @@ -478,7 +480,7 @@ public final class TestHyperlinkRecord { RecordInputStream in = TestcaseRecordInputStream.create(HyperlinkRecord.sid, dataUNC); HyperlinkRecord hr = new HyperlinkRecord(in); byte[] ser = hr.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(HyperlinkRecord.sid, dataUNC, ser); + confirmRecordEncoding(HyperlinkRecord.sid, dataUNC, ser); assertNotNull(hr.toString()); } @@ -541,6 +543,6 @@ public final class TestHyperlinkRecord { assertEquals("testfolder/test.PDF", link.getAddress()); byte[] ser = link.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(HyperlinkRecord.sid, data_47498, ser); + confirmRecordEncoding(HyperlinkRecord.sid, data_47498, ser); } } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java Fri Jan 3 23:30:36 2020 @@ -18,6 +18,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNull; @@ -71,7 +72,7 @@ public final class TestLbsDataSubRecord // check that it re-serializes to the same data byte[] ser = record.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(ObjRecord.sid, data, ser); + confirmRecordEncoding(ObjRecord.sid, data, ser); } /** @@ -109,7 +110,7 @@ public final class TestLbsDataSubRecord // check that it re-serializes to the same data byte[] ser = record.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(ObjRecord.sid, data, ser); + confirmRecordEncoding(ObjRecord.sid, data, ser); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertEquals; import org.apache.poi.util.HexRead; @@ -37,6 +38,6 @@ public final class TestNameCommentRecord assertEquals("name", ncr.getNameText()); assertEquals("comment", ncr.getCommentText()); final byte[] data2 = ncr.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(NameCommentRecord.sid, data, data2); + confirmRecordEncoding(NameCommentRecord.sid, data, data2); } } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotEquals; @@ -68,7 +69,7 @@ public final class TestNameRecord { NameRecord nr = new NameRecord(in); assertEquals(0x0020, nr.getOptionFlag()); byte[] data2 = nr.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(NameRecord.sid, data, data2); + confirmRecordEncoding(NameRecord.sid, data, data2); } @Test Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; @@ -64,7 +65,7 @@ public final class TestNoteRecord { record.setAuthor("Apache Software Foundation"); byte[] ser = record.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(NoteRecord.sid, testData, ser); + confirmRecordEncoding(NoteRecord.sid, testData, ser); } @Test @@ -107,7 +108,7 @@ public final class TestNoteRecord { assertTrue(nr.authorIsMultibyte()); byte[] ser = nr.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(NoteRecord.sid, data, ser); + confirmRecordEncoding(NoteRecord.sid, data, ser); // Re-check in = TestcaseRecordInputStream.create(ser); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; @@ -107,11 +108,11 @@ public final class TestObjRecord { assertTrue( subrecords.get(0) instanceof CommonObjectDataSubRecord); assertTrue( subrecords.get(1) instanceof EndSubRecord ); } - + @Test public void testReadWriteWithPadding_bug45133() { ObjRecord record = new ObjRecord(TestcaseRecordInputStream.create(recdataNeedingPadding)); - + if (record.getRecordSize() == 34) { fail("Identified bug 45133"); } @@ -124,11 +125,12 @@ public final class TestObjRecord { assertEquals(GroupMarkerSubRecord.class, subrecords.get(1).getClass()); assertEquals(EndSubRecord.class, subrecords.get(2).getClass()); } - + /** * Check that ObjRecord tolerates and preserves padding to a 4-byte boundary * (normally padding is to a 2-byte boundary). */ + @SuppressWarnings("squid:S2699") @Test public void test4BytePadding() { // actual data from file saved by Excel 2007 @@ -142,6 +144,6 @@ public final class TestObjRecord { ObjRecord record = new ObjRecord(in); // check that it re-serializes to the same data byte[] ser = record.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(ObjRecord.sid, data, ser); + confirmRecordEncoding(ObjRecord.sid, data, ser); } } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java Fri Jan 3 23:30:36 2020 @@ -50,6 +50,7 @@ public final class TestPaneRecord { assertEquals( 14, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { PaneRecord record = new PaneRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; @@ -32,6 +33,7 @@ public final class TestRecalcIdRecord { return result; } + @SuppressWarnings("squid:S2699") @Test public void testBasicDeserializeReserialize() { @@ -41,7 +43,7 @@ public final class TestRecalcIdRecord { "1D EB 01 00"); // engine id RecalcIdRecord r = create(data); - TestcaseRecordInputStream.confirmRecordEncoding(RecalcIdRecord.sid, data, r.serialize()); + confirmRecordEncoding(RecalcIdRecord.sid, data, r.serialize()); } @Test Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java Fri Jan 3 23:30:36 2020 @@ -42,6 +42,7 @@ public final class TestSCLRecord { assertEquals( 8, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SCLRecord record = new SCLRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertEquals; import org.apache.poi.util.HexRead; @@ -35,6 +36,6 @@ public final class TestStyleRecord { assertEquals("\u5E38\u89C4_Sheet1", sr.getName()); // "<Conventional>_Sheet1" // bug 46385 - Incorrect number of bytes written - expected 27 but got 18 byte[] ser = sr.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(StyleRecord.sid, data, ser); + confirmRecordEncoding(StyleRecord.sid, data, ser); } } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java Fri Jan 3 23:30:36 2020 @@ -19,6 +19,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertArrayEquals; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotEquals; @@ -141,6 +142,6 @@ public final class TestSubRecord { ObjRecord or = new ObjRecord(in); // make sure POI properly truncates the ObjRecord data byte[] data2 = or.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(ObjRecord.sid, data, data2); + confirmRecordEncoding(ObjRecord.sid, data, data2); } } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java Fri Jan 3 23:30:36 2020 @@ -26,6 +26,7 @@ import static org.apache.poi.hssf.record import static org.apache.poi.hssf.record.SupBookRecord.CH_UP_DIR; import static org.apache.poi.hssf.record.SupBookRecord.CH_VOLUME; import static org.apache.poi.hssf.record.SupBookRecord.PATH_SEPERATOR; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; @@ -99,20 +100,22 @@ public final class TestSupBookRecord { /** * Tests that we can store the record */ + @SuppressWarnings("squid:S2699") @Test public void testStoreIR() { SupBookRecord record = SupBookRecord.createInternalReferences((short)4); - TestcaseRecordInputStream.confirmRecordEncoding(0x01AE, dataIR, record.serialize()); + confirmRecordEncoding(0x01AE, dataIR, record.serialize()); } + @SuppressWarnings("squid:S2699") @Test public void testStoreER() { String url = "testURL"; String[] sheetNames = { "Sheet1", "Sheet2", }; SupBookRecord record = SupBookRecord.createExternalReferences(url, sheetNames); - TestcaseRecordInputStream.confirmRecordEncoding(0x01AE, dataER, record.serialize()); + confirmRecordEncoding(0x01AE, dataER, record.serialize()); } @Test @@ -120,7 +123,7 @@ public final class TestSupBookRecord { SupBookRecord record = SupBookRecord.createAddInFunctions(); assertEquals(1, record.getNumberOfSheets()); assertTrue(record.isAddInFunctions()); - TestcaseRecordInputStream.confirmRecordEncoding(0x01AE, dataAIF, record.serialize()); + confirmRecordEncoding(0x01AE, dataAIF, record.serialize()); } @Test Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java Fri Jan 3 23:30:36 2020 @@ -63,6 +63,7 @@ public final class TestTableRecord { assertEquals( 16 + 4, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertEquals; import org.apache.poi.util.HexRead; @@ -61,7 +62,7 @@ public final class TestWriteAccessRecord + "20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 " + HEX_SIXTYFOUR_SPACES); - TestcaseRecordInputStream.confirmRecordEncoding(WriteAccessRecord.sid, expectedEncoding, rec.serialize()); + confirmRecordEncoding(WriteAccessRecord.sid, expectedEncoding, rec.serialize()); } @Test @@ -90,6 +91,6 @@ public final class TestWriteAccessRecord + "20 20 20 20 20 20 20 20 20 20 20 " + HEX_SIXTYFOUR_SPACES); - TestcaseRecordInputStream.confirmRecordEncoding(WriteAccessRecord.sid, expectedEncoding, rec.serialize()); + confirmRecordEncoding(WriteAccessRecord.sid, expectedEncoding, rec.serialize()); } } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java Fri Jan 3 23:30:36 2020 @@ -58,6 +58,7 @@ public final class TestAreaFormatRecord assertEquals( 20, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { AreaFormatRecord record = new AreaFormatRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java Fri Jan 3 23:30:36 2020 @@ -48,6 +48,7 @@ public final class TestAreaRecord { assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { AreaRecord record = new AreaRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java Fri Jan 3 23:30:36 2020 @@ -42,6 +42,7 @@ public final class TestAxisLineFormatRec assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { AxisLineFormatRecord record = new AxisLineFormatRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java Fri Jan 3 23:30:36 2020 @@ -63,6 +63,7 @@ public final class TestAxisOptionsRecord assertEquals( 22, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { AxisOptionsRecord record = new AxisOptionsRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java Fri Jan 3 23:30:36 2020 @@ -50,6 +50,7 @@ public final class TestAxisParentRecord assertEquals( 22, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { AxisParentRecord record = new AxisParentRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java Fri Jan 3 23:30:36 2020 @@ -50,6 +50,7 @@ public final class TestAxisRecord { assertEquals( 4 + 18, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { AxisRecord record = new AxisRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java Fri Jan 3 23:30:36 2020 @@ -42,6 +42,7 @@ public final class TestAxisUsedRecord { assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { AxisUsedRecord record = new AxisUsedRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java Fri Jan 3 23:30:36 2020 @@ -51,6 +51,7 @@ public final class TestBarRecord { assertEquals( 10, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { BarRecord record = new BarRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java Fri Jan 3 23:30:36 2020 @@ -53,6 +53,7 @@ public final class TestCategorySeriesAxi assertEquals( 4 + 8, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { CategorySeriesAxisRecord record = new CategorySeriesAxisRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java Fri Jan 3 23:30:36 2020 @@ -48,6 +48,7 @@ public final class TestChartRecord { assertEquals( 20, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { ChartRecord record = new ChartRecord(); @@ -56,7 +57,6 @@ public final class TestChartRecord { record.setWidth( 30474216 ); record.setHeight( 15060168 ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(ChartRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java Fri Jan 3 23:30:36 2020 @@ -48,6 +48,7 @@ public final class TestDatRecord { assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { DatRecord record = new DatRecord(); @@ -56,7 +57,6 @@ public final class TestDatRecord { record.setBorder( true ); record.setShowSeriesKey( true ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(DatRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java Fri Jan 3 23:30:36 2020 @@ -50,6 +50,7 @@ public final class TestDataFormatRecord assertEquals( 12, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { DataFormatRecord record = new DataFormatRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java Fri Jan 3 23:30:36 2020 @@ -43,6 +43,7 @@ public final class TestDefaultDataLabelT assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { DefaultDataLabelTextPropertiesRecord record = new DefaultDataLabelTextPropertiesRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java Fri Jan 3 23:30:36 2020 @@ -50,6 +50,7 @@ public final class TestFontBasisRecord { assertEquals( 14, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { FontBasisRecord record = new FontBasisRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java Fri Jan 3 23:30:36 2020 @@ -43,6 +43,7 @@ public final class TestFontIndexRecord { assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { FontIndexRecord record = new FontIndexRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java Fri Jan 3 23:30:36 2020 @@ -48,6 +48,7 @@ public final class TestFrameRecord { assertEquals( 8, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { FrameRecord record = new FrameRecord(); @@ -56,7 +57,6 @@ public final class TestFrameRecord { record.setAutoSize( false ); record.setAutoPosition( true ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(FrameRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java Fri Jan 3 23:30:36 2020 @@ -62,22 +62,17 @@ public final class TestLegendRecord { assertEquals(24, record.getRecordSize()); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { LegendRecord record = new LegendRecord(); record.setXAxisUpperLeft(0xe76); - record.setYAxisUpperLeft(0x786); - record.setXSize(0x119); - record.setYSize(0x8b); - record.setType((byte) 0x3); - record.setSpacing((byte) 0x1); - record.setOptions((short) 0x1f); record.setAutoPosition(true); record.setAutoSeries(true); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java Fri Jan 3 23:30:36 2020 @@ -54,6 +54,7 @@ public final class TestLineFormatRecord assertEquals( 16, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { LineFormatRecord record = new LineFormatRecord(); @@ -64,7 +65,6 @@ public final class TestLineFormatRecord record.setDrawTicks( false ); record.setColourPaletteIndex( (short)0x4d ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(LineFormatRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java Fri Jan 3 23:30:36 2020 @@ -175,6 +175,7 @@ recordid = 0x1051, size =8 assertEquals( data.length + 4, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { LinkedDataRecord record = new LinkedDataRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java Fri Jan 3 23:30:36 2020 @@ -42,6 +42,7 @@ public final class TestNumberFormatIndex assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { NumberFormatIndexRecord record = new NumberFormatIndexRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java Fri Jan 3 23:30:36 2020 @@ -45,6 +45,7 @@ public final class TestObjectLinkRecord assertEquals( 10, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { ObjectLinkRecord record = new ObjectLinkRecord(); @@ -53,7 +54,6 @@ public final class TestObjectLinkRecord record.setLink1( (short)0x00 ); record.setLink2( (short)0x00 ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(ObjectLinkRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java Fri Jan 3 23:30:36 2020 @@ -45,13 +45,13 @@ public final class TestPlotGrowthRecord assertEquals( 12, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { PlotGrowthRecord record = new PlotGrowthRecord(); record.setHorizontalScale( 65536 ); record.setVerticalScale( 65536 ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(PlotGrowthRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java Fri Jan 3 23:30:36 2020 @@ -42,12 +42,12 @@ public final class TestSeriesChartGroupI assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SeriesChartGroupIndexRecord record = new SeriesChartGroupIndexRecord(); record.setChartGroupIndex( (short)0 ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(SeriesChartGroupIndexRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java Fri Jan 3 23:30:36 2020 @@ -42,12 +42,12 @@ public final class TestSeriesIndexRecord assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SeriesIndexRecord record = new SeriesIndexRecord(); record.setIndex( (short)3 ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(SeriesIndexRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java Fri Jan 3 23:30:36 2020 @@ -50,6 +50,7 @@ public final class TestSeriesLabelsRecor assertEquals( 2+4, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SeriesLabelsRecord record = new SeriesLabelsRecord(); @@ -60,7 +61,6 @@ public final class TestSeriesLabelsRecor record.setShowLabel( false ); record.setShowBubbleSizes( false ); - byte [] recordBytes = record.serialize(); confirmRecordEncoding(SeriesLabelsRecord.sid, data, recordBytes); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java Fri Jan 3 23:30:36 2020 @@ -45,6 +45,7 @@ public final class TestSeriesListRecord assertEquals( 4 + 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SeriesListRecord record = new SeriesListRecord(new short[] { (short)0x2001, (short)0xf0ff } ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java Fri Jan 3 23:30:36 2020 @@ -53,6 +53,7 @@ public final class TestSeriesRecord { assertEquals( 16, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SeriesRecord record = new SeriesRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java Fri Jan 3 23:30:36 2020 @@ -17,6 +17,7 @@ package org.apache.poi.hssf.record.chart; +import static org.apache.poi.hssf.record.TestcaseRecordInputStream.confirmRecordEncoding; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; @@ -43,6 +44,7 @@ public final class TestSeriesTextRecord assertEquals(SIMPLE_DATA.length + 4, record.getRecordSize()); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SeriesTextRecord record = new SeriesTextRecord(); @@ -51,7 +53,7 @@ public final class TestSeriesTextRecord record.setText("Value Number"); byte[] recordBytes = record.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(SeriesTextRecord.sid, SIMPLE_DATA, recordBytes); + confirmRecordEncoding(SeriesTextRecord.sid, SIMPLE_DATA, recordBytes); } @Test @@ -88,6 +90,6 @@ public final class TestSeriesTextRecord assertTrue("Identified bug 45784b", str.getRecordSize() >= 0); byte[] ser = str.serialize(); - TestcaseRecordInputStream.confirmRecordEncoding(SeriesTextRecord.sid, data, ser); + confirmRecordEncoding(SeriesTextRecord.sid, data, ser); } } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesToChartGroupRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesToChartGroupRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesToChartGroupRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesToChartGroupRecord.java Fri Jan 3 23:30:36 2020 @@ -42,6 +42,7 @@ public final class TestSeriesToChartGrou assertEquals( 0x6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SeriesToChartGroupRecord record = new SeriesToChartGroupRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java Fri Jan 3 23:30:36 2020 @@ -56,6 +56,7 @@ public final class TestSheetPropertiesRe assertEquals( 8, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { SheetPropertiesRecord record = new SheetPropertiesRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java Fri Jan 3 23:30:36 2020 @@ -81,6 +81,7 @@ public final class TestTextRecord { assertEquals( 36, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { TextRecord record = new TextRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java Fri Jan 3 23:30:36 2020 @@ -63,6 +63,7 @@ public final class TestTickRecord { assertEquals( 34, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { TickRecord record = new TickRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java Fri Jan 3 23:30:36 2020 @@ -43,6 +43,7 @@ public final class TestUnitsRecord { assertEquals( 6, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { UnitsRecord record = new UnitsRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java Fri Jan 3 23:30:36 2020 @@ -64,6 +64,7 @@ public final class TestValueRangeRecord assertEquals( 42+4, record.getRecordSize() ); } + @SuppressWarnings("squid:S2699") @Test public void testStore() { ValueRangeRecord record = new ValueRangeRecord(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java?rev=1872302&r1=1872301&r2=1872302&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java Fri Jan 3 23:30:36 2020 @@ -44,6 +44,7 @@ public final class TestExtendedPivotTabl assertEquals(data.length, rec.getRecordSize()); } + @SuppressWarnings("squid:S2699") @Test public void testOlderFormat_bug46918() { // There are 10 SXVDEX records in the file (not uploaded) that originated bugzilla 46918 --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org For additional commands, e-mail: commits-h...@poi.apache.org
