svn commit: r1877181 - in /poi/trunk/src: ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFConditionalFormatting.java testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java

[fanningpj]

Author: fanningpj
Date: Wed Apr 29 23:37:13 2020
New Revision: 1877181

URL: http://svn.apache.org/viewvc?rev=1877181&view=rev
Log:
[github-176] Remove limit on number of rules in XSSFSheetConditionalFormatting.

Modified:
    
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFConditionalFormatting.java
    
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java

Modified: 
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFConditionalFormatting.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFConditionalFormatting.java?rev=1877181&r1=1877180&r2=1877181&view=diff
==============================================================================
--- 
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFConditionalFormatting.java
 (original)
+++ 
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFConditionalFormatting.java
 Wed Apr 29 23:37:13 2020
@@ -42,8 +42,6 @@ import org.junit.Test;
  */
 public class TestXSSFConditionalFormatting extends 
BaseTestConditionalFormatting {
 
-    protected boolean applyLimitOf3 = false;
-
     public TestXSSFConditionalFormatting(){
         super(XSSFITestDataProvider.instance);
     }
@@ -133,4 +131,9 @@ public class TestXSSFConditionalFormatti
         assertEquals(extendedColor, fontFormattingBack.getFontColor());
         assertEquals(extendedColor, 
ruleBack.getPatternFormatting().getFillBackgroundColorColor());
     }
+
+    @Override
+    protected boolean applyLimitOf3() {
+        return false;
+    }
 }

Modified: 
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java?rev=1877181&r1=1877180&r2=1877181&view=diff
==============================================================================
--- 
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java
 (original)
+++ 
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java
 Wed Apr 29 23:37:13 2020
@@ -46,7 +46,9 @@ public abstract class BaseTestConditiona
         _testDataProvider = testDataProvider;
     }
 
-    protected boolean applyLimitOf3 = true;
+    protected boolean applyLimitOf3() {
+        return true;
+    }
 
     protected abstract void assertColour(String hexExpected, Color actual);
 
@@ -99,7 +101,7 @@ public abstract class BaseTestConditiona
                 assertTrue(e.getMessage().startsWith("cfRules must not be 
empty"));
             }
 
-            if (applyLimitOf3) {
+            if (applyLimitOf3()) {
                 try {
                     sheetCF.addConditionalFormatting(
                             new 
CellRangeAddress[]{CellRangeAddress.valueOf("A1:A3")},



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org