Author: fanningpj
Date: Thu Dec 17 22:05:35 2020
New Revision: 1884575
URL: http://svn.apache.org/viewvc?rev=1884575&view=rev
Log:
[github-208] Fix a few instances of incorrect NotImplemented documentation.
Thanks to Marius Volkhart. This closes #208
Modified:
poi/trunk/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/HWPFOldDocument.java
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java?rev=1884575&r1=1884574&r2=1884575&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java
(original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java Thu
Dec 17 22:05:35 2020
@@ -123,7 +123,6 @@ public class EscherGraphics extends Grap
@Override
- @NotImplemented
public void clearRect(int x, int y, int width, int height)
{
Color color = foreground;
@@ -136,16 +135,14 @@ public class EscherGraphics extends Grap
@NotImplemented
public void clipRect(int x, int y, int width, int height)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"clipRect not supported");
+ logger.log(POILogger.WARN,"clipRect not supported");
}
@Override
@NotImplemented
public void copyArea(int x, int y, int width, int height, int dx, int dy)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"copyArea not supported");
+ logger.log(POILogger.WARN,"copyArea not supported");
}
@Override
@@ -165,8 +162,7 @@ public class EscherGraphics extends Grap
public void drawArc(int x, int y, int width, int height,
int startAngle, int arcAngle)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"drawArc not supported");
+ logger.log(POILogger.WARN,"drawArc not supported");
}
@Override
@@ -177,8 +173,7 @@ public class EscherGraphics extends Grap
Color bgcolor,
ImageObserver observer)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"drawImage not supported");
+ logger.log(POILogger.WARN,"drawImage not supported");
return true;
}
@@ -190,8 +185,7 @@ public class EscherGraphics extends Grap
int sx1, int sy1, int sx2, int sy2,
ImageObserver observer)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"drawImage not supported");
+ logger.log(POILogger.WARN,"drawImage not supported");
return true;
}
@@ -272,16 +266,14 @@ public class EscherGraphics extends Grap
public void drawPolyline(int[] xPoints, int[] yPoints,
int nPoints)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"drawPolyline not supported");
+ logger.log(POILogger.WARN,"drawPolyline not supported");
}
@Override
@NotImplemented
public void drawRect(int x, int y, int width, int height)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"drawRect not supported");
+ logger.log(POILogger.WARN,"drawRect not supported");
}
@Override
@@ -289,8 +281,7 @@ public class EscherGraphics extends Grap
public void drawRoundRect(int x, int y, int width, int height,
int arcWidth, int arcHeight)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"drawRoundRect not supported");
+ logger.log(POILogger.WARN,"drawRoundRect not supported");
}
@Override
@@ -497,7 +488,7 @@ public class EscherGraphics extends Grap
@NotImplemented
public void setClip(Shape shape)
{
- // ignore... not implemented
+ logger.log(POILogger.WARN,"setClip not supported");
}
@Override
@@ -516,23 +507,21 @@ public class EscherGraphics extends Grap
@NotImplemented
public void setPaintMode()
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"setPaintMode not supported");
+ logger.log(POILogger.WARN,"setPaintMode not supported");
}
@Override
@NotImplemented
public void setXORMode(Color color)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"setXORMode not supported");
+ logger.log(POILogger.WARN,"setXORMode not supported");
}
+
@Override
@NotImplemented
public void translate(int x, int y)
{
- if (logger.check( POILogger.WARN ))
- logger.log(POILogger.WARN,"translate not supported");
+ logger.log(POILogger.WARN,"translate not supported");
}
public Color getBackground()
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/HWPFOldDocument.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/HWPFOldDocument.java?rev=1884575&r1=1884574&r2=1884575&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/HWPFOldDocument.java
(original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/HWPFOldDocument.java Thu
Dec 17 22:05:35 2020
@@ -219,10 +219,10 @@ public class HWPFOldDocument extends HWP
/**
* Use {@link #getOldFontTable()} instead!!!
- * This always throws an IllegalArgumentException.
+ * This always throws an {@link UnsupportedOperationException}.
*
* @return nothing
- * @throws UnsupportedOperationException
+ * @throws UnsupportedOperationException Always.
*/
@Override
@NotImplemented
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
