Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSlope.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSlope.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSlope.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSlope.java Fri Jan 8 23:50:02 2021 @@ -55,7 +55,7 @@ public final class TestSlope { } @Test - public void testBasic() { + void testBasic() { Double exp = Math.pow(10, 7.5); ValueEval[] yValues = { new NumberEval(3+exp), @@ -84,7 +84,7 @@ public final class TestSlope { * number of items in array is not limited to 30 */ @Test - public void testLargeArrays() { + void testLargeArrays() { ValueEval[] yValues = createMockNumberArray(100, 3); // [1,2,0,1,2,0,...,0,1] yValues[0] = new NumberEval(2.0); // Changes first element to 2 ValueEval[] xValues = createMockNumberArray(100, 101); // [1,2,3,4,...,99,100] @@ -107,7 +107,7 @@ public final class TestSlope { } @Test - public void testErrors() { + void testErrors() { ValueEval[] xValues = { ErrorEval.REF_INVALID, new NumberEval(2),
Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestStatsLib.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestStatsLib.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestStatsLib.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestStatsLib.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; public class TestStatsLib extends BaseTestNumeric { @Test - public void testDevsq() { + void testDevsq() { double[] v; double d, x; @@ -69,7 +69,7 @@ public class TestStatsLib extends BaseTe } @Test - public void testKthLargest() { + void testKthLargest() { double[] v; double d, x; @@ -106,11 +106,11 @@ public class TestStatsLib extends BaseTe @Test @Disabled("... implement ...") - public void testKthSmallest() { + void testKthSmallest() { } @Test - public void testAvedev() { + void testAvedev() { double[] v; double d, x; @@ -146,7 +146,7 @@ public class TestStatsLib extends BaseTe } @Test - public void testMedian() { + void testMedian() { double[] v; double d, x; @@ -192,7 +192,7 @@ public class TestStatsLib extends BaseTe } @Test - public void testMode() { + void testMode() { double[] v; v = new double[] {1,2,3,4,5,6,7,8,9,10}; @@ -240,7 +240,7 @@ public class TestStatsLib extends BaseTe } @Test - public void testStddev() { + void testStddev() { double[] v; double d, x; @@ -276,7 +276,7 @@ public class TestStatsLib extends BaseTe } @Test - public void testVar() { + void testVar() { double[] v; double d, x; @@ -302,7 +302,7 @@ public class TestStatsLib extends BaseTe } @Test - public void testVarp() { + void testVarp() { double[] v; double d, x; Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSubstitute.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSubstitute.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSubstitute.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSubstitute.java Fri Jan 8 23:50:02 2021 @@ -28,7 +28,7 @@ import static org.junit.jupiter.api.Asse public class TestSubstitute { @Test - public void testSubstitute() { + void testSubstitute() { Substitute fun = new Substitute(); assertEquals("ADEFC", ((StringValueEval)fun.evaluate(0, 1, new StringEval("ABC"), new StringEval("B"), new StringEval("DEF"))).getStringValue()); @@ -41,7 +41,7 @@ public class TestSubstitute { } @Test - public void testSubstituteInvalidArg() { + void testSubstituteInvalidArg() { Substitute fun = new Substitute(); assertEquals(ErrorEval.valueOf(FormulaError.VALUE.getLongCode()), fun.evaluate(0, 1, @@ -59,7 +59,7 @@ public class TestSubstitute { } @Test - public void testSubstituteOne() { + void testSubstituteOne() { Substitute fun = new Substitute(); assertEquals("ADEFC", ((StringValueEval)fun.evaluate(0, 1, new StringEval("ABC"), new StringEval("B"), new StringEval("DEF"), new NumberEval(1))).getStringValue()); @@ -69,7 +69,7 @@ public class TestSubstitute { } @Test - public void testSubstituteNotFound() { + void testSubstituteNotFound() { Substitute fun = new Substitute(); assertEquals("ABC", ((StringValueEval)fun.evaluate(0, 1, new StringEval("ABC"), new StringEval("B"), new StringEval("DEF"), new NumberEval(12))).getStringValue()); @@ -79,7 +79,7 @@ public class TestSubstitute { } @Test - public void testSearchEmpty() { + void testSearchEmpty() { Substitute fun = new Substitute(); assertEquals("ABC", ((StringValueEval)fun.evaluate(0, 1, new StringEval("ABC"), new StringEval(""), new StringEval("CDE"))).getStringValue()); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSubtotal.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSubtotal.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSubtotal.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSubtotal.java Fri Jan 8 23:50:02 2021 @@ -75,7 +75,7 @@ public final class TestSubtotal { } @Test - public void testBasics() { + void testBasics() { confirmSubtotal(FUNCTION_SUM, 55.0); confirmSubtotal(FUNCTION_AVERAGE, 5.5); confirmSubtotal(FUNCTION_COUNT, 10.0); @@ -86,7 +86,7 @@ public final class TestSubtotal { } @Test - public void testAvg() throws IOException { + void testAvg() throws IOException { Workbook wb = new HSSFWorkbook(); FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator(); @@ -120,7 +120,7 @@ public final class TestSubtotal { } @Test - public void testSum() throws IOException { + void testSum() throws IOException { Workbook wb = new HSSFWorkbook(); FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator(); @@ -153,7 +153,7 @@ public final class TestSubtotal { } @Test - public void testCount() throws IOException { + void testCount() throws IOException { Workbook wb = new HSSFWorkbook(); @@ -187,7 +187,7 @@ public final class TestSubtotal { } @Test - public void testCounta() throws IOException { + void testCounta() throws IOException { Workbook wb = new HSSFWorkbook(); @@ -221,7 +221,7 @@ public final class TestSubtotal { } @Test - public void testMax() throws IOException { + void testMax() throws IOException { Workbook wb = new HSSFWorkbook(); @@ -255,7 +255,7 @@ public final class TestSubtotal { } @Test - public void testMin() throws IOException { + void testMin() throws IOException { Workbook wb = new HSSFWorkbook(); @@ -289,7 +289,7 @@ public final class TestSubtotal { } @Test - public void testStdev() throws IOException { + void testStdev() throws IOException { Workbook wb = new HSSFWorkbook(); @@ -323,7 +323,7 @@ public final class TestSubtotal { } @Test - public void test50209() throws IOException { + void test50209() throws IOException { Workbook wb = new HSSFWorkbook(); Sheet sh = wb.createSheet(); Cell a1 = sh.createRow(1).createCell(1); @@ -349,7 +349,7 @@ public final class TestSubtotal { } @Test - public void testFunctionsFromTestSpreadsheet() throws IOException { + void testFunctionsFromTestSpreadsheet() throws IOException { HSSFWorkbook workbook = HSSFTestDataSamples.openSampleWorkbook("SubtotalsNested.xls"); HSSFSheet sheet = workbook.getSheetAt(0); FormulaEvaluator evaluator = workbook.getCreationHelper().createFormulaEvaluator(); @@ -389,7 +389,7 @@ public final class TestSubtotal { } @Test - public void testUnimplemented() throws IOException { + void testUnimplemented() throws IOException { Workbook wb = new HSSFWorkbook(); FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator(); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumif.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumif.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumif.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumif.java Fri Jan 8 23:50:02 2021 @@ -50,7 +50,7 @@ public final class TestSumif { } @Test - public void testBasic() { + void testBasic() { ValueEval[] arg0values = new ValueEval[] { _30, _30, _40, _40, _50, _50 }; ValueEval[] arg2values = new ValueEval[] { _30, _40, _50, _60, _60, _60 }; @@ -82,7 +82,7 @@ public final class TestSumif { * test for bug observed near svn r882931 */ @Test - public void testCriteriaArgRange() { + void testCriteriaArgRange() { ValueEval[] arg0values = new ValueEval[] { _50, _60, _50, _50, _50, _30, }; ValueEval[] arg1values = new ValueEval[] { _30, _40, _50, _60, }; @@ -110,7 +110,7 @@ public final class TestSumif { } @Test - public void testEvaluateException() { + void testEvaluateException() { assertEquals(ErrorEval.VALUE_INVALID, invokeSumif(-1, -1, BlankEval.instance, new NumberEval(30.0))); assertEquals(ErrorEval.VALUE_INVALID, invokeSumif(-1, -1, BlankEval.instance, new NumberEval(30.0), new NumberEval(30.0))); assertEquals(ErrorEval.VALUE_INVALID, invokeSumif(-1, -1, new NumberEval(30.0), BlankEval.instance, new NumberEval(30.0))); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumifs.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumifs.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumifs.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumifs.java Fri Jan 8 23:50:02 2021 @@ -61,7 +61,7 @@ public final class TestSumifs { * http://office.microsoft.com/en-us/excel-help/sumifs-function-HA010047504.aspx */ @Test - public void testExample1() { + void testExample1() { // mimic test sample from http://office.microsoft.com/en-us/excel-help/sumifs-function-HA010047504.aspx ValueEval[] a2a9 = new ValueEval[] { new NumberEval(5), @@ -144,7 +144,7 @@ public final class TestSumifs { * http://office.microsoft.com/en-us/excel-help/sumifs-function-HA010047504.aspx */ @Test - public void testExample2() { + void testExample2() { ValueEval[] b2e2 = new ValueEval[] { new NumberEval(100), new NumberEval(390), @@ -195,7 +195,7 @@ public final class TestSumifs { * http://office.microsoft.com/en-us/excel-help/sumifs-function-HA010047504.aspx */ @Test - public void testExample3() { + void testExample3() { //3.3 0.8 5.5 5.5 ValueEval[] b2e2 = new ValueEval[] { new NumberEval(3.3), @@ -239,7 +239,7 @@ public final class TestSumifs { * Criteria entered as reference and by using wildcard characters */ @Test - public void testFromFile() { + void testFromFile() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("sumifs.xls"); HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb); @@ -278,7 +278,7 @@ public final class TestSumifs { } @Test - public void testBug56655() { + void testBug56655() { ValueEval[] a2a9 = new ValueEval[] { new NumberEval(5), new NumberEval(4), @@ -310,7 +310,7 @@ public final class TestSumifs { } @Test - public void testBug56655b() { + void testBug56655b() { /* setCellFormula(sheet, 0, 0, "B1*C1"); sheet.getRow(0).createCell(1).setCellValue("A"); @@ -335,7 +335,7 @@ public final class TestSumifs { } @Test - public void testBug56655c() { + void testBug56655c() { /* setCellFormula(sheet, 0, 0, "B1*C1"); sheet.getRow(0).createCell(1).setCellValue("A"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumproduct.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumproduct.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumproduct.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestSumproduct.java Fri Jan 8 23:50:02 2021 @@ -48,7 +48,7 @@ public final class TestSumproduct { } @Test - public void testScalarSimple() { + void testScalarSimple() { RefEval refEval = EvalFactory.createRefEval("A1", new NumberEval(3)); ValueEval[] args = { @@ -60,7 +60,7 @@ public final class TestSumproduct { } @Test - public void testAreaSimple() { + void testAreaSimple() { ValueEval[] aValues = { new NumberEval(2), new NumberEval(4), @@ -83,7 +83,7 @@ public final class TestSumproduct { * For scalar products, the terms may be 1x1 area refs */ @Test - public void testOneByOneArea() { + void testOneByOneArea() { AreaEval ae = EvalFactory.createAreaEval("A1:A1", new ValueEval[] { new NumberEval(7), }); @@ -96,7 +96,7 @@ public final class TestSumproduct { } @Test - public void testMismatchAreaDimensions() { + void testMismatchAreaDimensions() { AreaEval aeA = EvalFactory.createAreaEval("A1:A3", new ValueEval[3]); AreaEval aeB = EvalFactory.createAreaEval("B1:D1", new ValueEval[3]); @@ -110,7 +110,7 @@ public final class TestSumproduct { } @Test - public void testAreaWithErrorCell() { + void testAreaWithErrorCell() { ValueEval[] aValues = { ErrorEval.REF_INVALID, null, Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTFunc.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTFunc.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTFunc.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTFunc.java Fri Jan 8 23:50:02 2021 @@ -65,7 +65,7 @@ public final class TestTFunc { } @Test - public void testTextValues() { + void testTextValues() { confirmText("abc"); confirmText(""); confirmText(" "); @@ -80,7 +80,7 @@ public final class TestTFunc { } @Test - public void testErrorValues() { + void testErrorValues() { confirmError(ErrorEval.VALUE_INVALID); confirmError(ErrorEval.NA); @@ -98,14 +98,14 @@ public final class TestTFunc { } @Test - public void testOtherValues() { + void testOtherValues() { confirmOther(new NumberEval(2)); confirmOther(BoolEval.FALSE); confirmOther(BlankEval.instance); // can this particular case be verified? } @Test - public void testRefValues() { + void testRefValues() { ValueEval eval; eval = invokeTWithReference(new StringEval("def")); @@ -123,7 +123,7 @@ public final class TestTFunc { } @Test - public void testAreaArg() { + void testAreaArg() { ValueEval[] areaValues = new ValueEval[] { new StringEval("abc"), new StringEval("def"), new StringEval("ghi"), new StringEval("jkl"), Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestText.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestText.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestText.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestText.java Fri Jan 8 23:50:02 2021 @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; */ public final class TestText { @Test - public void testTextWithStringFirstArg() { + void testTextWithStringFirstArg() { ValueEval strArg = new StringEval("abc"); ValueEval formatArg = new StringEval("abc"); ValueEval[] args = { strArg, formatArg }; @@ -45,7 +45,7 @@ public final class TestText { } @Test - public void testTextWithDeciamlFormatSecondArg() { + void testTextWithDeciamlFormatSecondArg() { ValueEval numArg = new NumberEval(321321.321); ValueEval formatArg = new StringEval("#,###.00000"); ValueEval[] args = { numArg, formatArg }; @@ -71,7 +71,7 @@ public final class TestText { } @Test - public void testTextWithFractionFormatSecondArg() { + void testTextWithFractionFormatSecondArg() { ValueEval numArg = new NumberEval(321.321); ValueEval formatArg = new StringEval("# #/#"); ValueEval[] args = { numArg, formatArg }; @@ -93,7 +93,7 @@ public final class TestText { } @Test - public void testTextWithDateFormatSecondArg() { + void testTextWithDateFormatSecondArg() { TimeZone userTZ = LocaleUtil.getUserTimeZone(); LocaleUtil.setUserTimeZone(TimeZone.getTimeZone("CET")); try { Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTime.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTime.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTime.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTime.java Fri Jan 8 23:50:02 2021 @@ -60,13 +60,13 @@ public final class TestTime { } @Test - public void testSomeArgumentsMissing() { + void testSomeArgumentsMissing() { confirm("00:00:00", "TIME(, 0, 0)"); confirm("12:00:00", "TIME(12, , )"); } @Test - public void testValid() { + void testValid() { confirm("00:00:01", 0, 0, 1); confirm("00:01:00", 0, 1, 0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTrim.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTrim.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTrim.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTrim.java Fri Jan 8 23:50:02 2021 @@ -53,7 +53,7 @@ public final class TestTrim { } @Test - public void testBasic() { + void testBasic() { confirmTrim(new StringEval(" hi "), "hi"); confirmTrim(new StringEval("hi "), "hi"); @@ -67,7 +67,7 @@ public final class TestTrim { * Valid cases where text arg is not exactly a string */ @Test - public void testUnusualArgs() { + void testUnusualArgs() { // text (first) arg type is number, other args are strings with fractional digits confirmTrim(new NumberEval(123456), "123456"); @@ -77,7 +77,7 @@ public final class TestTrim { } @Test - public void testErrors() { + void testErrors() { confirmTrim(ErrorEval.NAME_INVALID, ErrorEval.NAME_INVALID); } } Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTrunc.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTrunc.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTrunc.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestTrunc.java Fri Jan 8 23:50:02 2021 @@ -34,7 +34,7 @@ public final class TestTrunc extends Bas private static final NumericFunction F = null; @Test - public void testTruncWithStringArg() { + void testTruncWithStringArg() { ValueEval strArg = new StringEval("abc"); ValueEval[] args = { strArg, new NumberEval(2) }; @@ -43,7 +43,7 @@ public final class TestTrunc extends Bas } @Test - public void testTruncWithWholeNumber() { + void testTruncWithWholeNumber() { ValueEval[] args = { new NumberEval(200), new NumberEval(2) }; @SuppressWarnings("static-access") ValueEval result = F.TRUNC.evaluate(args, -1, (short)-1); @@ -51,7 +51,7 @@ public final class TestTrunc extends Bas } @Test - public void testTruncWithDecimalNumber() { + void testTruncWithDecimalNumber() { ValueEval[] args = { new NumberEval(2.612777), new NumberEval(3) }; @SuppressWarnings("static-access") ValueEval result = F.TRUNC.evaluate(args, -1, (short)-1); @@ -59,14 +59,14 @@ public final class TestTrunc extends Bas } @Test - public void testTruncWithProblematicDecimalNumber() { + void testTruncWithProblematicDecimalNumber() { ValueEval[] args = { new NumberEval(0.29), new NumberEval(2) }; ValueEval result = NumericFunction.TRUNC.evaluate(args, -1, (short)-1); assertDouble("TRUNC", (new NumberEval(0.29d)).getNumberValue(), ((NumberEval)result).getNumberValue()); } @Test - public void testTruncWithProblematicCalculationResult() { + void testTruncWithProblematicCalculationResult() { ValueEval[] args = { new NumberEval(21.624d / 24d + .009d), new NumberEval(2) }; ValueEval result = NumericFunction.TRUNC.evaluate(args, -1, (short)-1); @@ -74,14 +74,14 @@ public final class TestTrunc extends Bas } @Test - public void testTruncWithDecimalNumberOneArg() { + void testTruncWithDecimalNumberOneArg() { ValueEval[] args = { new NumberEval(2.612777) }; ValueEval result = NumericFunction.TRUNC.evaluate(args, -1, (short)-1); assertDouble("TRUNC", (new NumberEval(2d)).getNumberValue(), ((NumberEval)result).getNumberValue()); } @Test - public void testNegative() { + void testNegative() { ValueEval[] args = { new NumberEval(-8.9), new NumberEval(0) }; @SuppressWarnings("static-access") ValueEval result = F.TRUNC.evaluate(args, -1, (short)-1); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestValue.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestValue.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestValue.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestValue.java Fri Jan 8 23:50:02 2021 @@ -48,7 +48,7 @@ public final class TestValue { } @Test - public void testBasic() { + void testBasic() { confirmValue("100", 100); confirmValue("-2.3", -2.3); @@ -76,7 +76,7 @@ public final class TestValue { } @Test - public void testErrors() { + void testErrors() { confirmValueError("1+1"); confirmValueError("1 1"); confirmValueError("1,00.0"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestWeekdayFunc.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestWeekdayFunc.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestWeekdayFunc.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestWeekdayFunc.java Fri Jan 8 23:50:02 2021 @@ -45,7 +45,7 @@ public class TestWeekdayFunc { @Test - public void testEvaluate() { + void testEvaluate() { assertEvaluateEquals(2.0, 1.0); assertEvaluateEquals(2.0, 1.0, 1.0); assertEvaluateEquals(1.0, 1.0, 2.0); @@ -80,7 +80,7 @@ public class TestWeekdayFunc { } @Test - public void testEvaluateInvalid() { + void testEvaluateInvalid() { assertEvaluateEquals("no args", ErrorEval.VALUE_INVALID); assertEvaluateEquals("too many args", ErrorEval.VALUE_INVALID, new NumberEval(1.0), new NumberEval(1.0), new NumberEval(1.0)); assertEvaluateEquals("negative date", ErrorEval.NUM_ERROR, new NumberEval(-1.0)); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestXYNumericFunction.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestXYNumericFunction.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestXYNumericFunction.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestXYNumericFunction.java Fri Jan 8 23:50:02 2021 @@ -57,7 +57,7 @@ public final class TestXYNumericFunction } @Test - public void testBasic() { + void testBasic() { ValueEval[] xValues = { new NumberEval(1), new NumberEval(2), @@ -81,7 +81,7 @@ public final class TestXYNumericFunction * number of items in array is not limited to 30 */ @Test - public void testLargeArrays() { + void testLargeArrays() { ValueEval[] xValues = createMockNumberArray(100, 3); ValueEval[] yValues = createMockNumberArray(100, 2); @@ -105,7 +105,7 @@ public final class TestXYNumericFunction } @Test - public void testErrors() { + void testErrors() { ValueEval[] xValues = { ErrorEval.REF_INVALID, new NumberEval(2), Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAbstractFunctionPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAbstractFunctionPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAbstractFunctionPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAbstractFunctionPtg.java Fri Jan 8 23:50:02 2021 @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; public class TestAbstractFunctionPtg { @Test - public void testConstructor() { + void testConstructor() { FunctionPtg ptg = new FunctionPtg(1, 2, null, 255); assertEquals(1, ptg.getFunctionIndex()); assertEquals(2, ptg.getDefaultOperandClass()); @@ -34,12 +34,12 @@ public class TestAbstractFunctionPtg { } @Test - public void testInvalidFunctionIndex() { + void testInvalidFunctionIndex() { assertThrows(RuntimeException.class, () -> new FunctionPtg(40000, 2, null, 255)); } @Test - public void testInvalidRuntimeClass() { + void testInvalidRuntimeClass() { assertThrows(RuntimeException.class, () -> new FunctionPtg(1, 300, null, 255)); } Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestArea3DPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestArea3DPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestArea3DPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestArea3DPtg.java Fri Jan 8 23:50:02 2021 @@ -34,7 +34,7 @@ public final class TestArea3DPtg extends * confirms that sheet names get properly escaped */ @Test - public void testToFormulaString() throws IOException { + void testToFormulaString() throws IOException { Area3DPtg target = new Area3DPtg("A1:B1", (short)0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaErrPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaErrPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaErrPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaErrPtg.java Fri Jan 8 23:50:02 2021 @@ -32,7 +32,7 @@ public final class TestAreaErrPtg extend * Tests reading a file containing this ptg. */ @Test - public void testReading() throws IOException { + void testReading() throws IOException { try (HSSFWorkbook workbook = loadWorkbook("AreaErrPtg.xls")) { assertEquals("SUM(#REF!)", workbook.getSheetAt(0).getRow(0).getCell(2).getCellFormula(), "Wrong formula string for area error"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaPtg.java Fri Jan 8 23:50:02 2021 @@ -45,7 +45,7 @@ public final class TestAreaPtg { } @Test - public void testSortTopLeftToBottomRight() { + void testSortTopLeftToBottomRight() { AreaPtg ptg = new AreaPtg(new AreaReference("A$1:$B5", SpreadsheetVersion.EXCEL2007)); assertEquals("A$1:$B5", ptg.toFormulaString()); ptg.setFirstColumn(3); @@ -57,13 +57,13 @@ public final class TestAreaPtg { } @Test - public void testSetColumnsAbsolute() { + void testSetColumnsAbsolute() { resetColumns(absolute); validateReference(true, absolute); } @Test - public void testSetColumnsRelative() { + void testSetColumnsRelative() { resetColumns(relative); validateReference(false, relative); } @@ -87,7 +87,7 @@ public final class TestAreaPtg { } @Test - public void testAbsoluteRelativeRefs() { + void testAbsoluteRelativeRefs() { AreaPtg sca1 = new AreaPtg(4, 5, 6, 7, true, false, true, false); AreaPtg sca2 = new AreaPtg(4, 5, 6, 7, false, true, false, true); AreaPtg sca3 = new AreaPtg(5, 5, 7, 7, true, false, true, false); @@ -117,7 +117,7 @@ public final class TestAreaPtg { } @Test - public void testFormulaParser() { + void testFormulaParser() { String formula1="SUM($E$5:$E$6)"; String expectedFormula1="SUM($F$5:$F$6)"; String newFormula1 = shiftAllColumnsBy1(formula1); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestArrayPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestArrayPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestArrayPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestArrayPtg.java Fri Jan 8 23:50:02 2021 @@ -57,7 +57,7 @@ public final class TestArrayPtg { * Lots of problems with ArrayPtg's decoding and encoding of the element value data */ @Test - public void testReadWriteTokenValueBytes() { + void testReadWriteTokenValueBytes() { ArrayPtg ptg = create(ENCODED_PTG_DATA, ENCODED_CONSTANT_DATA); assertEquals(3, ptg.getColumnCount()); assertEquals(2, ptg.getRowCount()); @@ -83,7 +83,7 @@ public final class TestArrayPtg { * Excel stores array elements column by column. This test makes sure POI does the same. */ @Test - public void testElementOrdering() { + void testElementOrdering() { ArrayPtg ptg = create(ENCODED_PTG_DATA, ENCODED_CONSTANT_DATA); assertEquals(3, ptg.getColumnCount()); assertEquals(2, ptg.getRowCount()); @@ -101,7 +101,7 @@ public final class TestArrayPtg { * A spreadsheet was added to make the ordering clearer. */ @Test - public void testElementOrderingInSpreadsheet() { + void testElementOrderingInSpreadsheet() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("ex42564-elementOrder.xls"); // The formula has an array with 3 rows and 5 columns @@ -112,7 +112,7 @@ public final class TestArrayPtg { } @Test - public void testToFormulaString() { + void testToFormulaString() { ArrayPtg ptg = create(ENCODED_PTG_DATA, ENCODED_CONSTANT_DATA); // bug 45380 - Unexpected constant class (java.lang.Boolean) String actualFormula = ptg.toFormulaString(); @@ -123,7 +123,7 @@ public final class TestArrayPtg { * worth checking since AttrPtg.sid=0x20 and Ptg.CLASS_* = (0x00, 0x20, and 0x40) */ @Test - public void testOperandClassDecoding() { + void testOperandClassDecoding() { confirmOperandClassDecoding(Ptg.CLASS_REF); confirmOperandClassDecoding(Ptg.CLASS_VALUE); confirmOperandClassDecoding(Ptg.CLASS_ARRAY); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAttrPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAttrPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAttrPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestAttrPtg.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ public final class TestAttrPtg extends B * Fix for bug visible around svn r706772. */ @Test - public void testReserializeAttrChoose() { + void testReserializeAttrChoose() { byte[] data = HexRead.readFromString("19, 04, 03, 00, 08, 00, 11, 00, 1A, 00, 23, 00"); LittleEndianInput in = TestcaseRecordInputStream.createLittleEndian(data); Ptg[] ptgs = Ptg.readTokens(data.length, in); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestErrPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestErrPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestErrPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestErrPtg.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ public final class TestErrPtg extends Ba * Tests reading a file containing this ptg. */ @Test - public void testReading() throws IOException { + void testReading() throws IOException { try (HSSFWorkbook workbook = loadWorkbook("ErrPtg.xls")) { HSSFCell cell = workbook.getSheetAt(0).getRow(3).getCell(0); assertEquals(4.0, cell.getNumericCellValue(), 0.0, "Wrong cell value"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalFunctionFormulas.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalFunctionFormulas.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalFunctionFormulas.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalFunctionFormulas.java Fri Jan 8 23:50:02 2021 @@ -37,7 +37,7 @@ public final class TestExternalFunctionF * tests <tt>NameXPtg.toFormulaString(Workbook)</tt> and logic in Workbook below that */ @Test - public void testReadFormulaContainingExternalFunction() throws Exception { + void testReadFormulaContainingExternalFunction() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("externalFunctionExample.xls"); String expectedFormula = "YEARFRAC(B1,C1)"; @@ -49,7 +49,7 @@ public final class TestExternalFunctionF } @Test - public void testParse() throws Exception { + void testParse() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("externalFunctionExample.xls"); Ptg[] ptgs = HSSFFormulaParser.parse("YEARFRAC(B1,C1)", wb); assertEquals(4, ptgs.length); @@ -72,7 +72,7 @@ public final class TestExternalFunctionF } @Test - public void testEvaluate() throws Exception { + void testEvaluate() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("externalFunctionExample.xls"); HSSFSheet sheet = wb.getSheetAt(0); HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java Fri Jan 8 23:50:02 2021 @@ -42,7 +42,7 @@ public final class TestExternalNameRefer * tests <tt>NameXPtg for external cell reference by name</tt> and logic in Workbook below that */ @Test - public void testReadCalcSheet() { + void testReadCalcSheet() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("XRefCalc.xls"); HSSFName name = wb.getName("QUANT"); assertNotNull(name); @@ -78,7 +78,7 @@ public final class TestExternalNameRefer } @Test - public void testReadReferencedSheet() { + void testReadReferencedSheet() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("XRefCalcData.xls"); HSSFName name = wb.getName("COSTS"); assertNotNull(name); @@ -92,7 +92,7 @@ public final class TestExternalNameRefer } @Test - public void testEvaluate() { + void testEvaluate() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("XRefCalc.xls"); HSSFWorkbook wb2 = HSSFTestDataSamples.openSampleWorkbook("XRefCalcData.xls"); HSSFName name = wb.getName("QUANT"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncPtg.java Fri Jan 8 23:50:02 2021 @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; public final class TestFuncPtg { @Test - public void testRead() { + void testRead() { // This function index represents the LEN() function byte[] fakeData = { 0x20, 0x00,}; @@ -40,7 +40,7 @@ public final class TestFuncPtg { } @Test - public void testNumberOfOperands() { + void testNumberOfOperands() { FuncPtg funcPtg = FuncPtg.create(27); // ROUND() - takes 2 args assertEquals(2, funcPtg.getNumberOfOperands()); assertEquals("ROUND", funcPtg.getName()); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncVarPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncVarPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncVarPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncVarPtg.java Fri Jan 8 23:50:02 2021 @@ -37,7 +37,7 @@ public final class TestFuncVarPtg { * This functionality is related to the setParameterRVA() methods of <tt>FormulaParser</tt> */ @Test - public void testOperandClass() { + void testOperandClass() { HSSFWorkbook book = new HSSFWorkbook(); Ptg[] ptgs = HSSFFormulaParser.parse("sum(A1:A2)", book); assertEquals(2, ptgs.length); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestIntersectionPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestIntersectionPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestIntersectionPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestIntersectionPtg.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ public final class TestIntersectionPtg e * Tests reading a file containing this ptg. */ @Test - public void testReading() throws IOException { + void testReading() throws IOException { try (HSSFWorkbook workbook = loadWorkbook("IntersectionPtg.xls")) { HSSFCell cell = workbook.getSheetAt(0).getRow(4).getCell(2); assertEquals(5.0, cell.getNumericCellValue(), 0.0, "Wrong cell value"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestPercentPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestPercentPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestPercentPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestPercentPtg.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ public final class TestPercentPtg extend * Tests reading a file containing this ptg. */ @Test - public void testReading() throws IOException { + void testReading() throws IOException { try (HSSFWorkbook workbook = loadWorkbook("PercentPtg.xls")) { HSSFSheet sheet = workbook.getSheetAt(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestRangePtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestRangePtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestRangePtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestRangePtg.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ public final class TestRangePtg extends * Tests reading a file containing this ptg. */ @Test - public void testReading() throws IOException { + void testReading() throws IOException { try (HSSFWorkbook workbook = loadWorkbook("RangePtg.xls")) { HSSFCell cell = workbook.getSheetAt(0).getRow(3).getCell(1); assertEquals(10.0, cell.getNumericCellValue(), 0.0, "Wrong cell value"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestRef3DPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestRef3DPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestRef3DPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestRef3DPtg.java Fri Jan 8 23:50:02 2021 @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; */ public final class TestRef3DPtg extends BaseTestPtg { @Test - public void testToFormulaString() throws IOException { + void testToFormulaString() throws IOException { Ref3DPtg target = new Ref3DPtg("A1", (short)0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestReferencePtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestReferencePtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestReferencePtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestReferencePtg.java Fri Jan 8 23:50:02 2021 @@ -38,7 +38,7 @@ public final class TestReferencePtg { * Tests reading a file containing this ptg. */ @Test - public void testReading() { + void testReading() { HSSFWorkbook workbook = HSSFTestDataSamples.openSampleWorkbook("ReferencePtg.xls"); HSSFSheet sheet = workbook.getSheetAt(0); @@ -69,7 +69,7 @@ public final class TestReferencePtg { } @Test - public void testBug44921() throws IOException { + void testBug44921() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("ex44921-21902.xls")) { HSSFTestDataSamples.writeOutAndReadBack(wb).close(); } @@ -80,7 +80,7 @@ public final class TestReferencePtg { }; @Test - public void testReadWrite_tRefN_bug45091() { + void testReadWrite_tRefN_bug45091() { LittleEndianInput in = TestcaseRecordInputStream.createLittleEndian(tRefN_data); Ptg[] ptgs = Ptg.readTokens(tRefN_data.length, in); byte[] outData = new byte[5]; @@ -94,7 +94,7 @@ public final class TestReferencePtg { * see Bugzilla 50096 */ @Test - public void testColumnGreater255() { + void testColumnGreater255() { RefPtgBase ptg; ptg = new RefPtg("IW1"); assertEquals(256, ptg.getColumn()); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestUnionPtg.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestUnionPtg.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestUnionPtg.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/ptg/TestUnionPtg.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ public final class TestUnionPtg extends * Tests reading a file containing this ptg. */ @Test - public void testReading() throws IOException { + void testReading() throws IOException { try (HSSFWorkbook workbook = loadWorkbook("UnionPtg.xls")) { HSSFCell cell = workbook.getSheetAt(0).getRow(4).getCell(2); assertEquals(24.0, cell.getNumericCellValue(), 0.0, "Wrong cell value"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBorderStyle.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBorderStyle.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBorderStyle.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBorderStyle.java Fri Jan 8 23:50:02 2021 @@ -44,7 +44,7 @@ public abstract class BaseTestBorderStyl * how to format normal numbers */ @Test - public void testBorderStyle() throws IOException { + void testBorderStyle() throws IOException { String ext = _testDataProvider.getStandardFileNameExtension(); Workbook wb = _testDataProvider.openSampleWorkbook("59264."+ext); Sheet sh = wb.getSheetAt(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java Fri Jan 8 23:50:02 2021 @@ -928,7 +928,7 @@ public abstract class BaseTestBugzillaIs } @Test - public void test56574OverwriteExistingRow() throws IOException { + void test56574OverwriteExistingRow() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); @@ -1035,7 +1035,7 @@ public abstract class BaseTestBugzillaIs } @Test - public void test57973() throws IOException { + void test57973() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { CreationHelper factory = wb.getCreationHelper(); @@ -1144,7 +1144,7 @@ public abstract class BaseTestBugzillaIs } @Test - public void test58113() throws IOException { + void test58113() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("Test"); @@ -1310,7 +1310,7 @@ public abstract class BaseTestBugzillaIs } @Test - public void test50319() throws IOException { + void test50319() throws IOException { try (Workbook wb = new HSSFWorkbook()) { Sheet sheet = wb.createSheet("Test"); sheet.createRow(0); @@ -1325,7 +1325,7 @@ public abstract class BaseTestBugzillaIs // Bug 58648: FormulaParser throws exception in parseSimpleFactor() when getCellFormula() // is called on a cell and the formula contains spaces between closing parentheses ") )" @Test - public void test58648() throws IOException { + void test58648() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cell = wb.createSheet().createRow(0).createCell(0); cell.setCellFormula("((1 + 1) )"); @@ -1337,7 +1337,7 @@ public abstract class BaseTestBugzillaIs * it as an empty cell, and avoid a NPE on auto-sizing */ @Test - public void test57034() throws Exception { + void test57034() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet s = wb.createSheet(); Cell cell = s.createRow(0).createCell(0); @@ -1355,7 +1355,7 @@ public abstract class BaseTestBugzillaIs } @Test - public void test52684() throws IOException { + void test52684() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("test"); @@ -1380,7 +1380,7 @@ public abstract class BaseTestBugzillaIs } @Test - public void test58896() throws IOException { + void test58896() throws IOException { final int nrows = 160; final int ncols = 139; @@ -1524,7 +1524,7 @@ public abstract class BaseTestBugzillaIs @Disabled @Test - public void test57929() throws IOException { + void test57929() throws IOException { // Create a workbook with print areas on 2 sheets try (Workbook wb = _testDataProvider.createWorkbook()) { wb.createSheet("Sheet0"); @@ -1555,7 +1555,7 @@ public abstract class BaseTestBugzillaIs @Test - public void test55384() throws Exception { + void test55384() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sh = wb.createSheet(); for (int rownum = 0; rownum < 10; rownum++) { @@ -1709,7 +1709,7 @@ public abstract class BaseTestBugzillaIs } @Test - public void test59200() throws IOException { + void test59200() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { final Sheet sheet = wb.createSheet(); @@ -1763,7 +1763,7 @@ public abstract class BaseTestBugzillaIs } @Test - public void test60370() throws IOException { + void test60370() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { final Sheet sheet = wb.createSheet(); Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java Fri Jan 8 23:50:02 2021 @@ -65,7 +65,7 @@ public abstract class BaseTestCell { } @Test - public void testSetValues() throws Exception { + void testSetValues() throws Exception { try (Workbook book = _testDataProvider.createWorkbook()) { Sheet sheet = book.createSheet("test"); Row row = sheet.createRow(0); @@ -189,7 +189,7 @@ public abstract class BaseTestCell { * test that Boolean (BoolErrRecord) are supported properly. */ @Test - public void testBool() throws IOException { + void testBool() throws IOException { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet s = wb1.createSheet("testSheet1"); Row r; @@ -235,7 +235,7 @@ public abstract class BaseTestCell { * @see #testBool */ @Test - public void testErr() throws IOException { + void testErr() throws IOException { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet s = wb1.createSheet("testSheet1"); @@ -282,7 +282,7 @@ public abstract class BaseTestCell { * test that Cell Styles being applied to formulas remain intact */ @Test - public void testFormulaStyle() throws Exception { + void testFormulaStyle() throws Exception { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet s = wb1.createSheet("testSheet1"); Row r; @@ -325,7 +325,7 @@ public abstract class BaseTestCell { /**tests the toString() method of HSSFCell*/ @Test - public void testToString() throws Exception { + void testToString() throws Exception { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Row r = wb1.createSheet("Sheet1").createRow(0); CreationHelper factory = wb1.getCreationHelper(); @@ -380,7 +380,7 @@ public abstract class BaseTestCell { * Test that setting cached formula result keeps the cell type */ @Test - public void testSetFormulaValue() throws Exception { + void testSetFormulaValue() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet s = wb.createSheet(); Row r = s.createRow(0); @@ -420,7 +420,7 @@ public abstract class BaseTestCell { * Make sure that formulas with unknown/unregistered UDFs can be written to and read back from a file. */ @Test - public void testFormulaWithUnknownUDF() throws IOException { + void testFormulaWithUnknownUDF() throws IOException { try (final Workbook wb1 = _testDataProvider.createWorkbook()) { final FormulaEvaluator evaluator1 = wb1.getCreationHelper().createFormulaEvaluator(); final Cell cell1 = wb1.createSheet().createRow(0).createCell(0); @@ -442,7 +442,7 @@ public abstract class BaseTestCell { } @Test - public void testChangeTypeStringToBool() throws IOException { + void testChangeTypeStringToBool() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cell = createACell(wb); @@ -467,7 +467,7 @@ public abstract class BaseTestCell { } @Test - public void testChangeTypeBoolToString() throws IOException { + void testChangeTypeBoolToString() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cell = createACell(wb); @@ -479,7 +479,7 @@ public abstract class BaseTestCell { } @Test - public void testChangeTypeErrorToNumber() throws IOException { + void testChangeTypeErrorToNumber() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cell = createACell(wb); cell.setCellErrorValue(FormulaError.NAME.getCode()); @@ -490,7 +490,7 @@ public abstract class BaseTestCell { } @Test - public void testChangeTypeErrorToBoolean() throws IOException { + void testChangeTypeErrorToBoolean() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); Cell cell = createACell(wb); @@ -508,7 +508,7 @@ public abstract class BaseTestCell { * string result type. */ @Test - public void testConvertStringFormulaCell() throws IOException { + void testConvertStringFormulaCell() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cellA1 = createACell(wb); cellA1.setCellFormula("\"abc\""); @@ -532,7 +532,7 @@ public abstract class BaseTestCell { * lower level that {#link {@link Cell#setCellType(CellType)} works properly */ @Test - public void testSetTypeStringOnFormulaCell() throws IOException { + void testSetTypeStringOnFormulaCell() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cellA1 = createACell(wb); FormulaEvaluator fe = cellA1.getSheet().getWorkbook().getCreationHelper().createFormulaEvaluator(); @@ -578,7 +578,7 @@ public abstract class BaseTestCell { * Test for bug in convertCellValueToBoolean to make sure that formula results get converted */ @Test - public void testChangeTypeFormulaToBoolean() throws IOException { + void testChangeTypeFormulaToBoolean() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cell = createACell(wb); cell.setCellFormula("1=1"); @@ -594,7 +594,7 @@ public abstract class BaseTestCell { * ClassCastException if cell is created using HSSFRow.createCell(short column, int type) */ @Test - public void test40296() throws Exception { + void test40296() throws Exception { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet workSheet = wb1.createSheet("Sheet1"); Cell cell; @@ -634,7 +634,7 @@ public abstract class BaseTestCell { } @Test - public void testSetStringInFormulaCell_bug44606() throws Exception { + void testSetStringInFormulaCell_bug44606() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cell = wb.createSheet("Sheet1").createRow(0).createCell(0); cell.setCellFormula("B1&C1"); @@ -648,7 +648,7 @@ public abstract class BaseTestCell { * Make sure that cell.setBlank() preserves the cell style */ @Test - public void testSetBlank_bug47028() throws Exception { + void testSetBlank_bug47028() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { CellStyle style = wb.createCellStyle(); Cell cell = wb.createSheet("Sheet1").createRow(0).createCell(0); @@ -680,7 +680,7 @@ public abstract class BaseTestCell { * </ul> */ @Test - public void testNanAndInfinity() throws Exception { + void testNanAndInfinity() throws Exception { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet workSheet = wb1.createSheet("Sheet1"); Row row = workSheet.createRow(0); @@ -719,7 +719,7 @@ public abstract class BaseTestCell { } @Test - public void testDefaultStyleProperties() throws Exception { + void testDefaultStyleProperties() throws Exception { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Cell cell = wb1.createSheet("Sheet1").createRow(0).createCell(0); @@ -758,7 +758,7 @@ public abstract class BaseTestCell { } @Test - public void testBug55658SetNumericValue() throws Exception { + void testBug55658SetNumericValue() throws Exception { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet sh = wb1.createSheet(); Row row = sh.createRow(0); @@ -780,7 +780,7 @@ public abstract class BaseTestCell { } @Test - public void testRemoveHyperlink() throws Exception { + void testRemoveHyperlink() throws Exception { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet sh = wb1.createSheet("test"); Row row = sh.createRow(0); @@ -824,7 +824,7 @@ public abstract class BaseTestCell { * an problem that cell could not return error value form formula cell). */ @Test - public void testGetErrorCellValueFromFormulaCell() throws IOException { + void testGetErrorCellValueFromFormulaCell() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); Row row = sheet.createRow(0); @@ -836,7 +836,7 @@ public abstract class BaseTestCell { } @Test - public void testSetRemoveStyle() throws Exception { + void testSetRemoveStyle() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); Row row = sheet.createRow(0); @@ -875,7 +875,7 @@ public abstract class BaseTestCell { } @Test - public void test57008() throws IOException { + void test57008() throws IOException { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet sheet = wb1.createSheet(); @@ -903,7 +903,7 @@ public abstract class BaseTestCell { */ @SuppressWarnings("ConstantConditions") @Test - public void testSetCellValueNullRichTextString() throws IOException { + void testSetCellValueNullRichTextString() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); Cell cell = sheet.createRow(0).createCell(0); @@ -942,7 +942,7 @@ public abstract class BaseTestCell { * The maximum length of cell contents (text) is 32,767 characters. */ @Test - public void testMaxTextLength() throws IOException{ + void testMaxTextLength() throws IOException{ try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); Cell cell = sheet.createRow(0).createCell(0); @@ -1016,7 +1016,7 @@ public abstract class BaseTestCell { } @Test - public void testSetErrorValue() throws Exception { + void testSetErrorValue() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); Row row = sheet.createRow(0); @@ -1039,7 +1039,7 @@ public abstract class BaseTestCell { } @Test - public void test62216() throws IOException { + void test62216() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell instance = wb.createSheet().createRow(0).createCell(0); String formula = "2"; @@ -1051,7 +1051,7 @@ public abstract class BaseTestCell { } @Test - public void testSetNullValues() throws IOException { + void testSetNullValues() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cell = wb.createSheet("test").createRow(0).createCell(0); @@ -1081,7 +1081,7 @@ public abstract class BaseTestCell { } @Test - public void testFormulaSetValueDoesNotChangeType() throws IOException { + void testFormulaSetValueDoesNotChangeType() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); Row row = sheet.createRow(0); @@ -1111,7 +1111,7 @@ public abstract class BaseTestCell { } @Test - public void testGetNumericCellValueOnABlankCellReturnsZero() throws IOException { + void testGetNumericCellValueOnABlankCellReturnsZero() throws IOException { try (Workbook workbook = _testDataProvider.createWorkbook()) { Cell cell = workbook.createSheet().createRow(0).createCell(0); assertEquals(CellType.BLANK, cell.getCellType()); Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCloneSheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCloneSheet.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCloneSheet.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCloneSheet.java Fri Jan 8 23:50:02 2021 @@ -40,7 +40,7 @@ public abstract class BaseTestCloneSheet } @Test - public void testCloneSheetBasic() throws IOException{ + void testCloneSheetBasic() throws IOException{ Workbook b = _testDataProvider.createWorkbook(); Sheet s = b.createSheet("Test"); assertEquals(0, s.addMergedRegion(new CellRangeAddress(0, 1, 0, 1))); @@ -55,7 +55,7 @@ public abstract class BaseTestCloneSheet * Ensures that pagebreak cloning works properly */ @Test - public void testPageBreakClones() throws IOException { + void testPageBreakClones() throws IOException { Workbook b = _testDataProvider.createWorkbook(); Sheet s = b.createSheet("Test"); s.setRowBreak(3); @@ -73,7 +73,7 @@ public abstract class BaseTestCloneSheet } @Test - public void testCloneSheetIntValid() { + void testCloneSheetIntValid() { Workbook wb = _testDataProvider.createWorkbook(); wb.createSheet("Sheet01"); wb.cloneSheet(0); @@ -82,7 +82,7 @@ public abstract class BaseTestCloneSheet } @Test - public void testCloneSheetIntInvalid() { + void testCloneSheetIntInvalid() { Workbook wb = _testDataProvider.createWorkbook(); wb.createSheet("Sheet01"); assertThrows(IllegalArgumentException.class, () -> wb.cloneSheet(1)); Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestColumnShifting.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestColumnShifting.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestColumnShifting.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestColumnShifting.java Fri Jan 8 23:50:02 2021 @@ -60,7 +60,7 @@ public abstract class BaseTestColumnShif protected void initColumnShifter() {} @Test - public void testShift3ColumnsRight() { + void testShift3ColumnsRight() { columnShifter.shiftColumns(1, 2, 3); Cell cell = sheet1.getRow(0).getCell(4); @@ -74,7 +74,7 @@ public abstract class BaseTestColumnShif } @Test - public void testShiftLeft() { + void testShiftLeft() { assertThrows(IllegalStateException.class, () -> columnShifter.shiftColumns(1, 2, -3), "Shift to negative indices should throw exception"); } Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java Fri Jan 8 23:50:02 2021 @@ -54,7 +54,7 @@ public abstract class BaseTestConditiona protected abstract void assertColor(String hexExpected, Color actual); @Test - public void testBasic() throws Throwable { + void testBasic() throws Throwable { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sh = wb.createSheet(); SheetConditionalFormatting sheetCF = sh.getSheetConditionalFormatting(); @@ -100,7 +100,7 @@ public abstract class BaseTestConditiona * Test format conditions based on a boolean formula */ @Test - public void testBooleanFormulaConditions() throws IOException { + void testBooleanFormulaConditions() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sh = wb.createSheet(); SheetConditionalFormatting sheetCF = sh.getSheetConditionalFormatting(); @@ -136,7 +136,7 @@ public abstract class BaseTestConditiona } @Test - public void testSingleFormulaConditions() throws IOException { + void testSingleFormulaConditions() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sh = wb.createSheet(); SheetConditionalFormatting sheetCF = sh.getSheetConditionalFormatting(); @@ -200,7 +200,7 @@ public abstract class BaseTestConditiona } @Test - public void testCopy() throws IOException { + void testCopy() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet1 = wb.createSheet(); Sheet sheet2 = wb.createSheet(); @@ -240,7 +240,7 @@ public abstract class BaseTestConditiona } @Test - public void testRemove() throws IOException { + void testRemove() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet1 = wb.createSheet(); SheetConditionalFormatting sheetCF = sheet1.getSheetConditionalFormatting(); @@ -274,7 +274,7 @@ public abstract class BaseTestConditiona } @Test - public void testCreateCF() throws IOException { + void testCreateCF() throws IOException { try (Workbook workbook = _testDataProvider.createWorkbook()) { Sheet sheet = workbook.createSheet(); String formula = "7"; @@ -352,7 +352,7 @@ public abstract class BaseTestConditiona } @Test - public void testClone() throws IOException { + void testClone() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); String formula = "7"; @@ -384,7 +384,7 @@ public abstract class BaseTestConditiona } @Test - public void testShiftRows() throws IOException { + void testShiftRows() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); @@ -522,7 +522,7 @@ public abstract class BaseTestConditiona } } - public void testReadOffice2007(String filename) throws IOException { + protected void testReadOffice2007(String filename) throws IOException { try (Workbook wb = _testDataProvider.openSampleWorkbook(filename)) { Sheet s = wb.getSheet("CF"); @@ -851,7 +851,7 @@ public abstract class BaseTestConditiona } @Test - public void testCreateFontFormatting() throws IOException { + void testCreateFontFormatting() throws IOException { try (Workbook workbook = _testDataProvider.createWorkbook()) { Sheet sheet = workbook.createSheet(); @@ -919,7 +919,7 @@ public abstract class BaseTestConditiona } @Test - public void testCreatePatternFormatting() throws IOException { + void testCreatePatternFormatting() throws IOException { try (Workbook workbook = _testDataProvider.createWorkbook()) { Sheet sheet = workbook.createSheet(); @@ -966,7 +966,7 @@ public abstract class BaseTestConditiona } @Test - public void testAllCreateBorderFormatting() throws IOException { + void testAllCreateBorderFormatting() throws IOException { // Make sure it is possible to create a conditional formatting rule // with every type of Border Style try (Workbook workbook = _testDataProvider.createWorkbook()) { @@ -997,7 +997,7 @@ public abstract class BaseTestConditiona } @Test - public void testCreateBorderFormatting() throws IOException { + void testCreateBorderFormatting() throws IOException { try (Workbook workbook = _testDataProvider.createWorkbook()) { Sheet sheet = workbook.createSheet(); @@ -1060,7 +1060,7 @@ public abstract class BaseTestConditiona } @Test - public void testCreateIconFormatting() throws IOException { + void testCreateIconFormatting() throws IOException { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet sheet = wb1.createSheet(); @@ -1115,7 +1115,7 @@ public abstract class BaseTestConditiona } @Test - public void testCreateColorScaleFormatting() throws IOException { + void testCreateColorScaleFormatting() throws IOException { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet sheet = wb1.createSheet(); @@ -1163,7 +1163,7 @@ public abstract class BaseTestConditiona } @Test - public void testCreateDataBarFormatting() throws IOException { + void testCreateDataBarFormatting() throws IOException { try (Workbook wb1 = _testDataProvider.createWorkbook()) { Sheet sheet = wb1.createSheet(); @@ -1214,7 +1214,7 @@ public abstract class BaseTestConditiona } @Test - public void testBug55380() throws IOException { + void testBug55380() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); CellRangeAddress[] ranges = new CellRangeAddress[]{ @@ -1226,7 +1226,7 @@ public abstract class BaseTestConditiona } @Test - public void testSetCellRangeAddresswithSingleRange() throws IOException { + void testSetCellRangeAddresswithSingleRange() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { final Sheet sheet = wb.createSheet("S1"); final SheetConditionalFormatting cf = sheet.getSheetConditionalFormatting(); @@ -1256,7 +1256,7 @@ public abstract class BaseTestConditiona } @Test - public void testSetCellRangeAddressWithMultipleRanges() throws IOException { + void testSetCellRangeAddressWithMultipleRanges() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { final Sheet sheet = wb.createSheet("S1"); final SheetConditionalFormatting cf = sheet.getSheetConditionalFormatting(); @@ -1289,7 +1289,7 @@ public abstract class BaseTestConditiona } @Test - public void testSetCellRangeAddressWithNullRanges() throws IOException { + void testSetCellRangeAddressWithNullRanges() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { final Sheet sheet = wb.createSheet("S1"); final SheetConditionalFormatting cf = sheet.getSheetConditionalFormatting(); @@ -1307,7 +1307,7 @@ public abstract class BaseTestConditiona @Test - public void test52122() throws IOException { + void test52122() throws IOException { try (Workbook workbook = _testDataProvider.createWorkbook()) { Sheet sheet = workbook.createSheet("Conditional Formatting Test"); sheet.setColumnWidth(0, 256 * 10); Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestDataFormat.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestDataFormat.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestDataFormat.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestDataFormat.java Fri Jan 8 23:50:02 2021 @@ -79,7 +79,7 @@ public abstract class BaseTestDataFormat * [Bug 49928] formatCellValue returns incorrect value for \u00a3 formatted cells */ @Test - public void test49928() throws IOException { + void test49928() throws IOException { String fileName = "49928.xls" + (getClass().getName().contains("xssf") ? "x" : ""); try (Workbook wb = _testDataProvider.openSampleWorkbook(fileName)) { DataFormatter df = new DataFormatter(); @@ -118,7 +118,7 @@ public abstract class BaseTestDataFormat } @Test - public void testReadbackFormat() throws IOException { + void testReadbackFormat() throws IOException { readbackFormat("built-in format", "0.00"); readbackFormat("overridden built-in format", POUND_FMT); @@ -140,7 +140,7 @@ public abstract class BaseTestDataFormat * [Bug 58532] Handle formats that go numnum, numK, numM etc */ @Test - public void test58532() throws IOException { + void test58532() throws IOException { String fileName = "FormatKM.xls" + (getClass().getName().contains("xssf") ? "x" : ""); try (Workbook wb = _testDataProvider.openSampleWorkbook(fileName)) { Sheet s = wb.getSheetAt(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestDataValidation.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestDataValidation.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestDataValidation.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestDataValidation.java Fri Jan 8 23:50:02 2021 @@ -465,7 +465,7 @@ public abstract class BaseTestDataValida } @Test - public void testDataValidation() throws Exception { + void testDataValidation() throws Exception { log("\nTest no. 2 - Test Excel's Data validation mechanism"); Workbook wb = _testDataProvider.createWorkbook(); WorkbookFormatter wf = new WorkbookFormatter(wb); Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java Fri Jan 8 23:50:02 2021 @@ -47,7 +47,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testSimpleArithmetic() throws IOException { + void testSimpleArithmetic() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); Sheet s = wb.createSheet(); Row r = s.createRow(0); @@ -72,7 +72,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testSumCount() throws IOException { + void testSumCount() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); Sheet s = wb.createSheet(); Row r = s.createRow(0); @@ -117,7 +117,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testSharedFormulas() throws IOException { + void testSharedFormulas() throws IOException { String fileName = "shared_formulas.xls" + (getClass().getName().contains("xssf") ? "x" : ""); try (Workbook wb = _testDataProvider.openSampleWorkbook(fileName)) { @@ -148,7 +148,7 @@ public abstract class BaseTestFormulaEva * Test creation / evaluation of formulas with sheet-level names */ @Test - public void testSheetLevelFormulas() throws IOException { + void testSheetLevelFormulas() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); Row row; @@ -184,7 +184,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testFullColumnRefs() throws IOException { + void testFullColumnRefs() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); Sheet sheet = wb.createSheet("Sheet1"); Row row = sheet.createRow(0); @@ -218,7 +218,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testRepeatedEvaluation() throws IOException { + void testRepeatedEvaluation() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator(); Sheet sheet = wb.createSheet("Sheet1"); @@ -271,7 +271,7 @@ public abstract class BaseTestFormulaEva * is <code>null</code> or blank. */ @Test - public void testEvaluateBlank() throws IOException { + void testEvaluateBlank() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator(); assertNull(fe.evaluate(null)); @@ -285,7 +285,7 @@ public abstract class BaseTestFormulaEva * Test for bug due to attempt to convert a cached formula error result to a boolean */ @Test - public void testUpdateCachedFormulaResultFromErrorToNumber_bug46479() throws IOException { + void testUpdateCachedFormulaResultFromErrorToNumber_bug46479() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("Sheet1"); Row row = sheet.createRow(0); @@ -312,7 +312,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testRounding_bug51339() throws IOException { + void testRounding_bug51339() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); Sheet sheet = wb.createSheet("Sheet1"); Row row = sheet.createRow(0); @@ -345,7 +345,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug61148() throws IOException { + void testBug61148() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { final Cell cell = wb.createSheet().createRow(0).createCell(0); cell.setCellFormula("1+2"); @@ -362,7 +362,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testMultisheetFormulaEval() throws IOException { + void testMultisheetFormulaEval() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet1 = wb.createSheet("Sheet1"); Sheet sheet2 = wb.createSheet("Sheet2"); @@ -403,7 +403,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug55843() throws IOException { + void testBug55843() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("test"); Row row = sheet.createRow(0); @@ -425,7 +425,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug55843a() throws IOException { + void testBug55843a() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("test"); Row row = sheet.createRow(0); @@ -447,7 +447,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug55843b() throws IOException { + void testBug55843b() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("test"); Row row = sheet.createRow(0); @@ -470,7 +470,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug55843c() throws IOException { + void testBug55843c() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("test"); Row row = sheet.createRow(0); @@ -487,7 +487,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug55843d() throws IOException { + void testBug55843d() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("test"); Row row = sheet.createRow(0); @@ -504,7 +504,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug55843e() throws IOException { + void testBug55843e() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("test"); Row row = sheet.createRow(0); @@ -521,7 +521,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug55843f() throws IOException { + void testBug55843f() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("test"); Row row = sheet.createRow(0); @@ -538,7 +538,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug56655() throws IOException { + void testBug56655() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); @@ -555,7 +555,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug56655a() throws IOException { + void testBug56655a() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); @@ -601,7 +601,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testBug61532() throws IOException { + void testBug61532() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { final Cell cell = wb.createSheet().createRow(0).createCell(0); cell.setCellFormula("1+2"); @@ -628,7 +628,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testFormulaEvaluatorEvaluateSimpleFormulaCell() throws Exception { + void testFormulaEvaluatorEvaluateSimpleFormulaCell() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { final Row row = wb.createSheet().createRow(0); final Cell a1 = row.createCell(0, CellType.NUMERIC); @@ -654,7 +654,7 @@ public abstract class BaseTestFormulaEva } @Test - public void testFormulaEvaluatorEvaluateVlookupFormulaCell() throws Exception { + void testFormulaEvaluatorEvaluateVlookupFormulaCell() throws Exception { try (Workbook wb = _testDataProvider.createWorkbook()) { final Sheet mainSheet = wb.createSheet("main"); final Sheet otherSheet = wb.createSheet("other"); @@ -701,7 +701,7 @@ public abstract class BaseTestFormulaEva // setting an evaluation of function arguments with the intersect operator (space) // see https://bz.apache.org/bugzilla/show_bug.cgi?id=60980 @Test - public void testIntersectionInFunctionArgs_60980() throws IOException { + void testIntersectionInFunctionArgs_60980() throws IOException { Workbook wb = _testDataProvider.createWorkbook(); FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator(); --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org For additional commands, e-mail: commits-h...@poi.apache.org
