Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java Sat Jan 9 00:46:52 2021 @@ -395,7 +395,7 @@ public class TestSignatureInfo { } @Test - public void testSignSpreadsheet() throws Exception { + void testSignSpreadsheet() throws Exception { String testFile = "hello-world-unsigned.xlsx"; try (OPCPackage pkg = OPCPackage.open(copy(testdata.getFile(testFile)), PackageAccess.READ_WRITE)) { sign(pkg); @@ -412,7 +412,7 @@ public class TestSignatureInfo { } @Test - public void testManipulation() throws Exception { + void testManipulation() throws Exception { // sign & validate String testFile = "hello-world-unsigned.xlsx"; try (OPCPackage pkg = OPCPackage.open(copy(testdata.getFile(testFile)), PackageAccess.READ_WRITE)) { @@ -439,7 +439,7 @@ public class TestSignatureInfo { } @Test - public void testSignSpreadsheetWithSignatureInfo() throws Exception { + void testSignSpreadsheetWithSignatureInfo() throws Exception { initKeyPair(); String testFile = "hello-world-unsigned.xlsx"; try (OPCPackage pkg = OPCPackage.open(copy(testdata.getFile(testFile)), PackageAccess.READ_WRITE)) { @@ -462,7 +462,7 @@ public class TestSignatureInfo { } @Test - public void testSignEnvelopingDocument() throws Exception { + void testSignEnvelopingDocument() throws Exception { String testFile = "hello-world-unsigned.xlsx"; File sigCopy = testdata.getFile(testFile); ByteArrayOutputStream bos = new ByteArrayOutputStream(50000); @@ -662,7 +662,7 @@ public class TestSignatureInfo { } @Test - public void testCertChain() throws Exception { + void testCertChain() throws Exception { final boolean isIBM = System.getProperty("java.vendor").contains("IBM"); KeyStore keystore = KeyStore.getInstance("PKCS12"); @@ -711,7 +711,7 @@ public class TestSignatureInfo { } @Test - public void testNonSha1() throws Exception { + void testNonSha1() throws Exception { String testFile = "hello-world-unsigned.xlsx"; initKeyPair(); @@ -764,7 +764,7 @@ public class TestSignatureInfo { } @Test - public void testMultiSign() throws Exception { + void testMultiSign() throws Exception { cal = LocaleUtil.getLocaleCalendar(LocaleUtil.TIMEZONE_UTC); cal.clear(); cal.setTimeZone(LocaleUtil.TIMEZONE_UTC); @@ -846,7 +846,7 @@ public class TestSignatureInfo { } @Test - public void testRetrieveCertificate() throws InvalidFormatException, IOException { + void testRetrieveCertificate() throws InvalidFormatException, IOException { SignatureConfig sic = new SignatureConfig(); final File file = testdata.getFile("PPT2016withComment.pptx"); try (final OPCPackage pkg = OPCPackage.open(file, PackageAccess.READ)) { @@ -871,7 +871,7 @@ public class TestSignatureInfo { } @Test - public void testSignatureImage() throws Exception { + void testSignatureImage() throws Exception { initKeyPair(); List<Supplier<SignatureLine>> lines = Arrays.asList(XSSFSignatureLine::new, XWPFSignatureLine::new);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestAgileEncryptionParameters.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestAgileEncryptionParameters.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestAgileEncryptionParameters.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestAgileEncryptionParameters.java Sat Jan 9 00:46:52 2021 @@ -75,7 +75,7 @@ public class TestAgileEncryptionParamete @ParameterizedTest @MethodSource("data") - public void testAgileEncryptionModes(CipherAlgorithm ca, HashAlgorithm ha, ChainingMode cm) throws Exception { + void testAgileEncryptionModes(CipherAlgorithm ca, HashAlgorithm ha, ChainingMode cm) throws Exception { int maxKeyLen = Cipher.getMaxAllowedKeyLength(ca.jceId); assumeTrue(maxKeyLen >= ca.defaultKeySize, "Please install JCE Unlimited Strength Jurisdiction Policy files"); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java Sat Jan 9 00:46:52 2021 @@ -153,7 +153,7 @@ public class TestDecryptor { } @Test - public void test58616() throws IOException, GeneralSecurityException { + void test58616() throws IOException, GeneralSecurityException { try (InputStream is = POIDataSamples.getSpreadSheetInstance().openResourceAsStream("58616.xlsx"); POIFSFileSystem pfs = new POIFSFileSystem(is)) { EncryptionInfo info = new EncryptionInfo(pfs); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptionInfo.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptionInfo.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptionInfo.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptionInfo.java Sat Jan 9 00:46:52 2021 @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; public class TestEncryptionInfo { @Test - public void testEncryptionInfo() throws IOException { + void testEncryptionInfo() throws IOException { POIFSFileSystem fs = new POIFSFileSystem(POIDataSamples.getPOIFSInstance().openResourceAsStream("protect.xlsx")); EncryptionInfo info = new EncryptionInfo(fs); @@ -49,7 +49,7 @@ public class TestEncryptionInfo { } @Test - public void testEncryptionInfoSHA512() throws Exception { + void testEncryptionInfoSHA512() throws Exception { POIFSFileSystem fs = new POIFSFileSystem(POIDataSamples.getPOIFSInstance().openResourceAsStream("protected_sha512.xlsx")); EncryptionInfo info = new EncryptionInfo(fs); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/draw/TestDrawPictureShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/draw/TestDrawPictureShape.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/draw/TestDrawPictureShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/draw/TestDrawPictureShape.java Sat Jan 9 00:46:52 2021 @@ -64,18 +64,18 @@ public class TestDrawPictureShape { } @Test - public void testResizeHSLF() throws IOException { + void testResizeHSLF() throws IOException { assumeFalse(xslfOnly); testResize("pictures.ppt"); } @Test - public void testResizeXSLF() throws IOException { + void testResizeXSLF() throws IOException { testResize("shapes.pptx"); } - public void testResize(String file) throws IOException { + void testResize(String file) throws IOException { SlideShow<?,?> ss = openSampleDocument(file); Slide<?,?> slide = ss.getSlides().get(0); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/TestWorkbookFactory.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/TestWorkbookFactory.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/TestWorkbookFactory.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/TestWorkbookFactory.java Sat Jan 9 00:46:52 2021 @@ -105,7 +105,7 @@ public final class TestWorkbookFactory { } @Test - public void testCreateNative() throws Exception { + void testCreateNative() throws Exception { // POIFS -> hssf try (Workbook wb = WorkbookFactory.create( new POIFSFileSystem(HSSFTestDataSamples.openSampleFileStream(xls)) @@ -132,7 +132,7 @@ public final class TestWorkbookFactory { } @Test - public void testCreateReadOnly() throws Exception { + void testCreateReadOnly() throws Exception { // POIFS -> hssf try (Workbook wb = WorkbookFactory.create(HSSFTestDataSamples.getSampleFile(xls), null, true)) { assertNotNull(wb); @@ -154,7 +154,7 @@ public final class TestWorkbookFactory { * InputStream, then creating what's required. */ @Test - public void testCreateGeneric() throws Exception { + void testCreateGeneric() throws Exception { // InputStream -> either try (Workbook wb = WorkbookFactory.create(HSSFTestDataSamples.openSampleFileStream(xls))) { assertNotNull(wb); @@ -208,7 +208,7 @@ public final class TestWorkbookFactory { */ @ParameterizedTest @MethodSource("workbookPass") - public void testCreateWithPasswordFromStream(String file, String pass, boolean fails, Class<? extends Workbook> clazz) throws Exception { + void testCreateWithPasswordFromStream(String file, String pass, boolean fails, Class<? extends Workbook> clazz) throws Exception { try (InputStream is = HSSFTestDataSamples.openSampleFileStream(file)) { if (fails) { assertThrows(EncryptedDocumentException.class, () -> WorkbookFactory.create(is, pass), @@ -227,7 +227,7 @@ public final class TestWorkbookFactory { */ @ParameterizedTest @MethodSource("workbookPass") - public void testCreateWithPasswordFromFile(String fileName, String pass, boolean fails, Class<? extends Workbook> clazz) throws Exception { + void testCreateWithPasswordFromFile(String fileName, String pass, boolean fails, Class<? extends Workbook> clazz) throws Exception { File file = HSSFTestDataSamples.getSampleFile(fileName); if (fails) { assertThrows(EncryptedDocumentException.class, () -> WorkbookFactory.create(file, pass), @@ -245,7 +245,7 @@ public final class TestWorkbookFactory { * Check that a helpful exception is given on an empty input stream */ @Test - public void testEmptyInputStream() { + void testEmptyInputStream() { InputStream emptyStream = new ByteArrayInputStream(new byte[0]); assertThrows(EmptyFileException.class, () -> WorkbookFactory.create(emptyStream)); } @@ -254,7 +254,7 @@ public final class TestWorkbookFactory { * Check that a helpful exception is given on an empty file */ @Test - public void testEmptyFile() throws Exception { + void testEmptyFile() throws Exception { File emptyFile = TempFile.createTempFile("empty", ".poi"); assertThrows(EmptyFileException.class, () -> WorkbookFactory.create(emptyFile), "Shouldn't be able to create for an empty file"); @@ -265,7 +265,7 @@ public final class TestWorkbookFactory { * Check that a helpful exception is raised on a non-existing file */ @Test - public void testNonExistingFile() { + void testNonExistingFile() { File nonExistingFile = new File("notExistingFile"); assertFalse(nonExistingFile.exists()); assertThrows(FileNotFoundException.class, () -> WorkbookFactory.create(nonExistingFile, "password", true)); @@ -276,7 +276,7 @@ public final class TestWorkbookFactory { * to work for sub-classes of File too, eg JFileChooser */ @Test - public void testFileSubclass() throws Exception { + void testFileSubclass() throws Exception { File normalXLS = HSSFTestDataSamples.getSampleFile(xls); File normalXLSX = HSSFTestDataSamples.getSampleFile(xlsx); File altXLS = new TestFile(normalXLS.getAbsolutePath()); @@ -307,7 +307,7 @@ public final class TestWorkbookFactory { * Check that the overloaded file methods which take passwords work properly */ @Test - public void testCreateEmpty() throws Exception { + void testCreateEmpty() throws Exception { Workbook wb = WorkbookFactory.create(false); assertTrue(wb instanceof HSSFWorkbook); closeOrRevert(wb); @@ -319,7 +319,7 @@ public final class TestWorkbookFactory { @Test @SuppressForbidden("test code") - public void testOpenManyHSSF() throws Exception { + void testOpenManyHSSF() throws Exception { final int size = 1000; ExecutorService executorService = Executors.newFixedThreadPool(10); ArrayList<Future<Boolean>> futures = new ArrayList<>(size); @@ -332,7 +332,7 @@ public final class TestWorkbookFactory { } @Test - public void testInvalidFormatException() throws IOException { + void testInvalidFormatException() throws IOException { String filename = "OPCCompliance_DerivedPartNameFAIL.docx"; try (InputStream is = POIDataSamples.getOpenXML4JInstance().openResourceAsStream(filename)) { assertThrows(IOException.class, () -> WorkbookFactory.create(is)); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java Sat Jan 9 00:46:52 2021 @@ -119,7 +119,7 @@ public class TestEmbeddedExtractor { @Test - public void testNPE() throws IOException { + void testNPE() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("angelo.edu_content_files_19555-nsse-2011-multiyear-benchmark.xls"); EmbeddedExtractor ee = new EmbeddedExtractor(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/format/TestCellFormatPart.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/format/TestCellFormatPart.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/format/TestCellFormatPart.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/format/TestCellFormatPart.java Sat Jan 9 00:46:52 2021 @@ -85,7 +85,7 @@ public class TestCellFormatPart { } @Test - public void testGeneralFormat() throws IOException { + void testGeneralFormat() throws IOException { runFormatTests("GeneralFormatTests.xlsx", cell -> { assertNotNull(cell); switch (CellFormat.ultimateType(cell)) { @@ -100,12 +100,12 @@ public class TestCellFormatPart { } @Test - public void testNumberFormat() throws IOException { + void testNumberFormat() throws IOException { runFormatTests("NumberFormatTests.xlsx", Cell::getNumericCellValue); } @Test - public void testNumberApproxFormat() throws IOException { + void testNumberApproxFormat() throws IOException { runFormatTests("NumberFormatApproxTests.xlsx", new CellValue() { @Override public Object getValue(Cell cell) { @@ -125,7 +125,7 @@ public class TestCellFormatPart { } @Test - public void testDateFormat() throws IOException { + void testDateFormat() throws IOException { TimeZone tz = LocaleUtil.getUserTimeZone(); LocaleUtil.setUserTimeZone(TimeZone.getTimeZone("CET")); try { @@ -136,19 +136,19 @@ public class TestCellFormatPart { } @Test - public void testElapsedFormat() throws IOException { + void testElapsedFormat() throws IOException { runFormatTests("ElapsedFormatTests.xlsx", Cell::getNumericCellValue); } @Test - public void testTextFormat() throws IOException { + void testTextFormat() throws IOException { runFormatTests("TextFormatTests.xlsx", cell -> (CellFormat.ultimateType(cell) == CellType.BOOLEAN) ? cell.getBooleanCellValue() : cell.getStringCellValue() ); } @Test - public void testConditions() throws IOException { + void testConditions() throws IOException { runFormatTests("FormatConditionTests.xlsx", Cell::getNumericCellValue); } Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestFormulaParser.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestFormulaParser.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestFormulaParser.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestFormulaParser.java Sat Jan 9 00:46:52 2021 @@ -49,7 +49,7 @@ import org.junit.jupiter.api.Test; public class TestFormulaParser { @Test - public void testHSSFFailsForOver65536() { + void testHSSFFailsForOver65536() { FormulaParsingWorkbook workbook = HSSFEvaluationWorkbook.create(new HSSFWorkbook()); assertThrows(FormulaParseException.class, () -> FormulaParser.parse("Sheet1!1:65537", workbook, FormulaType.CELL, 0)); @@ -73,17 +73,17 @@ public class TestFormulaParser { } @Test - public void testHSSFPassCase() { + void testHSSFPassCase() { checkHSSFFormula("Sheet1!1:65536"); } @Test - public void testXSSFWorksForOver65536() { + void testXSSFWorksForOver65536() { checkXSSFFormula("Sheet1!1:65537"); } @Test - public void testXSSFFailCase() { + void testXSSFFailCase() { FormulaParsingWorkbook workbook = XSSFEvaluationWorkbook.create(new XSSFWorkbook()); assertThrows(FormulaParseException.class, () -> FormulaParser.parse("Sheet1!1:1048577", workbook, FormulaType.CELL, 0), "one more than max rows"); @@ -91,7 +91,7 @@ public class TestFormulaParser { // copied from org.apache.poi.hssf.model.TestFormulaParser @Test - public void testMacroFunction() throws Exception { + void testMacroFunction() throws Exception { // testNames.xlsm contains a VB function called 'myFunc' final String testFile = "testNames.xlsm"; try (XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook(testFile)) { @@ -144,7 +144,7 @@ public class TestFormulaParser { } @Test - public void testParserErrors() throws Exception { + void testParserErrors() throws Exception { try (XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook("testNames.xlsm")) { XSSFEvaluationWorkbook workbook = XSSFEvaluationWorkbook.create(wb); @@ -172,7 +172,7 @@ public class TestFormulaParser { // trivial case for bug 60219: FormulaParser can't parse external references when sheet name is quoted @Test - public void testParseExternalReferencesWithUnquotedSheetName() throws Exception { + void testParseExternalReferencesWithUnquotedSheetName() throws Exception { XSSFWorkbook wb = new XSSFWorkbook(); XSSFEvaluationWorkbook fpwb = XSSFEvaluationWorkbook.create(wb); Ptg[] ptgs = FormulaParser.parse("[1]Sheet1!A1", fpwb, FormulaType.CELL, -1); @@ -189,7 +189,7 @@ public class TestFormulaParser { // bug 60219: FormulaParser can't parse external references when sheet name is quoted @Test - public void testParseExternalReferencesWithQuotedSheetName() throws Exception { + void testParseExternalReferencesWithQuotedSheetName() throws Exception { XSSFWorkbook wb = new XSSFWorkbook(); XSSFEvaluationWorkbook fpwb = XSSFEvaluationWorkbook.create(wb); Ptg[] ptgs = FormulaParser.parse("'[1]Sheet 1'!A1", fpwb, FormulaType.CELL, -1); @@ -206,7 +206,7 @@ public class TestFormulaParser { // bug 60260 @Test - public void testUnicodeSheetName() { + void testUnicodeSheetName() { checkFormula("'Sheet\u30FB1'!A1:A6"); } } Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestStructuredReferences.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestStructuredReferences.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestStructuredReferences.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestStructuredReferences.java Sat Jan 9 00:46:52 2021 @@ -48,7 +48,7 @@ public class TestStructuredReferences { * Test the regular expression used in INDIRECT() evaluation to recognize structured references */ @Test - public void testTableExpressionSyntax() { + void testTableExpressionSyntax() { assertTrue(Table.isStructuredReference.matcher("abc[col1]").matches(), "Valid structured reference syntax didn't match expression"); assertTrue(Table.isStructuredReference.matcher("_abc[col1]").matches(), "Valid structured reference syntax didn't match expression"); assertTrue(Table.isStructuredReference.matcher("_[col1]").matches(), "Valid structured reference syntax didn't match expression"); @@ -62,7 +62,7 @@ public class TestStructuredReferences { } @Test - public void testTableFormulas() throws Exception { + void testTableFormulas() throws Exception { try (XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook("StructuredReferences.xlsx")) { final FormulaEvaluator eval = new XSSFFormulaEvaluator(wb); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java Sat Jan 9 00:46:52 2021 @@ -65,7 +65,7 @@ public class CountifsTests { * Basic call */ @Test - public void testCallFunction() { + void testCallFunction() { Sheet sheet = workbook.createSheet("test"); Row row1 = sheet.createRow(0); Cell cellA1 = row1.createCell(0, CellType.FORMULA); @@ -88,7 +88,7 @@ public class CountifsTests { * Test argument count check */ @Test - public void testCallFunction_invalidArgs() { + void testCallFunction_invalidArgs() { Sheet sheet = workbook.createSheet("test"); Row row1 = sheet.createRow(0); Cell cellA1 = row1.createCell(0, CellType.FORMULA); @@ -110,7 +110,7 @@ public class CountifsTests { * the bug returned the wrong count, this verifies the fix */ @Test - public void testBug56822() { + void testBug56822() { workbook = XSSFTestDataSamples.openSampleWorkbook("56822-Countifs.xlsx"); FormulaEvaluator evaluator = workbook.getCreationHelper().createFormulaEvaluator(); Cell cell = SheetUtil.getCell(workbook.getSheetAt(0), 0, 3); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestProper.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestProper.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestProper.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestProper.java Sat Jan 9 00:46:52 2021 @@ -40,7 +40,7 @@ public final class TestProper { private FormulaEvaluator evaluator; @Test - public void testValidHSSF() { + void testValidHSSF() { HSSFWorkbook wb = new HSSFWorkbook(); evaluator = new HSSFFormulaEvaluator(wb); @@ -48,7 +48,7 @@ public final class TestProper { } @Test - public void testValidXSSF() { + void testValidXSSF() { XSSFWorkbook wb = new XSSFWorkbook(); evaluator = new XSSFFormulaEvaluator(wb); @@ -99,7 +99,7 @@ public final class TestProper { } @Test - public void test() { + void test() { checkProper("", ""); checkProper("a", "A"); checkProper("abc", "Abc"); @@ -118,7 +118,7 @@ public final class TestProper { } @Test - public void testMicroBenchmark() { + void testMicroBenchmark() { ValueEval strArg = new StringEval("some longer text that needs a number of replacements to check for runtime of different implementations"); // long start = System.currentTimeMillis(); for(int i = 0;i < 300000;i++) { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestSumifsXSSF.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestSumifsXSSF.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestSumifsXSSF.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestSumifsXSSF.java Sat Jan 9 00:46:52 2021 @@ -39,7 +39,7 @@ public class TestSumifsXSSF { * handle null cell predicate */ @Test - public void testBug60858() throws IOException { + void testBug60858() throws IOException { try (Workbook wb = XSSFTestDataSamples.openSampleWorkbook("bug60858.xlsx")) { FormulaEvaluator fe = wb.getCreationHelper().createFormulaEvaluator(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java Sat Jan 9 00:46:52 2021 @@ -40,7 +40,7 @@ import org.junit.jupiter.api.Test; public class TestVlookup { @Test - public void testFullColumnAreaRef61841() throws IOException { + void testFullColumnAreaRef61841() throws IOException { try (Workbook wb = XSSFTestDataSamples.openSampleWorkbook("VLookupFullColumn.xlsx")) { FormulaEvaluator feval = wb.getCreationHelper().createFormulaEvaluator(); feval.evaluateAll(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/BaseTestXCell.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/BaseTestXCell.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/BaseTestXCell.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/BaseTestXCell.java Sat Jan 9 00:46:52 2021 @@ -45,7 +45,7 @@ public abstract class BaseTestXCell exte } @Test - public void testXmlEncoding() throws IOException { + void testXmlEncoding() throws IOException { Workbook wb1 = _testDataProvider.createWorkbook(); Sheet sh = wb1.createSheet(); Row row = sh.createRow(0); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java Sat Jan 9 00:46:52 2021 @@ -66,7 +66,7 @@ public class ConditionalFormattingEvalTe } @Test - public void testFormattingEvaluation() { + void testFormattingEvaluation() { sheet = wb.getSheet("Products1"); getRulesFor(12, 1); @@ -142,7 +142,7 @@ public class ConditionalFormattingEvalTe } @Test - public void testFormattingOnUndefinedCell() { + void testFormattingOnUndefinedCell() { wb = XSSFTestDataSamples.openSampleWorkbook("conditional_formatting_with_formula_on_second_sheet.xlsx"); formulaEval = new XSSFFormulaEvaluator(wb); cfe = new ConditionalFormattingEvaluator(wb, formulaEval); @@ -154,7 +154,7 @@ public class ConditionalFormattingEvalTe } @Test - public void testRepeatedEval() { + void testRepeatedEval() { wb = XSSFTestDataSamples.openSampleWorkbook("test_conditional_formatting.xlsx"); formulaEval = new XSSFFormulaEvaluator(wb); cfe = new ConditionalFormattingEvaluator(wb, formulaEval); @@ -167,7 +167,7 @@ public class ConditionalFormattingEvalTe } @Test - public void testCellValueIsWrongType() { + void testCellValueIsWrongType() { wb = XSSFTestDataSamples.openSampleWorkbook("conditional_formatting_cell_is.xlsx"); formulaEval = new XSSFFormulaEvaluator(wb); cfe = new ConditionalFormattingEvaluator(wb, formulaEval); @@ -178,7 +178,7 @@ public class ConditionalFormattingEvalTe } @Test - public void testRangeCondition() { + void testRangeCondition() { wb = XSSFTestDataSamples.openSampleWorkbook("conditional_formatting_multiple_ranges.xlsx"); formulaEval = new XSSFFormulaEvaluator(wb); cfe = new ConditionalFormattingEvaluator(wb, formulaEval); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestIdentifierManager.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestIdentifierManager.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestIdentifierManager.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestIdentifierManager.java Sat Jan 9 00:46:52 2021 @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; public class TestIdentifierManager { @Test - public void testBasic() + void testBasic() { IdentifierManager manager = new IdentifierManager(0L,100L); assertEquals(101L,manager.getRemainingIdentifiers()); @@ -39,7 +39,7 @@ public class TestIdentifierManager { } @Test - public void testLongLimits() { + void testLongLimits() { long min = IdentifierManager.MIN_ID; long max = IdentifierManager.MAX_ID; IdentifierManager manager = new IdentifierManager(min,max); @@ -53,7 +53,7 @@ public class TestIdentifierManager { } @Test - public void testReserve() { + void testReserve() { IdentifierManager manager1 = new IdentifierManager(10L, 30L); assertEquals(12L, manager1.reserve(12L)); long reserve = manager1.reserve(12L); @@ -73,7 +73,7 @@ public class TestIdentifierManager { } @Test - public void testReserveNew() { + void testReserveNew() { IdentifierManager manager = new IdentifierManager(10L,12L); assertSame(10L,manager.reserveNew()); assertSame(11L,manager.reserveNew()); @@ -82,7 +82,7 @@ public class TestIdentifierManager { } @Test - public void testRelease() { + void testRelease() { IdentifierManager manager = new IdentifierManager(10L,20L); assertEquals(10L,manager.reserve(10L)); assertEquals(11L,manager.reserve(11L)); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestNecessaryOOXMLClasses.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestNecessaryOOXMLClasses.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestNecessaryOOXMLClasses.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestNecessaryOOXMLClasses.java Sat Jan 9 00:46:52 2021 @@ -32,7 +32,7 @@ import org.openxmlformats.schemas.drawin public class TestNecessaryOOXMLClasses { @Test - public void testProblemClasses() { + void testProblemClasses() { CTXYAdjustHandle ctxyAdjustHandle = CTXYAdjustHandle.Factory.newInstance(); assertNotNull(ctxyAdjustHandle); CTPolarAdjustHandle ctPolarAdjustHandle = CTPolarAdjustHandle.Factory.newInstance(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestXDDFColor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestXDDFColor.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestXDDFColor.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestXDDFColor.java Sat Jan 9 00:46:52 2021 @@ -41,7 +41,7 @@ public class TestXDDFColor { private static final String XMLNS = "xmlns:a=\"http://schemas.openxmlformats.org/drawingml/2006/main\"/>"; @Test - public void testSchemeColor() throws IOException { + void testSchemeColor() throws IOException { try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFTheme theme = ppt.createSlide().getTheme(); @@ -72,7 +72,7 @@ public class TestXDDFColor { } @Test - public void testPreset() { + void testPreset() { CTColor xml = CTColor.Factory.newInstance(); xml.addNewPrstClr().setVal(STPresetColorVal.AQUAMARINE); XDDFColor color = XDDFColor.forColorContainer(xml); @@ -83,7 +83,7 @@ public class TestXDDFColor { } @Test - public void testSystemDefined() { + void testSystemDefined() { CTColor xml = CTColor.Factory.newInstance(); CTSystemColor sys = xml.addNewSysClr(); sys.setVal(STSystemColorVal.CAPTION_TEXT); @@ -99,7 +99,7 @@ public class TestXDDFColor { } @Test - public void testRgbBinary() { + void testRgbBinary() { CTColor xml = CTColor.Factory.newInstance(); CTSRgbColor color = xml.addNewSrgbClr(); byte[] bs = new byte[]{-1, -1, -1}; @@ -114,7 +114,7 @@ public class TestXDDFColor { } @Test - public void testRgbPercent() { + void testRgbPercent() { CTColor xml = CTColor.Factory.newInstance(); CTScRgbColor color = xml.addNewScrgbClr(); color.setR(0); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChart.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChart.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChart.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChart.java Sat Jan 9 00:46:52 2021 @@ -28,7 +28,7 @@ import org.openxmlformats.schemas.drawin public class TestXDDFChart { @Test - public void testConstruct() { + void testConstruct() { // minimal test to cause ooxml-lite to include all the classes in poi-ooxml-lite XDDFChart xddfChart = newXDDFChart(); @@ -37,7 +37,7 @@ public class TestXDDFChart { } @Test - public void testSetExternalId() { + void testSetExternalId() { XDDFChart xddfChart = newXDDFChart(); CTChartSpace ctChartSpace = xddfChart.getCTChartSpace(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java Sat Jan 9 00:46:52 2021 @@ -140,7 +140,7 @@ public class TestXDDFChartRemoveSeries { * This used to corrupt the workbook but the returned <code>List</code> is unmodifiable. */ @Test - public void testRemoveSeries0() { + void testRemoveSeries0() { procName = "testRemoveSeries0"; fileName = procName + ".xlsx"; @@ -157,7 +157,7 @@ public class TestXDDFChartRemoveSeries { * This will not corrupt the workbook. */ @Test - public void testBugFixRemoveSeries0() { + void testBugFixRemoveSeries0() { procName = "testBugFixRemoveSeries0"; fileName = procName + ".xlsx"; @@ -171,7 +171,7 @@ public class TestXDDFChartRemoveSeries { * This will not corrupt the workbook. */ @Test - public void testBugFixRemoveSeries1() { + void testBugFixRemoveSeries1() { procName = "testBugFixRemoveSeries1"; fileName = procName + ".xlsx"; @@ -183,7 +183,7 @@ public class TestXDDFChartRemoveSeries { * Do not remove any series from the chart. */ @Test - public void testDontRemoveSeries() { + void testDontRemoveSeries() { procName = "testDontRemoveSeries"; fileName = procName + ".xlsx"; } Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFDataSourcesFactory.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFDataSourcesFactory.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFDataSourcesFactory.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFDataSourcesFactory.java Sat Jan 9 00:46:52 2021 @@ -48,7 +48,7 @@ public class TestXDDFDataSourcesFactory }; @Test - public void testNumericArrayDataSource() { + void testNumericArrayDataSource() { Double[] doubles = new Double[]{1.0, 2.0, 3.0, 4.0, 5.0}; XDDFDataSource<Double> doubleDataSource = XDDFDataSourcesFactory.fromArray(doubles, null); assertTrue(doubleDataSource.isNumeric()); @@ -57,7 +57,7 @@ public class TestXDDFDataSourcesFactory } @Test - public void testStringArrayDataSource() { + void testStringArrayDataSource() { String[] strings = new String[]{"one", "two", "three", "four", "five"}; XDDFDataSource<String> stringDataSource = XDDFDataSourcesFactory.fromArray(strings, null); assertFalse(stringDataSource.isNumeric()); @@ -66,7 +66,7 @@ public class TestXDDFDataSourcesFactory } @Test - public void testNumericCellDataSource() { + void testNumericCellDataSource() { XSSFWorkbook wb = new XSSFWorkbook(); XSSFSheet sheet = (XSSFSheet) new SheetBuilder(wb, numericCells).build(); CellRangeAddress numCellRange = CellRangeAddress.valueOf("A2:E2"); @@ -81,7 +81,7 @@ public class TestXDDFDataSourcesFactory } @Test - public void testStringCellDataSource() { + void testStringCellDataSource() { XSSFWorkbook wb = new XSSFWorkbook(); XSSFSheet sheet = (XSSFSheet) new SheetBuilder(wb, stringCells).build(); CellRangeAddress numCellRange = CellRangeAddress.valueOf("A2:E2"); @@ -95,7 +95,7 @@ public class TestXDDFDataSourcesFactory } @Test - public void testMixedCellDataSource() { + void testMixedCellDataSource() { XSSFWorkbook wb = new XSSFWorkbook(); XSSFSheet sheet = (XSSFSheet) new SheetBuilder(wb, mixedCells).build(); CellRangeAddress mixedCellRange = CellRangeAddress.valueOf("A1:F1"); @@ -114,7 +114,7 @@ public class TestXDDFDataSourcesFactory } @Test - public void testIOBExceptionOnInvalidIndex() { + void testIOBExceptionOnInvalidIndex() { XSSFWorkbook wb = new XSSFWorkbook(); XSSFSheet sheet = (XSSFSheet) new SheetBuilder(wb, numericCells).build(); CellRangeAddress rangeAddress = CellRangeAddress.valueOf("A2:E2"); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextBodyProperties.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextBodyProperties.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextBodyProperties.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextBodyProperties.java Sat Jan 9 00:46:52 2021 @@ -29,7 +29,7 @@ import org.openxmlformats.schemas.drawin public class TestXDDFTextBodyProperties { @Test - public void testProperties() throws IOException { + void testProperties() throws IOException { XDDFTextBody text = new XDDFTextBody(null); text.initialize(); XDDFBodyProperties body = text.getBodyProperties(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextRun.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextRun.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextRun.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextRun.java Sat Jan 9 00:46:52 2021 @@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test; public class TestXDDFTextRun { @Test - public void testTextRunPropertiesInSlide() throws IOException { + void testTextRunPropertiesInSlide() throws IOException { try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); XSLFTextShape sh = slide.createAutoShape(); @@ -87,7 +87,7 @@ public class TestXDDFTextRun { } @Test - public void testTextRunPropertiesInSheet() throws IOException { + void testTextRunPropertiesInSheet() throws IOException { try (XSSFWorkbook wb = new XSSFWorkbook()) { XSSFSheet sheet = wb.createSheet(); XSSFDrawing drawing = sheet.createDrawingPatriarch(); @@ -139,7 +139,7 @@ public class TestXDDFTextRun { } @Test - public void testDefaultRunProperties() throws IOException { + void testDefaultRunProperties() throws IOException { // bug #63290 POIDataSamples pds = POIDataSamples.getSlideShowInstance(); try (InputStream is = pds.openResourceAsStream("bug63290.pptx"); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java Sat Jan 9 00:46:52 2021 @@ -50,7 +50,7 @@ public class TestXDGFVisioExtractor { } @Test - public void testGetSimpleText() throws IOException { + void testGetSimpleText() throws IOException { new XDGFVisioExtractor(xml).close(); new XDGFVisioExtractor(pkg).close(); @@ -68,7 +68,7 @@ public class TestXDGFVisioExtractor { //the point of this is to trigger the addition of //some common visio classes -- ConnectsType @Test - public void testVisioConnects() throws IOException { + void testVisioConnects() throws IOException { InputStream is = SAMPLES.openResourceAsStream("60489.vsdx"); XmlVisioDocument document = new XmlVisioDocument(is); is.close(); @@ -86,7 +86,7 @@ public class TestXDGFVisioExtractor { * at org.apache.poi.xdgf.usermodel.section.geometry.GeometryRowFactory.load */ @Test - public void testPolylineTo() throws IOException { + void testPolylineTo() throws IOException { InputStream is = SAMPLES.openResourceAsStream("60973.vsdx"); XmlVisioDocument document = new XmlVisioDocument(is); is.close(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/CombinedIteratorTest.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/CombinedIteratorTest.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/CombinedIteratorTest.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/CombinedIteratorTest.java Sat Jan 9 00:46:52 2021 @@ -42,7 +42,7 @@ public class CombinedIteratorTest { } @Test - public void testNullMaster() { + void testNullMaster() { SortedMap<Long, String> base = new TreeMap<>(); base.put(1L, "B1"); @@ -54,7 +54,7 @@ public class CombinedIteratorTest { } @Test - public void testNoMatchesBaseFirst() { + void testNoMatchesBaseFirst() { SortedMap<Long, String> base = new TreeMap<>(); base.put(1L, "B1"); @@ -71,7 +71,7 @@ public class CombinedIteratorTest { } @Test - public void testNoMatchesMasterFirst() { + void testNoMatchesMasterFirst() { SortedMap<Long, String> base = new TreeMap<>(); base.put(4L, "B4"); @@ -88,7 +88,7 @@ public class CombinedIteratorTest { } @Test - public void testInterleaved1() { + void testInterleaved1() { SortedMap<Long, String> base = new TreeMap<>(); base.put(1L, "B1"); @@ -105,7 +105,7 @@ public class CombinedIteratorTest { } @Test - public void testInterleaved2() { + void testInterleaved2() { SortedMap<Long, String> base = new TreeMap<>(); base.put(1L, "B1"); @@ -124,7 +124,7 @@ public class CombinedIteratorTest { } @Test - public void testAllMatching() { + void testAllMatching() { SortedMap<Long, String> base = new TreeMap<>(); base.put(1L, "B1"); @@ -141,7 +141,7 @@ public class CombinedIteratorTest { } @Test - public void testAllMatching2() { + void testAllMatching2() { SortedMap<Long, String> base = new TreeMap<>(); base.put(1L, "B1"); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestNecessaryOOXMLClasses.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestNecessaryOOXMLClasses.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestNecessaryOOXMLClasses.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestNecessaryOOXMLClasses.java Sat Jan 9 00:46:52 2021 @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; public class TestNecessaryOOXMLClasses { @Test - public void testProblemClasses() { + void testProblemClasses() { List<Supplier<XmlObject>> sup = Arrays.asList( org.openxmlformats.schemas.presentationml.x2006.main.STPlaceholderSize.Factory::newInstance, org.openxmlformats.schemas.presentationml.x2006.main.CTHeaderFooter.Factory::newInstance Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java Sat Jan 9 00:46:52 2021 @@ -558,7 +558,7 @@ public class TestXSLFBugs { * that image10.foo isn't between image1.foo and image2.foo */ @Test - public void test57552() throws Exception { + void test57552() throws Exception { XMLSlideShow ss = new XMLSlideShow(); for (String s : new String[]{"Slide1", "Slide2"}) { ss.createSlide().createTextBox().setText(s); @@ -888,7 +888,7 @@ public class TestXSLFBugs { } @Test - public void test60810() throws IOException { + void test60810() throws IOException { XMLSlideShow ppt = openSampleDocument("60810.pptx"); for (XSLFSlide slide : ppt.getSlides()) { XSLFNotes notesSlide = ppt.getNotesSlide(slide); @@ -899,7 +899,7 @@ public class TestXSLFBugs { } @Test - public void test60042() throws IOException { + void test60042() throws IOException { try (XMLSlideShow ppt = openSampleDocument("60042.pptx")) { ppt.removeSlide(0); ppt.createSlide(); @@ -908,7 +908,7 @@ public class TestXSLFBugs { } @Test - public void test61515() throws IOException { + void test61515() throws IOException { try (XMLSlideShow ppt = openSampleDocument("61515.pptx")) { ppt.removeSlide(0); assertEquals(1, ppt.createSlide().getRelations().size()); @@ -921,7 +921,7 @@ public class TestXSLFBugs { } @Test - public void testAptia() throws IOException { + void testAptia() throws IOException { try (XMLSlideShow ppt = openSampleDocument("aptia.pptx"); XMLSlideShow saved = XSLFTestDataSamples.writeOutAndReadBack(ppt)) { assertEquals(ppt.getSlides().size(), saved.getSlides().size()); @@ -930,7 +930,7 @@ public class TestXSLFBugs { @Disabled @Test - public void testDivinoRevelado() throws IOException { + void testDivinoRevelado() throws IOException { try (XMLSlideShow ppt = openSampleDocument("Divino_Revelado.pptx"); XMLSlideShow saved = XSLFTestDataSamples.writeOutAndReadBack(ppt)) { assertEquals(ppt.getSlides().size(), saved.getSlides().size()); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java Sat Jan 9 00:46:52 2021 @@ -57,7 +57,7 @@ public class TestXSLFSlideShow { } @Test - public void testContainsMainContentType() throws Exception { + void testContainsMainContentType() throws Exception { boolean found = false; for(PackagePart part : pack.getParts()) { if(part.getContentType().equals(XSLFRelation.MAIN.getContentType())) { @@ -68,7 +68,7 @@ public class TestXSLFSlideShow { } @Test - public void testOpen() throws IOException, OpenXML4JException, XmlException { + void testOpen() throws IOException, OpenXML4JException, XmlException { // With the finalized uri, should be fine XSLFSlideShow xml = new XSLFSlideShow(pack); // Check the core @@ -82,7 +82,7 @@ public class TestXSLFSlideShow { } @Test - public void testSlideBasics() throws IOException, OpenXML4JException, XmlException { + void testSlideBasics() throws IOException, OpenXML4JException, XmlException { XSLFSlideShow xml = new XSLFSlideShow(pack); // Should have 1 master @@ -119,7 +119,7 @@ public class TestXSLFSlideShow { } @Test - public void testMetadataBasics() throws IOException, OpenXML4JException, XmlException { + void testMetadataBasics() throws IOException, OpenXML4JException, XmlException { XSLFSlideShow xml = new XSLFSlideShow(pack); assertNotNull(xml.getProperties().getCoreProperties()); @@ -138,7 +138,7 @@ public class TestXSLFSlideShow { } @Test - public void testMasterBackground() throws IOException { + void testMasterBackground() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFBackground b = ppt.getSlideMasters().get(0).getBackground(); b.setFillColor(Color.RED); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java Sat Jan 9 00:46:52 2021 @@ -46,7 +46,7 @@ public class TestXSLFPowerPointExtractor * Get text out of the simple file */ @Test - public void testGetSimpleText() throws IOException { + void testGetSimpleText() throws IOException { try (XMLSlideShow xmlA = openPPTX("sample.pptx"); SlideShowExtractor<XSLFShape, XSLFTextParagraph> extractor = new SlideShowExtractor<>(xmlA)) { @@ -158,7 +158,7 @@ public class TestXSLFPowerPointExtractor } @Test - public void testGetComments() throws IOException { + void testGetComments() throws IOException { try (XMLSlideShow xml = openPPTX("45545_Comment.pptx"); SlideShowExtractor<XSLFShape, XSLFTextParagraph> extractor = new SlideShowExtractor<>(xml)) { extractor.setCommentsByDefault(true); @@ -176,7 +176,7 @@ public class TestXSLFPowerPointExtractor } @Test - public void testGetMasterText() throws Exception { + void testGetMasterText() throws Exception { try (XMLSlideShow xml = openPPTX("WithMaster.pptx"); SlideShowExtractor<XSLFShape, XSLFTextParagraph> extractor = new SlideShowExtractor<>(xml)) { extractor.setSlidesByDefault(true); @@ -213,7 +213,7 @@ public class TestXSLFPowerPointExtractor } @Test - public void testTable() throws Exception { + void testTable() throws Exception { try (XMLSlideShow xml = openPPTX("present1.pptx"); SlideShowExtractor<XSLFShape, XSLFTextParagraph> extractor = new SlideShowExtractor<>(xml)) { @@ -231,7 +231,7 @@ public class TestXSLFPowerPointExtractor * well as from the normal file */ @Test - public void testDifferentSubformats() throws Exception { + void testDifferentSubformats() throws Exception { String[] extensions = new String[] { "pptx", "pptm", "ppsm", "ppsx", "thmx", // "xps" - Doesn't have a core document @@ -260,7 +260,7 @@ public class TestXSLFPowerPointExtractor } @Test - public void test45541() throws IOException { + void test45541() throws IOException { // extract text from a powerpoint that has a header in the notes-element final File headerFile = slTests.getFile("45541_Header.pptx"); //noinspection rawtypes Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java Sat Jan 9 00:46:52 2021 @@ -56,7 +56,7 @@ public class TestXMLSlideShow extends Ba } @Test - public void testContainsMainContentType() throws Exception { + void testContainsMainContentType() throws Exception { boolean found = false; for (PackagePart part : pack.getParts()) { if (part.getContentType().equals(XSLFRelation.MAIN.getContentType())) { @@ -67,7 +67,7 @@ public class TestXMLSlideShow extends Ba } @Test - public void testOpen() throws Exception { + void testOpen() throws Exception { // With the finalised uri, should be fine XMLSlideShow xml = new XMLSlideShow(pack); // Check the core @@ -82,7 +82,7 @@ public class TestXMLSlideShow extends Ba @SuppressWarnings("deprecation") @Test - public void testSlideBasics() throws IOException { + void testSlideBasics() throws IOException { XMLSlideShow xml = new XMLSlideShow(pack); // Should have 1 master @@ -126,7 +126,7 @@ public class TestXMLSlideShow extends Ba } @Test - public void testMetadataBasics() throws IOException { + void testMetadataBasics() throws IOException { XMLSlideShow xml = new XMLSlideShow(pack); assertNotNull(xml.getProperties().getCoreProperties()); @@ -143,7 +143,7 @@ public class TestXMLSlideShow extends Ba } @Test - public void testComments() throws Exception { + void testComments() throws Exception { // Default sample file has none XMLSlideShow xml = new XMLSlideShow(pack); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFAutoShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFAutoShape.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFAutoShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFAutoShape.java Sat Jan 9 00:46:52 2021 @@ -38,7 +38,7 @@ import org.openxmlformats.schemas.drawin public class TestXSLFAutoShape { @Test - public void testTextBodyProperies() throws IOException { + void testTextBodyProperies() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide = ppt.createSlide(); @@ -113,7 +113,7 @@ public class TestXSLFAutoShape { } @Test - public void testTextParagraph() throws IOException { + void testTextParagraph() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide = ppt.createSlide(); assertTrue(slide.getShapes().isEmpty()); @@ -216,7 +216,7 @@ public class TestXSLFAutoShape { } @Test - public void testTextRun() throws IOException { + void testTextRun() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide = ppt.createSlide(); @@ -290,7 +290,7 @@ public class TestXSLFAutoShape { } @Test - public void testShapeType() throws IOException { + void testShapeType() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide = ppt.createSlide(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFBackground.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFBackground.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFBackground.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFBackground.java Sat Jan 9 00:46:52 2021 @@ -28,7 +28,7 @@ import static org.junit.jupiter.api.Asse public class TestXSLFBackground { @Test - public void testNoFillBackground() throws IOException { + void testNoFillBackground() throws IOException { XMLSlideShow pptx = new XMLSlideShow(); XSLFSlide slide = pptx.createSlide(); @@ -48,7 +48,7 @@ public class TestXSLFBackground { } @Test - public void testSolidFillBackground() throws IOException { + void testSolidFillBackground() throws IOException { XMLSlideShow pptx = new XMLSlideShow(); XSLFSlide slide = pptx.createSlide(); @@ -72,7 +72,7 @@ public class TestXSLFBackground { } @Test - public void testBlipFillBackground() throws IOException { + void testBlipFillBackground() throws IOException { XMLSlideShow pptx = XSLFTestDataSamples.openSampleDocument("pptx2svg.pptx"); XSLFSlide slide = pptx.getSlides().get(0); @@ -114,7 +114,7 @@ public class TestXSLFBackground { } @Test - public void testGradFillBackground() throws IOException { + void testGradFillBackground() throws IOException { XMLSlideShow pptx = XSLFTestDataSamples.openSampleDocument("themes.pptx"); XSLFSlide slide = pptx.getSlides().get(9); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFChart.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFChart.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFChart.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFChart.java Sat Jan 9 00:46:52 2021 @@ -63,7 +63,7 @@ import org.junit.jupiter.api.Test; */ public class TestXSLFChart { @Test - public void testFillPieChartTemplate() throws IOException { + void testFillPieChartTemplate() throws IOException { XMLSlideShow pptx = XSLFTestDataSamples.openSampleDocument("pie-chart.pptx"); XSLFChart chart = findChart(pptx.getSlides().get(0)); List<XDDFChartData> data = findChartData(chart); @@ -78,7 +78,7 @@ public class TestXSLFChart { } @Test - public void testFillBarChartTemplate() throws IOException { + void testFillBarChartTemplate() throws IOException { XMLSlideShow pptx = XSLFTestDataSamples.openSampleDocument("bar-chart.pptx"); XSLFSlide slide = pptx.getSlides().get(0); // duplicate slide and chart before applying "destructive" tests to it @@ -103,7 +103,7 @@ public class TestXSLFChart { } @Test - public void testFillLineChartTemplate() throws IOException { + void testFillLineChartTemplate() throws IOException { XMLSlideShow pptx = XSLFTestDataSamples.openSampleDocument("line-chart.pptx"); XSLFChart chart = findChart(pptx.getSlides().get(0)); List<XDDFChartData> data = findChartData(chart); @@ -118,7 +118,7 @@ public class TestXSLFChart { } @Test - public void testFillRadarChartTemplate() throws IOException { + void testFillRadarChartTemplate() throws IOException { XMLSlideShow pptx = XSLFTestDataSamples.openSampleDocument("radar-chart.pptx"); XSLFChart chart = findChart(pptx.getSlides().get(0)); List<XDDFChartData> data = findChartData(chart); @@ -133,7 +133,7 @@ public class TestXSLFChart { } @Test - public void testFillScatterChartTemplate() throws IOException { + void testFillScatterChartTemplate() throws IOException { XMLSlideShow pptx = XSLFTestDataSamples.openSampleDocument("scatter-chart.pptx"); XSLFChart chart = findChart(pptx.getSlides().get(0)); List<XDDFChartData> data = findChartData(chart); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFColor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFColor.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFColor.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFColor.java Sat Jan 9 00:46:52 2021 @@ -35,7 +35,7 @@ import org.openxmlformats.schemas.drawin public class TestXSLFColor { @Test - public void testGetters() { + void testGetters() { CTColor xml = CTColor.Factory.newInstance(); CTSRgbColor c = xml.addNewSrgbClr(); c.setVal(new byte[]{(byte)0xFF, 0, 0}); @@ -96,7 +96,7 @@ public class TestXSLFColor { } @Test - public void testHSL() { + void testHSL() { CTColor xml = CTColor.Factory.newInstance(); CTHslColor c = xml.addNewHslClr(); c.setHue2(14400000); @@ -108,7 +108,7 @@ public class TestXSLFColor { } @Test - public void testSRgb() { + void testSRgb() { CTColor xml = CTColor.Factory.newInstance(); xml.addNewSrgbClr().setVal(new byte[]{ (byte)0xFF, (byte)0xFF, 0}); @@ -117,7 +117,7 @@ public class TestXSLFColor { } @Test - public void testSchemeColor() throws IOException { + void testSchemeColor() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSheet slide = ppt.createSlide(); XSLFTheme theme = slide.getTheme(); @@ -145,7 +145,7 @@ public class TestXSLFColor { } @Test - public void testPresetColor() { + void testPresetColor() { CTColor xml = CTColor.Factory.newInstance(); xml.addNewPrstClr().setVal(STPresetColorVal.AQUAMARINE); XSLFColor color = new XSLFColor(xml, null, null, null); @@ -169,7 +169,7 @@ public class TestXSLFColor { } @Test - public void testSys() { + void testSys() { CTColor xml = CTColor.Factory.newInstance(); CTSystemColor sys = xml.addNewSysClr(); sys.setVal(STSystemColorVal.CAPTION_TEXT); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFConnectorShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFConnectorShape.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFConnectorShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFConnectorShape.java Sat Jan 9 00:46:52 2021 @@ -41,7 +41,7 @@ import org.openxmlformats.schemas.presen public class TestXSLFConnectorShape { @Test - public void testLineDecorations() throws IOException { + void testLineDecorations() throws IOException { try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); @@ -122,7 +122,7 @@ public class TestXSLFConnectorShape { } @Test - public void testAddConnector() throws IOException { + void testAddConnector() throws IOException { try (XMLSlideShow pptx = new XMLSlideShow()) { XSLFSlide slide = pptx.createSlide(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFFreeformShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFFreeformShape.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFFreeformShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFFreeformShape.java Sat Jan 9 00:46:52 2021 @@ -39,7 +39,7 @@ import static org.junit.jupiter.api.Asse public class TestXSLFFreeformShape { @Test - public void testSetPath() throws IOException { + void testSetPath() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide = ppt.createSlide(); XSLFFreeformShape shape1 = slide.createFreeform(); @@ -63,7 +63,7 @@ public class TestXSLFFreeformShape { } @Test - public void testZeroWidth() throws IOException { + void testZeroWidth() throws IOException { // see #61633 try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFGroupShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFGroupShape.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFGroupShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFGroupShape.java Sat Jan 9 00:46:52 2021 @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; public class TestXSLFGroupShape { @Test - public void testCreateShapes() throws Exception { + void testCreateShapes() throws Exception { try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); @@ -87,7 +87,7 @@ public class TestXSLFGroupShape { } @Test - public void testRemoveShapes() throws Exception { + void testRemoveShapes() throws Exception { try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java Sat Jan 9 00:46:52 2021 @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; public class TestXSLFHyperlink { @Test - public void testRead() throws IOException{ + void testRead() throws IOException{ XMLSlideShow ppt = XSLFTestDataSamples.openSampleDocument("shapes.pptx"); XSLFSlide slide = ppt.getSlides().get(4); @@ -61,7 +61,7 @@ public class TestXSLFHyperlink { } @Test - public void testCreate() throws IOException, InvalidFormatException { + void testCreate() throws IOException, InvalidFormatException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide1 = ppt.createSlide(); XSLFSlide slide2 = ppt.createSlide(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java Sat Jan 9 00:46:52 2021 @@ -49,7 +49,7 @@ public class TestXSLFPictureShape { private static POIDataSamples _slTests = POIDataSamples.getSlideShowInstance(); @Test - public void testCreate() throws Exception { + void testCreate() throws Exception { XMLSlideShow ppt1 = new XMLSlideShow(); assertEquals(0, ppt1.getPictureData().size()); byte[] data1 = new byte[100]; @@ -86,7 +86,7 @@ public class TestXSLFPictureShape { } @Test - public void testCreateMultiplePictures() throws Exception { + void testCreateMultiplePictures() throws Exception { XMLSlideShow ppt1 = new XMLSlideShow(); XSLFSlide slide1 = ppt1.createSlide(); XSLFGroupShape group1 = slide1.createGroup(); @@ -139,7 +139,7 @@ public class TestXSLFPictureShape { } @Test - public void testImageCaching() throws Exception { + void testImageCaching() throws Exception { XMLSlideShow ppt = new XMLSlideShow(); byte[] img1 = new byte[]{1,2,3}; byte[] img2 = new byte[]{3,4,5}; @@ -160,7 +160,7 @@ public class TestXSLFPictureShape { } @Test - public void testMerge() throws Exception { + void testMerge() throws Exception { XMLSlideShow ppt1 = new XMLSlideShow(); byte[] data1 = new byte[100]; XSLFPictureData pdata1 = ppt1.addPicture(data1, PictureType.JPEG); @@ -241,7 +241,7 @@ public class TestXSLFPictureShape { } @Test - public void testTiffImageBug59742() throws Exception { + void testTiffImageBug59742() throws Exception { XMLSlideShow slideShow = new XMLSlideShow(); final InputStream tiffStream = _slTests.openResourceAsStream("testtiff.tif"); final byte[] pictureData = IOUtils.toByteArray(tiffStream); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShape.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShape.java Sat Jan 9 00:46:52 2021 @@ -30,7 +30,7 @@ import org.openxmlformats.schemas.drawin public class TestXSLFShape { @Test - public void testReadTextShapes() throws IOException { + void testReadTextShapes() throws IOException { XMLSlideShow ppt = XSLFTestDataSamples.openSampleDocument("shapes.pptx"); List<XSLFSlide> slides = ppt.getSlides(); @@ -84,7 +84,7 @@ public class TestXSLFShape { } @Test - public void testProblemFile() throws IOException { + void testProblemFile() throws IOException { try (XMLSlideShow ppt = XSLFTestDataSamples.openSampleDocument("ececapstonespring2012.pptx")) { List<XSLFSlide> slides = ppt.getSlides(); assertEquals(24, slides.size()); @@ -92,7 +92,7 @@ public class TestXSLFShape { } @Test - public void testCreateShapes() throws IOException { + void testCreateShapes() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide = ppt.createSlide(); assertTrue(slide.getShapes().isEmpty()); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java Sat Jan 9 00:46:52 2021 @@ -50,7 +50,7 @@ public class TestXSLFShapeContainer { } @Test - public void testSheet() throws IOException { + void testSheet() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSheet sheet = ppt.createSlide(); verifyContainer(sheet); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSheet.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSheet.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSheet.java Sat Jan 9 00:46:52 2021 @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; public class TestXSLFSheet { @Test - public void testCreateShapes() throws IOException { + void testCreateShapes() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide = ppt.createSlide(); assertTrue(slide.getShapes().isEmpty()); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSimpleShape.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSimpleShape.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSimpleShape.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSimpleShape.java Sat Jan 9 00:46:52 2021 @@ -50,7 +50,7 @@ import org.openxmlformats.schemas.drawin public class TestXSLFSimpleShape { @Test - public void testLineStyles() throws IOException { + void testLineStyles() throws IOException { try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); @@ -141,7 +141,7 @@ public class TestXSLFSimpleShape { } @Test - public void testFill() throws IOException { + void testFill() throws IOException { try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); @@ -167,7 +167,7 @@ public class TestXSLFSimpleShape { } @Test - public void testDefaultProperties() throws IOException { + void testDefaultProperties() throws IOException { try (XMLSlideShow ppt = XSLFTestDataSamples.openSampleDocument("shapes.pptx")) { XSLFSlide slide6 = ppt.getSlides().get(5); List<XSLFShape> shapes = slide6.getShapes(); @@ -236,7 +236,7 @@ public class TestXSLFSimpleShape { } @Test - public void testAnchor() throws IOException { + void testAnchor() throws IOException { try (XMLSlideShow ppt = XSLFTestDataSamples.openSampleDocument("shapes.pptx")) { List<XSLFSlide> slide = ppt.getSlides(); @@ -270,7 +270,7 @@ public class TestXSLFSimpleShape { @SuppressWarnings({"unused", "deprecation"}) @Test - public void testShadowEffects() throws IOException{ + void testShadowEffects() throws IOException{ try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); CTStyleMatrix styleMatrix = slide.getTheme().getXmlObject().getThemeElements().getFmtScheme(); @@ -283,7 +283,7 @@ public class TestXSLFSimpleShape { } @Test - public void testValidGeometry() throws Exception { + void testValidGeometry() throws Exception { try (XMLSlideShow ppt = new XMLSlideShow()) { XSLFSlide slide = ppt.createSlide(); @@ -305,7 +305,7 @@ public class TestXSLFSimpleShape { } @Test - public void testArrayStoreException() throws Exception { + void testArrayStoreException() throws Exception { File tmpDir = new File("build/tmp/"); // fix maven build errors Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlide.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlide.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlide.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlide.java Sat Jan 9 00:46:52 2021 @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; public class TestXSLFSlide { @Test - public void testReadShapes() throws IOException { + void testReadShapes() throws IOException { XMLSlideShow ppt = XSLFTestDataSamples.openSampleDocument("shapes.pptx"); List<XSLFSlide> slides = ppt.getSlides(); @@ -107,7 +107,7 @@ public class TestXSLFSlide { } @Test - public void testCreateSlide() throws IOException { + void testCreateSlide() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); assertEquals(0, ppt.getSlides().size()); @@ -122,7 +122,7 @@ public class TestXSLFSlide { } @Test - public void testImportContent() throws IOException { + void testImportContent() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XMLSlideShow src = XSLFTestDataSamples.openSampleDocument("themes.pptx"); @@ -180,7 +180,7 @@ public class TestXSLFSlide { } @Test - public void testMergeSlides() throws IOException { + void testMergeSlides() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); String[] pptx = {"shapes.pptx", "themes.pptx", "layouts.pptx", "backgrounds.pptx"}; @@ -197,7 +197,7 @@ public class TestXSLFSlide { } @Test - public void testCreateChart() throws IOException { + void testCreateChart() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); XSLFSlide slide = ppt.createSlide(); XSLFChart chart = ppt.createChart(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShow.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShow.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShow.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShow.java Sat Jan 9 00:46:52 2021 @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; */ public class TestXSLFSlideShow { @Test - public void testCreateSlide() throws IOException { + void testCreateSlide() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); assertEquals(0, ppt.getSlides().size()); @@ -62,7 +62,7 @@ public class TestXSLFSlideShow { } @Test - public void testRemoveSlide() throws IOException { + void testRemoveSlide() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); assertEquals(0, ppt.getSlides().size()); @@ -87,7 +87,7 @@ public class TestXSLFSlideShow { } @Test - public void testDimension() throws IOException { + void testDimension() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); Dimension sz = ppt.getPageSize(); assertEquals(720, sz.width); @@ -100,7 +100,7 @@ public class TestXSLFSlideShow { } @Test - public void testSlideMasters() throws IOException { + void testSlideMasters() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); List<XSLFSlideMaster> masters = ppt.getSlideMasters(); assertEquals(1, masters.size()); @@ -111,7 +111,7 @@ public class TestXSLFSlideShow { } @Test - public void testSlideLayout() throws IOException { + void testSlideLayout() throws IOException { XMLSlideShow ppt = new XMLSlideShow(); List<XSLFSlideMaster> masters = ppt.getSlideMasters(); assertEquals(1, masters.size()); @@ -125,7 +125,7 @@ public class TestXSLFSlideShow { } @Test - public void testSlideLayoutNames() throws IOException { + void testSlideLayoutNames() throws IOException { final String[] names = { "Blank", "Title Only", "Section Header", "Picture with Caption", "Title and Content" , "Title Slide", "Title and Vertical Text", "Vertical Title and Text", "Comparison" Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShowFactory.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShowFactory.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShowFactory.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShowFactory.java Sat Jan 9 00:46:52 2021 @@ -47,7 +47,7 @@ public final class TestXSLFSlideShowFact "The unit test needs to be updated by deleting the expected exception code. Status and close any related bugs."; @Test - public void testFactoryFromFile() { + void testFactoryFromFile() { // Remove thrown.* when bug 58779 is resolved // In the mean time, this function will modify SampleShow.pptx on disk. AssertionError ex = assertThrows(AssertionError.class, () -> testFactoryFromFile(filename), @@ -56,12 +56,12 @@ public final class TestXSLFSlideShowFact } @Test - public void testFactoryFromStream() throws Exception { + void testFactoryFromStream() throws Exception { testFactoryFromStream(filename); } @Test - public void testFactoryFromNative() { + void testFactoryFromNative() { // Remove thrown.* when unit test for XSLF SlideShowFactory.create(OPCPackage) is implemented UnsupportedOperationException ex = assertThrows(UnsupportedOperationException.class, () -> testFactoryFromNative(filename), removeExpectedExceptionMsg @@ -70,19 +70,19 @@ public final class TestXSLFSlideShowFact } @Test - public void testFactoryFromProtectedFile() throws Exception { + void testFactoryFromProtectedFile() throws Exception { File pFile = createProtected(); testFactoryFromProtectedFile(pFile.getAbsolutePath(), password); } @Test - public void testFactoryFromProtectedStream() throws Exception { + void testFactoryFromProtectedStream() throws Exception { File pFile = createProtected(); testFactoryFromProtectedStream(pFile.getAbsolutePath(), password); } @Test - public void testFactoryFromProtectedNative() throws Exception { + void testFactoryFromProtectedNative() throws Exception { File pFile = createProtected(); testFactoryFromProtectedNative(pFile.getAbsolutePath(), password); } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org For additional commands, e-mail: commits-h...@poi.apache.org