Author: kiwiwings Date: Sat Jan 9 00:46:52 2021 New Revision: 1885283 URL: http://svn.apache.org/viewvc?rev=1885283&view=rev Log: Sonar fixes JUnit5 test classes and methods should have default package visibility
Modified: poi/trunk/src/multimodule/ooxml/test9/module-info.class poi/trunk/src/multimodule/ooxml/test9/module-info.java poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestDetectAsOOXML.java poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestEmbedded.java poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestXMLPropertiesTextExtractor.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestContentType.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageCoreProperties.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagePartName.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageThumbnail.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagingURIHelper.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestRelationships.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePartName.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/util/TestZipSecureFile.java poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureConfig.java poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestAgileEncryptionParameters.java poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptionInfo.java poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/draw/TestDrawPictureShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/TestWorkbookFactory.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/format/TestCellFormatPart.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestFormulaParser.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/TestStructuredReferences.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestProper.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestSumifsXSSF.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/BaseTestXCell.java poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestIdentifierManager.java poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestNecessaryOOXMLClasses.java poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/TestXDDFColor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChart.java poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFDataSourcesFactory.java poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextBodyProperties.java poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/text/TestXDDFTextRun.java poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/CombinedIteratorTest.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestNecessaryOOXMLClasses.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFAutoShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFBackground.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFChart.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFColor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFConnectorShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFFreeformShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFGroupShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSheet.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSimpleShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlide.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShow.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFSlideShowFactory.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTableRow.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTableStyles.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextBox.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextParagraph.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextRun.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTheme.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestNecessaryOOXMLClasses.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestSheetProtection.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestWorkbookProtection.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFOffset.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/binary/TestXSSFBSharedStringsTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/binary/TestXSSFBSheetHyperlinkManager.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/TestReadOnlySharedStringsTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/TestXSSFReader.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFBEventBasedExcelExtractor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFEventBasedExcelExtractor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFExcelExtractor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFExportToXML.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFImportFromXML.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/io/TestLoadSaveXSSF.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestCalculationChain.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestMapInfo.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestSharedStringsTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestStylesTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestThemesTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestOutlining.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFCell.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFDataValidation.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFSheetAutoSizeColumn.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFUnicodeSurrogates.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSheetDataWriter.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/BaseTestXSSFPivotTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestSXSSFBugs.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestTableStyles.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestUnfixedBugs.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFCell.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFCellStyle.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFChart.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFChartSheet.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFColGrouping.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFColor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFComment.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFConditionalFormatting.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataFormat.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidation.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDialogSheet.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDrawing.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFEvaluationSheet.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFEvenFooter.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFEvenHeader.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFirstFooter.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFirstHeader.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaParser.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFHeaderFooterProperties.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFHyperlink.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFName.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFOddFooter.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFOddHeader.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFPictureData.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFPrintSetup.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFRichTextString.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFRow.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheet.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetRowGrouping.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetShiftRows.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetShiftRowsAndColumns.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetUpdateArrayFormulas.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSimpleShape.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFTableColumn.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFTextParagraph.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFTextRun.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFUnicodeSurrogates.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFVMLDrawing.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXDDFChartLegend.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXDDFManualLayout.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSF3DChartData.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSFCategoryAxis.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSFChartAxis.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSFChartTitle.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSFDateAxis.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSFLineChartData.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSFScatterChartData.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSFValueAxis.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/extensions/TestXSSFBorder.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/extensions/TestXSSFCellFill.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/extensions/TestXSSFHeaderFooter.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/extensions/XSSFCellBorderTest.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/helpers/TestColumnHelper.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/helpers/TestHeaderFooterHelper.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/util/MemoryUsage.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/util/TestCTColComparator.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/util/TestEvilUnclosedBRFixingInputStream.java poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/util/TestNumericRanges.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/TestAllExtendedProperties.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/TestDocumentProtection.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/TestNecessaryOOXMLClasses.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/TestPackageCorePropertiesGetKeywords.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/extractor/TestExternalEntities.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/extractor/TestXWPFWordExtractor.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/model/TestXWPFDecorators.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/model/TestXWPFHeaderFooterPolicy.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestColumn.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFBugs.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFChart.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFComment.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFDocument.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFEndnote.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFEndnotes.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFFootnote.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFFootnotes.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFHeader.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFHeadings.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFNumbering.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFParagraph.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFPictureData.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFRun.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFSDT.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFSmartTag.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFStyles.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFTable.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFTableCell.java poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFTableRow.java Modified: poi/trunk/src/multimodule/ooxml/test9/module-info.class URL: http://svn.apache.org/viewvc/poi/trunk/src/multimodule/ooxml/test9/module-info.class?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== Binary files - no diff available. Modified: poi/trunk/src/multimodule/ooxml/test9/module-info.java URL: http://svn.apache.org/viewvc/poi/trunk/src/multimodule/ooxml/test9/module-info.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/multimodule/ooxml/test9/module-info.java (original) +++ poi/trunk/src/multimodule/ooxml/test9/module-info.java Sat Jan 9 00:46:52 2021 @@ -78,7 +78,7 @@ module org.apache.poi.ooxml { exports org.apache.poi.poifs.crypt.dsig.services; exports org.apache.poi.poifs.crypt.temp; - opens org.apache.poi.openxml4j.opc to org.apache.poi.poi; + opens org.apache.poi.openxml4j.opc to org.apache.poi.poi, org.junit.platform.commons; /* optional dependencies for xml signatures - you need to add a require entry your module-info @@ -122,5 +122,66 @@ module org.apache.poi.ooxml { exports org.apache.poi.xssf.usermodel.charts to org.junit.platform.commons; exports org.apache.poi.xwpf to org.junit.platform.commons; - + opens org.apache.poi.extractor.ooxml to org.junit.platform.commons; + opens org.apache.poi.openxml4j.opc.compliance to org.junit.platform.commons; + opens org.apache.poi.poifs.crypt.tests to org.junit.platform.commons; + opens org.apache.poi.sl.tests to org.junit.platform.commons; + opens org.apache.poi.sl.tests.draw to org.junit.platform.commons; + opens org.apache.poi.ss.tests to org.junit.platform.commons; + opens org.apache.poi.ss.tests.extractor to org.junit.platform.commons; + opens org.apache.poi.ss.tests.format to org.junit.platform.commons; + opens org.apache.poi.ss.tests.formula to org.junit.platform.commons; + opens org.apache.poi.ss.tests.formula.eval to org.junit.platform.commons; + opens org.apache.poi.ss.tests.formula.functions to org.junit.platform.commons; + opens org.apache.poi.ss.tests.usermodel to org.junit.platform.commons; + opens org.apache.poi.ss.tests.util to org.junit.platform.commons; + opens org.apache.poi.util.tests to org.junit.platform.commons; + opens org.apache.poi.xslf to org.junit.platform.commons; + opens org.apache.poi.xslf.extractor to org.junit.platform.commons; + opens org.apache.poi.xssf.io to org.junit.platform.commons; + opens org.apache.poi.xssf.usermodel.charts to org.junit.platform.commons; + opens org.apache.poi.xwpf to org.junit.platform.commons; + opens org.apache.poi.xwpf.extractor to org.junit.platform.commons; + opens org.apache.poi.xwpf.usermodel to org.junit.platform.commons; + opens org.apache.poi.xwpf.model to org.junit.platform.commons; + opens org.apache.poi.xdgf.extractor to org.junit.platform.commons; + opens org.apache.poi.xdgf.exceptions to org.junit.platform.commons; + opens org.apache.poi.xdgf.usermodel to org.junit.platform.commons; + opens org.apache.poi.xdgf.usermodel.section to org.junit.platform.commons; + opens org.apache.poi.xdgf.usermodel.section.geometry to org.junit.platform.commons; + opens org.apache.poi.xdgf.usermodel.shape to org.junit.platform.commons; + opens org.apache.poi.xdgf.usermodel.shape.exceptions to org.junit.platform.commons; + opens org.apache.poi.xdgf.xml to org.junit.platform.commons; + opens org.apache.poi.xdgf.util to org.junit.platform.commons; + opens org.apache.poi.xdgf.geom to org.junit.platform.commons; + opens org.apache.poi.ooxml to org.junit.platform.commons; + opens org.apache.poi.ooxml.dev to org.junit.platform.commons; + opens org.apache.poi.ooxml.extractor to org.junit.platform.commons; + opens org.apache.poi.ooxml.util to org.junit.platform.commons; + opens org.apache.poi.xddf.usermodel to org.junit.platform.commons; + opens org.apache.poi.xddf.usermodel.text to org.junit.platform.commons; + opens org.apache.poi.xddf.usermodel.chart to org.junit.platform.commons; + opens org.apache.poi.openxml4j.exceptions to org.junit.platform.commons; + opens org.apache.poi.openxml4j.opc.internal to org.junit.platform.commons; + opens org.apache.poi.openxml4j.opc.internal.marshallers to org.junit.platform.commons; + opens org.apache.poi.openxml4j.opc.internal.unmarshallers to org.junit.platform.commons; + opens org.apache.poi.openxml4j.util to org.junit.platform.commons; + opens org.apache.poi.xssf to org.junit.platform.commons; + opens org.apache.poi.xssf.extractor to org.junit.platform.commons; + opens org.apache.poi.xssf.eventusermodel to org.junit.platform.commons; + opens org.apache.poi.xssf.usermodel to org.junit.platform.commons; + opens org.apache.poi.xssf.usermodel.helpers to org.junit.platform.commons; + opens org.apache.poi.xssf.usermodel.extensions to org.junit.platform.commons; + opens org.apache.poi.xssf.binary to org.junit.platform.commons; + opens org.apache.poi.xssf.model to org.junit.platform.commons; + opens org.apache.poi.xssf.streaming to org.junit.platform.commons; + opens org.apache.poi.xssf.util to org.junit.platform.commons; + opens org.apache.poi.xslf.draw to org.junit.platform.commons; + opens org.apache.poi.xslf.usermodel to org.junit.platform.commons; + opens org.apache.poi.xslf.model to org.junit.platform.commons; + opens org.apache.poi.xslf.util to org.junit.platform.commons; + opens org.apache.poi.poifs.crypt.dsig to org.junit.platform.commons; + opens org.apache.poi.poifs.crypt.dsig.facets to org.junit.platform.commons; + opens org.apache.poi.poifs.crypt.dsig.services to org.junit.platform.commons; + opens org.apache.poi.poifs.crypt.temp to org.junit.platform.commons; } \ No newline at end of file Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java Sat Jan 9 00:46:52 2021 @@ -142,7 +142,7 @@ public class TestExtractorFactory { @ParameterizedTest @MethodSource("testFileData") - public void testFile(String testcase, File file, String extractor, int count) throws Exception { + void testFile(String testcase, File file, String extractor, int count) throws Exception { try (POITextExtractor ext = createExtractor(file)) { assertNotNull(ext); testExtractor(ext, testcase, extractor, count); @@ -151,7 +151,7 @@ public class TestExtractorFactory { @ParameterizedTest @MethodSource("testScratchData") - public void testPOIFS(String testcase, File testFile, String extractor, int count) throws Exception { + void testPOIFS(String testcase, File testFile, String extractor, int count) throws Exception { // test processing of InputStream try (FileInputStream fis = new FileInputStream(testFile); POIFSFileSystem poifs = new POIFSFileSystem(fis); @@ -163,7 +163,7 @@ public class TestExtractorFactory { @ParameterizedTest @MethodSource("testFileData") - public void testOOXML(String testcase, File testFile, String extractor, int count) throws Exception { + void testOOXML(String testcase, File testFile, String extractor, int count) throws Exception { // test processing of InputStream try (FileInputStream fis = new FileInputStream(testFile); POITextExtractor ext = createExtractor(fis)) { @@ -174,7 +174,7 @@ public class TestExtractorFactory { @ParameterizedTest @MethodSource("testOOXMLData") - public void testPackage(String testcase, File testFile, String extractor, int count) throws Exception { + void testPackage(String testcase, File testFile, String extractor, int count) throws Exception { try (final OPCPackage pkg = OPCPackage.open(testFile, PackageAccess.READ); final POITextExtractor ext = xmlFactory.create(pkg)) { assertNotNull(ext); @@ -184,13 +184,13 @@ public class TestExtractorFactory { } @Test - public void testFileInvalid() { + void testFileInvalid() { IOException ex = assertThrows(IOException.class, () -> createExtractor(txt)); assertEquals("Can't create extractor - unsupported file type: UNKNOWN", ex.getMessage()); } @Test - public void testInputStreamInvalid() throws IOException { + void testInputStreamInvalid() throws IOException { try (FileInputStream fis = new FileInputStream(txt)) { IOException ex = assertThrows(IOException.class, () -> createExtractor(fis)); assertTrue(ex.getMessage().contains(FileMagic.UNKNOWN.name())); @@ -198,7 +198,7 @@ public class TestExtractorFactory { } @Test - public void testPOIFSInvalid() { + void testPOIFSInvalid() { // Not really an Extractor test, but we'll leave it to test POIFS reaction anyway ... IOException ex = assertThrows(IOException.class, () -> new POIFSFileSystem(txt)); assertTrue(ex.getMessage().contains("Invalid header signature; read 0x3D20726F68747541, expected 0xE11AB1A1E011CFD0")); @@ -214,13 +214,13 @@ public class TestExtractorFactory { } } @Test - public void testPackageInvalid() { + void testPackageInvalid() { // Text assertThrows(NotOfficeXmlFileException.class, () -> OPCPackage.open(txt, PackageAccess.READ)); } @Test - public void testPreferEventBased() throws Exception { + void testPreferEventBased() throws Exception { assertFalse(ExtractorFactory.getPreferEventExtractor()); assertFalse(ExtractorFactory.getThreadPrefersEventExtractors()); assertNull(ExtractorFactory.getAllThreadsPreferEventExtractors()); @@ -300,7 +300,7 @@ public class TestExtractorFactory { */ @ParameterizedTest @MethodSource("testEmbeddedData") - public void testEmbedded(String format, File file, String expected) throws Exception { + void testEmbedded(String format, File file, String expected) throws Exception { int numWord = 0, numXls = 0, numPpt = 0, numMsg = 0, numWordX = 0; try (final POIOLE2TextExtractor ext = (POIOLE2TextExtractor) createExtractor(file)) { @@ -417,7 +417,7 @@ public class TestExtractorFactory { "spreadsheet/WithChartSheet.xlsx", "spreadsheet/chart_sheet.xlsx" }) - public void testFileLeak(String file) { + void testFileLeak(String file) { // run a number of files that might fail in order to catch // leaked file resources when using file-leak-detector while // running the test @@ -437,7 +437,7 @@ public class TestExtractorFactory { } @Test - public void testGetEmbeddedFromXMLExtractor() { + void testGetEmbeddedFromXMLExtractor() { // currently not implemented assertThrows(IllegalStateException.class, () -> ExtractorFactory.getEmbeddedDocsTextExtractors(null)); } @@ -446,7 +446,7 @@ public class TestExtractorFactory { // When this happens, change this from @Test(expected=...) to @Test // bug 45565: text within TextBoxes is extracted by ExcelExtractor and WordExtractor @Test - public void test45565() throws Exception { + void test45565() throws Exception { try (POITextExtractor extractor = ex("45565.xls")) { String text = extractor.getText(); assertThrows(AssertionError.class, () -> { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestDetectAsOOXML.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestDetectAsOOXML.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestDetectAsOOXML.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestDetectAsOOXML.java Sat Jan 9 00:46:52 2021 @@ -42,7 +42,7 @@ import org.junit.jupiter.params.provider @SuppressWarnings("deprecation") public class TestDetectAsOOXML { @Test - public void testOpensProperly() throws IOException, InvalidFormatException { + void testOpensProperly() throws IOException, InvalidFormatException { try (InputStream is = openSampleFileStream("sample.xlsx"); OPCPackage pkg = OPCPackage.open(is)) { assertNotNull(pkg); @@ -51,7 +51,7 @@ public class TestDetectAsOOXML { @ParameterizedTest @CsvSource({"SampleSS.xlsx, OOXML", "SampleSS.xls, OLE2", "SampleSS.txt, UNKNOWN"}) - public void testDetectAsPOIFS(String file, FileMagic fm) throws IOException { + void testDetectAsPOIFS(String file, FileMagic fm) throws IOException { try (InputStream is = FileMagic.prepareToCheckMagic(openSampleFileStream(file))) { FileMagic act = FileMagic.valueOf(is); @@ -63,7 +63,7 @@ public class TestDetectAsOOXML { } @Test - public void testFileCorruption() throws Exception { + void testFileCorruption() throws Exception { // create test InputStream byte[] testData = { 1, 2, 3 }; ByteArrayInputStream testInput = new ByteArrayInputStream(testData); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestEmbedded.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestEmbedded.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestEmbedded.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestEmbedded.java Sat Jan 9 00:46:52 2021 @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; */ public class TestEmbedded { @Test - public void testExcel() throws Exception { + void testExcel() throws Exception { POIXMLDocument doc = new XSSFWorkbook( POIDataSamples.getSpreadSheetInstance().openResourceAsStream("ExcelWithAttachments.xlsm") ); @@ -45,7 +45,7 @@ public class TestEmbedded { } @Test - public void testWord() throws Exception { + void testWord() throws Exception { POIXMLDocument doc = new XWPFDocument( POIDataSamples.getDocumentInstance().openResourceAsStream("WordWithAttachments.docx") ); @@ -53,7 +53,7 @@ public class TestEmbedded { } @Test - public void testPowerPoint() throws Exception { + void testPowerPoint() throws Exception { POIXMLDocument doc = new XSLFSlideShow(OPCPackage.open( POIDataSamples.getSlideShowInstance().openResourceAsStream("PPTWithAttachments.pptm")) ); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java Sat Jan 9 00:46:52 2021 @@ -177,22 +177,22 @@ public final class TestPOIXMLDocument { } @Test - public void testPPTX() throws Exception { + void testPPTX() throws Exception { assertReadWrite(POIDataSamples.getSlideShowInstance(), "PPTWithAttachments.pptm"); } @Test - public void testXLSX() throws Exception { + void testXLSX() throws Exception { assertReadWrite(POIDataSamples.getSpreadSheetInstance(), "ExcelWithAttachments.xlsm"); } @Test - public void testDOCX() throws Exception { + void testDOCX() throws Exception { assertReadWrite(POIDataSamples.getDocumentInstance(), "WordWithAttachments.docx"); } @Test - public void testRelationOrder() throws Exception { + void testRelationOrder() throws Exception { POIDataSamples pds = POIDataSamples.getDocumentInstance(); try (InputStream is = pds.openResourceAsStream("WordWithAttachments.docx"); OPCPackage pkg = PackageHelper.open(is); @@ -207,7 +207,7 @@ public final class TestPOIXMLDocument { } @Test - public void testGetNextPartNumber() throws Exception { + void testGetNextPartNumber() throws Exception { POIDataSamples pds = POIDataSamples.getDocumentInstance(); try (InputStream is = pds.openResourceAsStream("WordWithAttachments.docx"); OPCPackage pkg = PackageHelper.open(is); @@ -237,7 +237,7 @@ public final class TestPOIXMLDocument { } @Test - public void testCommitNullPart() throws IOException { + void testCommitNullPart() throws IOException { POIXMLDocumentPart part = new POIXMLDocumentPart(); part.prepareForCommit(); part.commit(); @@ -253,7 +253,7 @@ public final class TestPOIXMLDocument { } @Test - public void testVSDX() throws Exception { + void testVSDX() throws Exception { POIDataSamples pds = POIDataSamples.getDiagramInstance(); try (InputStream is = pds.openResourceAsStream("test.vsdx"); OPCPackage open = PackageHelper.open(is); @@ -264,7 +264,7 @@ public final class TestPOIXMLDocument { } @Test - public void testVSDXPart() throws IOException { + void testVSDXPart() throws IOException { POIDataSamples pds = POIDataSamples.getDiagramInstance(); try (InputStream is = pds.openResourceAsStream("test.vsdx"); OPCPackage open = PackageHelper.open(is)) { @@ -277,7 +277,7 @@ public final class TestPOIXMLDocument { } @Test - public void testInvalidCoreRel() throws IOException { + void testInvalidCoreRel() throws IOException { POIDataSamples pds = POIDataSamples.getDiagramInstance(); try (OPCPackage open = PackageHelper.open(pds.openResourceAsStream("test.vsdx"))) { assertThrows(POIXMLException.class, () -> new POIXMLDocumentPart(open, "somethingillegal")); @@ -297,7 +297,7 @@ public final class TestPOIXMLDocument { } @Test - public void testOSGIClassLoading() throws IOException { + void testOSGIClassLoading() throws IOException { byte[] data; try (InputStream is = POIDataSamples.getSlideShowInstance().openResourceAsStream("table_test.pptx")) { data = IOUtils.toByteArray(is); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java Sat Jan 9 00:46:52 2021 @@ -72,7 +72,7 @@ public final class TestPOIXMLProperties } @Test - public void testWorkbookExtendedProperties() throws Exception { + void testWorkbookExtendedProperties() throws Exception { XSSFWorkbook workbook = new XSSFWorkbook(); POIXMLProperties props = workbook.getProperties(); assertNotNull(props); @@ -114,7 +114,7 @@ public final class TestPOIXMLProperties } @Test - public void testWorkbookExtendedPropertiesGettersSetters() throws Exception { + void testWorkbookExtendedPropertiesGettersSetters() throws Exception { XSSFWorkbook workbook = new XSSFWorkbook(); POIXMLProperties props = workbook.getProperties(); assertNotNull(props); @@ -154,7 +154,7 @@ public final class TestPOIXMLProperties * Test usermodel API for setting custom properties */ @Test - public void testCustomProperties() throws Exception { + void testCustomProperties() throws Exception { try (XSSFWorkbook wb1 = new XSSFWorkbook()) { POIXMLProperties.CustomProperties customProps = wb1.getProperties().getCustomProperties(); @@ -200,7 +200,7 @@ public final class TestPOIXMLProperties } @Test - public void testDocumentProperties() { + void testDocumentProperties() { String category = _coreProperties.getCategory(); assertEquals("test", category); String contentStatus = "Draft"; @@ -218,7 +218,7 @@ public final class TestPOIXMLProperties } @Test - public void testTransitiveSetters() throws IOException { + void testTransitiveSetters() throws IOException { XWPFDocument doc = new XWPFDocument(); CoreProperties cp = doc.getProperties().getCoreProperties(); @@ -236,7 +236,7 @@ public final class TestPOIXMLProperties } @Test - public void testGetSetRevision() { + void testGetSetRevision() { String revision = _coreProperties.getRevision(); assertTrue(Integer.parseInt(revision) > 1, "Revision number is 1"); _coreProperties.setRevision("20"); @@ -246,7 +246,7 @@ public final class TestPOIXMLProperties } @Test - public void testLastModifiedByUserProperty() { + void testLastModifiedByUserProperty() { String lastModifiedByUser = _coreProperties.getLastModifiedByUser(); assertEquals("Paolo Mottadelli", lastModifiedByUser); _coreProperties.setLastModifiedByUser("Test User"); @@ -268,7 +268,7 @@ public final class TestPOIXMLProperties @Disabled("Fails to add some of the thumbnails, needs more investigation") @Test - public void testThumbnails() throws Exception { + void testThumbnails() throws Exception { POIXMLProperties noThumbProps = sampleNoThumb.getProperties(); assertNotNull(_props.getThumbnailPart()); @@ -308,7 +308,7 @@ public final class TestPOIXMLProperties } @Test - public void testAddProperty() throws IOException { + void testAddProperty() throws IOException { try (XWPFDocument doc = XWPFTestDataSamples.openSampleDocument("documentProperties.docx")) { POIXMLProperties.CustomProperties cps = doc.getProperties().getCustomProperties(); assertEquals(1, cps.getLastPid()); @@ -320,7 +320,7 @@ public final class TestPOIXMLProperties } @Test - public void testBug60977() throws IOException { + void testBug60977() throws IOException { try (final XSSFWorkbook workbook = new XSSFWorkbook()) { final Sheet sheet = workbook.createSheet("sheet"); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java Sat Jan 9 00:46:52 2021 @@ -85,7 +85,7 @@ public class TestTriggerCoverage { @ParameterizedTest @MethodSource("files") - public void testFile(File file) throws Exception { + void testFile(File file) throws Exception { try (InputStream stream = new FileInputStream(file)) { if (file.getName().endsWith(".docx")) { try (XWPFDocument doc = new XWPFDocument(stream)) { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestXMLPropertiesTextExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestXMLPropertiesTextExtractor.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestXMLPropertiesTextExtractor.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestXMLPropertiesTextExtractor.java Sat Jan 9 00:46:52 2021 @@ -35,7 +35,7 @@ public final class TestXMLPropertiesText private static final POIDataSamples _slSamples = POIDataSamples.getSlideShowInstance(); @Test - public void testGetFromMainExtractor() throws Exception { + void testGetFromMainExtractor() throws Exception { OPCPackage pkg = PackageHelper.open(_ssSamples.openResourceAsStream("ExcelWithAttachments.xlsm")); XSSFWorkbook wb = new XSSFWorkbook(pkg); @@ -59,7 +59,7 @@ public final class TestXMLPropertiesText } @Test - public void testCore() throws Exception { + void testCore() throws Exception { OPCPackage pkg = PackageHelper.open( _ssSamples.openResourceAsStream("ExcelWithAttachments.xlsm") ); @@ -79,7 +79,7 @@ public final class TestXMLPropertiesText } @Test - public void testExtended() throws Exception { + void testExtended() throws Exception { OPCPackage pkg = OPCPackage.open( _ssSamples.openResourceAsStream("ExcelWithAttachments.xlsm") ); @@ -101,7 +101,7 @@ public final class TestXMLPropertiesText } @Test - public void testCustom() throws Exception { + void testCustom() throws Exception { OPCPackage pkg = OPCPackage.open( _ssSamples.openResourceAsStream("ExcelWithAttachments.xlsm") ); @@ -125,7 +125,7 @@ public final class TestXMLPropertiesText * dates can be null */ @Test - public void testWithSomeNulls() throws Exception { + void testWithSomeNulls() throws Exception { OPCPackage pkg = OPCPackage.open( _slSamples.openResourceAsStream("49386-null_dates.pptx") ); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestContentType.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestContentType.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestContentType.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestContentType.java Sat Jan 9 00:46:52 2021 @@ -51,7 +51,7 @@ public final class TestContentType { */ @ParameterizedTest @ValueSource(strings = {"text/xml", "application/pgp-key", "application/vnd.hp-PCLXL", "application/vnd.lotus-1-2-3"}) - public void testContentTypeValidation(String contentType) throws InvalidFormatException { + void testContentTypeValidation(String contentType) throws InvalidFormatException { assertDoesNotThrow(() -> new ContentType(contentType)); } @@ -78,7 +78,7 @@ public final class TestContentType { "text[/xml", "text]/xml", "text?/xml", "tex=t/xml", "te{xt/xml", "tex}t/xml", "te xt/xml", "text\u0009/xml", "text xml", " text/xml "}) - public void testContentTypeValidationFailure(String contentType) { + void testContentTypeValidationFailure(String contentType) { assertThrows(InvalidFormatException.class, () -> new ContentType(contentType), "Must have fail for content type: '" + contentType + "' !"); } @@ -94,7 +94,7 @@ public final class TestContentType { "text/xml;a=b;c=d", "text/xml;key1=param1;key2=param2", "application/pgp-key;version=\"2\"", "application/x-resqml+xml;version=2.0;type=obj_global2dCrs"}) - public void testContentTypeParam(String contentType) { + void testContentTypeParam(String contentType) { assertDoesNotThrow(() -> new ContentType(contentType)); } @@ -108,7 +108,7 @@ public final class TestContentType { "mail/toto;titi = tata", // spaces not allowed "text/\u0080" // characters above ASCII are not allowed }) - public void testContentTypeParameterFailure(String contentType) { + void testContentTypeParameterFailure(String contentType) { assertThrows(InvalidFormatException.class, () -> new ContentType(contentType), "Must have fail for content type: '" + contentType + "' !"); } @@ -120,7 +120,7 @@ public final class TestContentType { */ @ParameterizedTest @ValueSource(strings = {"text/xml(comment)"}) - public void testContentTypeCommentFailure(String contentType) { + void testContentTypeCommentFailure(String contentType) { assertThrows(InvalidFormatException.class, () -> new ContentType(contentType), "Must have fail for content type: '" + contentType + "' !"); } @@ -131,7 +131,7 @@ public final class TestContentType { * (expected = InvalidFormatException.class) */ @Test - public void testFileWithContentTypeEntities() throws Exception { + void testFileWithContentTypeEntities() throws Exception { try (InputStream is = OpenXML4JTestDataSamples.openSampleStream("ContentTypeHasEntities.ooxml")) { if (isOldXercesActive()) { OPCPackage.open(is); @@ -146,7 +146,7 @@ public final class TestContentType { * parameters on a content type */ @Test - public void testFileWithContentTypeParams() throws Exception { + void testFileWithContentTypeParams() throws Exception { try (InputStream is = OpenXML4JTestDataSamples.openSampleStream("ContentTypeHasParameters.ooxml"); OPCPackage p = OPCPackage.open(is)) { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java Sat Jan 9 00:46:52 2021 @@ -38,7 +38,7 @@ public final class TestFileHelper { * {@link File#getName()} instead of {@link FileHelper#getFilename(File) */ @Test - public void testGetDirectory() { + void testGetDirectory() { TreeMap<String, String> expectedValue = new TreeMap<>(); expectedValue.put("/dir1/test.doc", "/dir1"); expectedValue.put("/dir1/dir2/test.doc.xml", "/dir1/dir2"); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java Sat Jan 9 00:46:52 2021 @@ -85,7 +85,7 @@ public final class TestListParts { * List all parts of a package. */ @Test - public void testListParts() throws InvalidFormatException, IOException { + void testListParts() throws InvalidFormatException, IOException { try (InputStream is = OpenXML4JTestDataSamples.openSampleStream("sample.docx"); OPCPackage p = OPCPackage.open(is)) { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java Sat Jan 9 00:46:52 2021 @@ -711,7 +711,7 @@ public final class TestPackage { } @Test - public void testZipEntityExpansionTerminates() { + void testZipEntityExpansionTerminates() { IllegalStateException ex = assertThrows( IllegalStateException.class, () -> openXmlBombFile("poc-shared-strings.xlsx") @@ -720,7 +720,7 @@ public final class TestPackage { } @Test - public void testZipEntityExpansionSharedStringTableEvents() { + void testZipEntityExpansionSharedStringTableEvents() { boolean before = ExtractorFactory.getThreadPrefersEventExtractors(); ExtractorFactory.setThreadPrefersEventExtractors(true); try { @@ -736,7 +736,7 @@ public final class TestPackage { @Test - public void testZipEntityExpansionExceedsMemory() { + void testZipEntityExpansionExceedsMemory() { IOException ex = assertThrows( IOException.class, () -> openXmlBombFile("poc-xmlbomb.xlsx") @@ -746,7 +746,7 @@ public final class TestPackage { } @Test - public void testZipEntityExpansionExceedsMemory2() { + void testZipEntityExpansionExceedsMemory2() { IOException ex = assertThrows( IOException.class, () -> openXmlBombFile("poc-xmlbomb-empty.xlsx") @@ -845,7 +845,7 @@ public final class TestPackage { } @Test - public void testConstructors() throws IOException { + void testConstructors() throws IOException { // verify the various ways to construct a ZipSecureFile File file = getSampleFile("sample.xlsx"); try (ZipSecureFile zipFile = new ZipSecureFile(file)) { @@ -858,7 +858,7 @@ public final class TestPackage { } @Test - public void testMaxTextSize() { + void testMaxTextSize() { long before = ZipSecureFile.getMaxTextSize(); try { ZipSecureFile.setMaxTextSize(12345); @@ -870,7 +870,7 @@ public final class TestPackage { // bug 60128 @Test - public void testCorruptFile() { + void testCorruptFile() { File file = getSampleFile("invalid.xlsx"); assertThrows(NotOfficeXmlFileException.class, () -> OPCPackage.open(file, PackageAccess.READ)); } @@ -881,7 +881,7 @@ public final class TestPackage { // bug 61381 @Test - public void testTooShortFilterStreams() throws IOException { + void testTooShortFilterStreams() throws IOException { for (String file : new String[]{"sample.xlsx","SampleSS.xls"}) { for (CountingStream cs : new CountingStream[]{PushbackInputStream::new, BufferedInputStream::new}) { try (InputStream is = cs.create(xlsSamples.openResourceAsStream(file), 2); @@ -893,7 +893,7 @@ public final class TestPackage { } @Test - public void testBug56479() throws Exception { + void testBug56479() throws Exception { try (InputStream is = openSampleStream("dcterms_bug_56479.zip"); OPCPackage p = OPCPackage.open(is)) { @@ -933,7 +933,7 @@ public final class TestPackage { } @Test - public void testClosingStreamOnException() throws IOException { + void testClosingStreamOnException() throws IOException { File tmp = File.createTempFile("poi-test-truncated-zip", ""); // create a corrupted zip file by truncating a valid zip file to the first 100 bytes @@ -959,34 +959,34 @@ public final class TestPackage { * See bug #60128 for more */ @Test - public void testTidyStreamOnInvalidFile1() throws Exception { + void testTidyStreamOnInvalidFile1() throws Exception { openInvalidFile("SampleSS.ods", false); } @Test - public void testTidyStreamOnInvalidFile2() throws Exception { + void testTidyStreamOnInvalidFile2() throws Exception { openInvalidFile("SampleSS.ods", true); } @Test - public void testTidyStreamOnInvalidFile3() throws Exception { + void testTidyStreamOnInvalidFile3() throws Exception { openInvalidFile("SampleSS.txt", false); } @Test - public void testTidyStreamOnInvalidFile4() throws Exception { + void testTidyStreamOnInvalidFile4() throws Exception { openInvalidFile("SampleSS.txt", true); } @Test - public void testBug62592() throws Exception { + void testBug62592() throws Exception { try (InputStream is = openSampleStream("62592.thmx")) { assertThrows(InvalidFormatException.class, () -> OPCPackage.open(is)); } } @Test - public void testBug62592SequentialCallsToGetParts() throws Exception { + void testBug62592SequentialCallsToGetParts() throws Exception { //make absolutely certain that sequential calls don't throw InvalidFormatExceptions String originalFile = getSampleFileName("TestPackageCommon.docx"); try (OPCPackage p2 = OPCPackage.open(originalFile, PackageAccess.READ)) { @@ -996,7 +996,7 @@ public final class TestPackage { } @Test - public void testDoNotCloseStream() throws IOException { + void testDoNotCloseStream() throws IOException { // up to JDK 10 we did use Mockito here, but OutputStream is // an abstract class and fails mocking with some changes in JDK 11 // so we use a simple empty output stream implementation instead @@ -1047,7 +1047,7 @@ public final class TestPackage { @SuppressWarnings("UnstableApiUsage") @Test - public void testBug63029() throws Exception { + void testBug63029() throws Exception { File testFile = getSampleFile("sample.docx"); File tmpFile = getOutputFile("Bug63029.docx"); Files.copy(testFile, tmpFile); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageCoreProperties.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageCoreProperties.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageCoreProperties.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageCoreProperties.java Sat Jan 9 00:46:52 2021 @@ -44,7 +44,7 @@ public final class TestPackageCoreProper * Test package core properties getters. */ @Test - public void testGetProperties() throws Exception { + void testGetProperties() throws Exception { // Open the package @SuppressWarnings("resource") OPCPackage p = OPCPackage.open(OpenXML4JTestDataSamples.openSampleStream("TestPackageCoreProperiesGetters.docx")); @@ -56,7 +56,7 @@ public final class TestPackageCoreProper * Test package core properties setters. */ @Test - public void testSetProperties() throws Exception { + void testSetProperties() throws Exception { String inputPath = OpenXML4JTestDataSamples.getSampleFileName("TestPackageCoreProperiesSetters.docx"); File outputFile = OpenXML4JTestDataSamples.getOutputFile("TestPackageCoreProperiesSettersOUTPUT.docx"); @@ -151,7 +151,7 @@ public final class TestPackageCoreProper } @Test - public void testCoreProperties_bug51374() throws Exception { + void testCoreProperties_bug51374() throws Exception { SimpleDateFormat df = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", Locale.ROOT); df.setTimeZone(LocaleUtil.TIMEZONE_UTC); String strDate = "2007-05-12T08:00:00Z"; @@ -210,7 +210,7 @@ public final class TestPackageCoreProper } @Test - public void testGetPropertiesLO() throws Exception { + void testGetPropertiesLO() throws Exception { // Open the package OPCPackage pkg1 = OPCPackage.open(OpenXML4JTestDataSamples.openSampleStream("51444.xlsx")); PackageProperties props1 = pkg1.getPackageProperties(); @@ -228,7 +228,7 @@ public final class TestPackageCoreProper } @Test - public void testEntitiesInCoreProps_56164() throws Exception { + void testEntitiesInCoreProps_56164() throws Exception { try (InputStream is = OpenXML4JTestDataSamples.openSampleStream("CorePropertiesHasEntities.ooxml"); OPCPackage p = OPCPackage.open(is)) { @@ -255,7 +255,7 @@ public final class TestPackageCoreProper } @Test - public void testListOfCustomProperties() throws Exception { + void testListOfCustomProperties() throws Exception { File inp = POIDataSamples.getSpreadSheetInstance().getFile("ExcelWithAttachments.xlsm"); OPCPackage pkg = OPCPackage.open(inp, PackageAccess.READ); XSSFWorkbook wb = new XSSFWorkbook(pkg); @@ -272,7 +272,7 @@ public final class TestPackageCoreProper } @Test - public void testAlternateCorePropertyTimezones() throws Exception { + void testAlternateCorePropertyTimezones() throws Exception { InputStream is = OpenXML4JTestDataSamples.openSampleStream("OPCCompliance_CoreProperties_AlternateTimezones.docx"); OPCPackage pkg = OPCPackage.open(is); PackagePropertiesPart props = (PackagePropertiesPart)pkg.getPackageProperties(); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagePartName.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagePartName.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagePartName.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagePartName.java Sat Jan 9 00:46:52 2021 @@ -27,7 +27,7 @@ public final class TestPackagePartName { * Test method getExtension(). */ @Test - public void testGetExtension() throws Exception{ + void testGetExtension() throws Exception{ PackagePartName name1 = PackagingURIHelper.createPartName("/doc/props/document.xml"); PackagePartName name2 = PackagingURIHelper.createPartName("/root/document"); assertEquals("xml", name1.getExtension()); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageThumbnail.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageThumbnail.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageThumbnail.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackageThumbnail.java Sat Jan 9 00:46:52 2021 @@ -35,7 +35,7 @@ public final class TestPackageThumbnail * Test package addThumbnail() method. */ @Test - public void testSetProperties() throws Exception { + void testSetProperties() throws Exception { String inputPath = OpenXML4JTestDataSamples.getSampleFileName("TestPackageThumbnail.docx"); String imagePath = OpenXML4JTestDataSamples.getSampleFileName("thumbnail.jpg"); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagingURIHelper.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagingURIHelper.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagingURIHelper.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackagingURIHelper.java Sat Jan 9 00:46:52 2021 @@ -30,7 +30,7 @@ public class TestPackagingURIHelper { * Test relativizePartName() method. */ @Test - public void testRelativizeURI() throws Exception { + void testRelativizeURI() throws Exception { URI uri1 = new URI("/word/document.xml"); URI uri2 = new URI("/word/media/image1.gif"); URI uri3 = new URI("/word/media/image1.gif#Sheet1!A1"); @@ -79,7 +79,7 @@ public class TestPackagingURIHelper { * Test createPartName(String, y) */ @Test - public void testCreatePartNameRelativeString() + void testCreatePartNameRelativeString() throws InvalidFormatException { PackagePartName partNameToValid = PackagingURIHelper .createPartName("/word/media/image1.gif"); @@ -100,7 +100,7 @@ public class TestPackagingURIHelper { * Test createPartName(URI, y) */ @Test - public void testCreatePartNameRelativeURI() throws Exception { + void testCreatePartNameRelativeURI() throws Exception { PackagePartName partNameToValid = PackagingURIHelper .createPartName("/word/media/image1.gif"); @@ -117,7 +117,7 @@ public class TestPackagingURIHelper { } @Test - public void testCreateURIFromString() throws Exception { + void testCreateURIFromString() throws Exception { String[] href = { "..\\\\\\cygwin\\home\\yegor\\.vim\\filetype.vim", "..\\Program%20Files\\AGEIA%20Technologies\\v2.3.3\\NxCooking.dll", @@ -136,7 +136,7 @@ public class TestPackagingURIHelper { } @Test - public void test53734() throws Exception { + void test53734() throws Exception { URI uri = PackagingURIHelper.toURI("javascript://"); // POI appends a trailing slash tpo avoid "Expected authority at index 13: javascript://" // https://issues.apache.org/bugzilla/show_bug.cgi?id=53734 Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestRelationships.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestRelationships.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestRelationships.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestRelationships.java Sat Jan 9 00:46:52 2021 @@ -53,7 +53,7 @@ public class TestRelationships { * really look also for not yet loaded parts. */ @Test - public void testLoadRelationships() throws Exception { + void testLoadRelationships() throws Exception { InputStream is = openSampleStream("sample.xlsx"); try (OPCPackage pkg = OPCPackage.open(is)) { logger.log(POILogger.DEBUG, "1: " + pkg); @@ -76,7 +76,7 @@ public class TestRelationships { * type, then grab from within there by id */ @Test - public void testFetchFromCollection() throws Exception { + void testFetchFromCollection() throws Exception { InputStream is = openSampleStream("ExcelWithHyperlinks.xlsx"); try (OPCPackage pkg = OPCPackage.open(is)) { PackagePart sheet = pkg.getPart( @@ -119,7 +119,7 @@ public class TestRelationships { * external hyperlinks. Check we can load these ok. */ @Test - public void testLoadExcelHyperlinkRelations() throws Exception { + void testLoadExcelHyperlinkRelations() throws Exception { InputStream is = openSampleStream("ExcelWithHyperlinks.xlsx"); try (OPCPackage pkg = OPCPackage.open(is)) { PackagePart sheet = pkg.getPart( @@ -155,7 +155,7 @@ public class TestRelationships { * then still read them later */ @Test - public void testCreateExcelHyperlinkRelations() throws Exception { + void testCreateExcelHyperlinkRelations() throws Exception { String filepath = OpenXML4JTestDataSamples.getSampleFileName("ExcelWithHyperlinks.xlsx"); OPCPackage pkg = OPCPackage.open(filepath, PackageAccess.READ_WRITE); PackagePart sheet = pkg.getPart( @@ -227,7 +227,7 @@ public class TestRelationships { } @Test - public void testCreateRelationsFromScratch() throws Exception { + void testCreateRelationsFromScratch() throws Exception { ByteArrayOutputStream baos = new ByteArrayOutputStream(); OPCPackage pkg = OPCPackage.create(baos); @@ -296,7 +296,7 @@ public class TestRelationships { } @Test - public void testTargetWithSpecialChars() throws Exception{ + void testTargetWithSpecialChars() throws Exception{ OPCPackage pkg; String filepath = OpenXML4JTestDataSamples.getSampleFileName("50154.xlsx"); @@ -358,7 +358,7 @@ public class TestRelationships { } @Test - public void testSelfRelations_bug51187() throws Exception { + void testSelfRelations_bug51187() throws Exception { ByteArrayOutputStream baos = new ByteArrayOutputStream(); PackageRelationship rel1; try (OPCPackage pkg = OPCPackage.create(baos)) { @@ -394,7 +394,7 @@ public class TestRelationships { } @Test - public void testTrailingSpacesInURI_53282() throws Exception { + void testTrailingSpacesInURI_53282() throws Exception { try (InputStream is = openSampleStream("53282.xlsx"); OPCPackage pkg1 = OPCPackage.open(is)) { @@ -423,7 +423,7 @@ public class TestRelationships { } @Test - public void testEntitiesInRels_56164() throws Exception { + void testEntitiesInRels_56164() throws Exception { try (InputStream is = openSampleStream("PackageRelsHasEntities.ooxml"); OPCPackage p = OPCPackage.open(is)) { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java Sat Jan 9 00:46:52 2021 @@ -80,7 +80,7 @@ import org.junit.jupiter.api.Test; public final class TestOPCComplianceCoreProperties { @Test - public void testCorePropertiesPart() { + void testCorePropertiesPart() { OPCPackage pkg; try { InputStream is = openComplianceSampleStream("OPCCompliance_CoreProperties_OnlyOneCorePropertiesPart.docx"); @@ -103,7 +103,7 @@ public final class TestOPCComplianceCore * Test M4.1 rule. */ @Test - public void testOnlyOneCorePropertiesPart() throws Exception { + void testOnlyOneCorePropertiesPart() throws Exception { // We have relaxed this check, so we can read the file anyway assertDoesNotThrow(() -> { try (InputStream is = openSampleStream("OPCCompliance_CoreProperties_OnlyOneCorePropertiesPartFAIL.docx"); @@ -141,7 +141,7 @@ public final class TestOPCComplianceCore * Test M4.1 rule. */ @Test - public void testOnlyOneCorePropertiesPart_AddRelationship() throws IOException, InvalidFormatException { + void testOnlyOneCorePropertiesPart_AddRelationship() throws IOException, InvalidFormatException { try (InputStream is = openComplianceSampleStream("OPCCompliance_CoreProperties_OnlyOneCorePropertiesPart.docx")) { OPCPackage pkg = OPCPackage.open(is); URI partUri = createURI("/docProps/core2.xml"); @@ -158,7 +158,7 @@ public final class TestOPCComplianceCore * Test M4.1 rule. */ @Test - public void testOnlyOneCorePropertiesPart_AddPart() throws InvalidFormatException, IOException { + void testOnlyOneCorePropertiesPart_AddPart() throws InvalidFormatException, IOException { String sampleFileName = "OPCCompliance_CoreProperties_OnlyOneCorePropertiesPart.docx"; try (OPCPackage pkg = OPCPackage.open(POIDataSamples.getOpenXML4JInstance().getFile(sampleFileName).getPath())) { @@ -175,7 +175,7 @@ public final class TestOPCComplianceCore * Test M4.2 rule. */ @Test - public void testDoNotUseCompatibilityMarkup() throws IOException { + void testDoNotUseCompatibilityMarkup() throws IOException { String msg = extractInvalidFormatMessage("DoNotUseCompatibilityMarkupFAIL.docx"); assertEquals("OPC Compliance error [M4.2]: A format consumer shall consider the use of the Markup Compatibility namespace to be an error.", msg); } @@ -184,7 +184,7 @@ public final class TestOPCComplianceCore * Test M4.3 rule. */ @Test - public void testDCTermsNamespaceLimitedUse() throws IOException { + void testDCTermsNamespaceLimitedUse() throws IOException { String msg = extractInvalidFormatMessage("DCTermsNamespaceLimitedUseFAIL.docx"); assertEquals("OPC Compliance error [M4.3]: Producers shall not create a document element that contains refinements to the Dublin Core elements, except for the two specified in the schema: <dcterms:created> and <dcterms:modified> Consumers shall consider a document element that violates this constraint to be an error.", msg); } @@ -193,7 +193,7 @@ public final class TestOPCComplianceCore * Test M4.4 rule. */ @Test - public void testUnauthorizedXMLLangAttribute() throws IOException { + void testUnauthorizedXMLLangAttribute() throws IOException { String msg = extractInvalidFormatMessage("UnauthorizedXMLLangAttributeFAIL.docx"); assertEquals("OPC Compliance error [M4.4]: Producers shall not create a document element that contains the xml:lang attribute. Consumers shall consider a document element that violates this constraint to be an error.", msg); } @@ -202,7 +202,7 @@ public final class TestOPCComplianceCore * Test M4.5 rule. */ @Test - public void testLimitedXSITypeAttribute_NotPresent() throws IOException { + void testLimitedXSITypeAttribute_NotPresent() throws IOException { String msg = extractInvalidFormatMessage("LimitedXSITypeAttribute_NotPresentFAIL.docx"); assertEquals("The element 'created' must have the 'xsi:type' attribute present !", msg); } @@ -211,7 +211,7 @@ public final class TestOPCComplianceCore * Test M4.5 rule. */ @Test - public void testLimitedXSITypeAttribute_PresentWithUnauthorizedValue() throws IOException { + void testLimitedXSITypeAttribute_PresentWithUnauthorizedValue() throws IOException { String msg = extractInvalidFormatMessage("LimitedXSITypeAttribute_PresentWithUnauthorizedValueFAIL.docx"); assertEquals("The element 'modified' must have the 'xsi:type' attribute with the value 'dcterms:W3CDTF', but had 'W3CDTF' !", msg); } @@ -221,7 +221,7 @@ public final class TestOPCComplianceCore * saving into a new stream */ @Test - public void testNoCoreProperties_saveNew() throws Exception { + void testNoCoreProperties_saveNew() throws Exception { String sampleFileName = "OPCCompliance_NoCoreProperties.xlsx"; ByteArrayOutputStream baos = new ByteArrayOutputStream(); @@ -267,7 +267,7 @@ public final class TestOPCComplianceCore * from a temp-file, saving in-place */ @Test - public void testNoCoreProperties_saveInPlace() throws Exception { + void testNoCoreProperties_saveInPlace() throws Exception { String sampleFileName = "OPCCompliance_NoCoreProperties.xlsx"; // Copy this into a temp file, so we can play with it Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java Sat Jan 9 00:46:52 2021 @@ -66,7 +66,7 @@ public class TestOPCCompliancePackageMod * [M1.11] */ @Test - public void testPartNameDerivationAdditionFailure() throws InvalidFormatException, IOException { + void testPartNameDerivationAdditionFailure() throws InvalidFormatException, IOException { try (OPCPackage pkg = OPCPackage.create(TESTFILE)) { PackagePartName name = PackagingURIHelper.createPartName("/word/document.xml"); PackagePartName nameDerived = PackagingURIHelper.createPartName("/word/document.xml/image1.gif"); @@ -85,7 +85,7 @@ public class TestOPCCompliancePackageMod * [M1.11] */ @Test - public void testPartNameDerivationReadingFailure() { + void testPartNameDerivationReadingFailure() { String filename = "OPCCompliance_DerivedPartNameFAIL.docx"; assertThrows(InvalidFormatException.class, () -> OPCPackage.open(POIDataSamples.getOpenXML4JInstance().openResourceAsStream(filename)), @@ -100,7 +100,7 @@ public class TestOPCCompliancePackageMod * part names. */ @Test - public void testAddPackageAlreadyAddFailure() throws Exception { + void testAddPackageAlreadyAddFailure() throws Exception { try (OPCPackage pkg = OPCPackage.create(TESTFILE)) { PackagePartName name1 = PackagingURIHelper.createPartName("/word/document.xml"); PackagePartName name2 = PackagingURIHelper.createPartName("/word/document.xml"); @@ -120,7 +120,7 @@ public class TestOPCCompliancePackageMod * part names. */ @Test - public void testAddPackageAlreadyAddFailure2() throws Exception { + void testAddPackageAlreadyAddFailure2() throws Exception { try (OPCPackage pkg = OPCPackage.create(TESTFILE)) { PackagePartName partName = PackagingURIHelper.createPartName("/word/document.xml"); pkg.createPart(partName, ContentTypes.XML); @@ -141,7 +141,7 @@ public class TestOPCCompliancePackageMod * relationship as invalid. */ @Test - public void testAddRelationshipRelationshipsPartFailure() throws IOException, InvalidFormatException { + void testAddRelationshipRelationshipsPartFailure() throws IOException, InvalidFormatException { try (OPCPackage pkg = OPCPackage.create(TESTFILE)) { PackagePartName name1 = PackagingURIHelper.createPartName("/test/_rels/document.xml.rels"); Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePartName.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePartName.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePartName.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePartName.java Sat Jan 9 00:46:52 2021 @@ -91,7 +91,7 @@ public final class TestOPCCompliancePart * A segment shall not contain percent-encoded unreserved characters. [M1.8] */ @Test - public void testInvalidPartNames() { + void testInvalidPartNames() { String[] invalidNames = { "/", "/xml./doc.xml", "[Content_Types].xml", "//xml/." }; for (String s : invalidNames) { URI uri = null; @@ -109,7 +109,7 @@ public final class TestOPCCompliancePart * Test some common valid names. */ @Test - public void testValidPartNames() throws URISyntaxException { + void testValidPartNames() throws URISyntaxException { String[] validNames = { "/xml/item1.xml", "/document.xml", "/a/%D1%86.xml" }; for (String s : validNames) { assertTrue(isValidPartName(new URI(s)), "This part name SHOULD be valid: " + s); @@ -120,7 +120,7 @@ public final class TestOPCCompliancePart * A part name shall not be empty. [M1.1] */ @Test - public void testEmptyPartNameFailure() { + void testEmptyPartNameFailure() { assertThrows(InvalidFormatException.class, () -> createPartName(new URI("")), "A part name shall not be empty. [M1.1]"); } @@ -133,7 +133,7 @@ public final class TestOPCCompliancePart * A segment shall include at least one non-dot character. [M1.10] */ @Test - public void testPartNameWithInvalidSegmentsFailure() throws URISyntaxException { + void testPartNameWithInvalidSegmentsFailure() throws URISyntaxException { String[] invalidNames = { "//document.xml", "//word/document.xml", "/word//document.rels", "/word//rels//document.rels", "/xml./doc.xml", "/document.", "/./document.xml", @@ -148,7 +148,7 @@ public final class TestOPCCompliancePart * [M1.6]. */ @Test - public void testPartNameWithNonPCharCharacters() throws URISyntaxException { + void testPartNameWithNonPCharCharacters() throws URISyntaxException { String[] validNames = { "/doc&.xml" }; for (String s : validNames) { assertTrue(isValidPartName(new URI(s)), @@ -160,7 +160,7 @@ public final class TestOPCCompliancePart * A segment shall not contain percent-encoded unreserved characters [M1.8]. */ @Test - public void testPartNameWithUnreservedEncodedCharactersFailure() throws URISyntaxException { + void testPartNameWithUnreservedEncodedCharactersFailure() throws URISyntaxException { String[] invalidNames = { "/a/docum%65nt.xml" }; for (String s : invalidNames) { assertFalse(isValidPartName(new URI(s)), "A segment shall not contain percent-encoded unreserved characters [M1.8] : " + s); @@ -171,7 +171,7 @@ public final class TestOPCCompliancePart * A part name shall start with a forward slash ('/') character. [M1.4] */ @Test - public void testPartNameStartsWithAForwardSlashFailure() { + void testPartNameStartsWithAForwardSlashFailure() { assertThrows(InvalidFormatException.class, () -> createPartName(new URI("document.xml")), "A part name shall start with a forward slash ('/') character. [M1.4]"); } @@ -180,7 +180,7 @@ public final class TestOPCCompliancePart * A part name shall not have a forward slash as the last character. [M1.5] */ @Test - public void testPartNameEndsWithAForwardSlashFailure() { + void testPartNameEndsWithAForwardSlashFailure() { assertThrows(InvalidFormatException.class, () -> createPartName(new URI("/document.xml/")), "A part name shall not have a forward slash as the last character. [M1.5]"); } @@ -190,7 +190,7 @@ public final class TestOPCCompliancePart * case-insensitive ASCII strings. [M1.12] */ @Test - public void testPartNameComparaison() throws Exception { + void testPartNameComparaison() throws Exception { String[] partName1 = { "/word/document.xml", "/docProps/core.xml", "/rels/.rels" }; String[] partName2 = { "/WORD/DocUment.XML", "/docProps/core.xml", "/rels/.rels" }; for (int i = 0; i < partName1.length || i < partName2.length; ++i) { @@ -209,7 +209,7 @@ public final class TestOPCCompliancePart * All the comparisons MUST FAIL ! */ @Test - public void testPartNameComparaisonFailure() throws Exception { + void testPartNameComparaisonFailure() throws Exception { String[] partName1 = { "/word/document.xml", "/docProps/core.xml", "/rels/.rels" }; String[] partName2 = { "/WORD/DocUment.XML2", "/docProp/core.xml", "/rels/rels" }; for (int i = 0; i < partName1.length || i < partName2.length; ++i) { Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java Sat Jan 9 00:46:52 2021 @@ -57,7 +57,7 @@ public final class TestContentTypeManage * Test the properties part content parsing. */ @Test - public void testContentType() throws Exception { + void testContentType() throws Exception { String filepath = OpenXML4JTestDataSamples.getSampleFileName("sample.docx"); // Retrieves core properties part @@ -74,7 +74,7 @@ public final class TestContentTypeManage * Test the addition of several default and override content types. */ @Test - public void testContentTypeAddition() throws Exception { + void testContentTypeAddition() throws Exception { ContentTypeManager ctm = new ZipContentTypeManager(null, null); PackagePartName name1 = PackagingURIHelper.createPartName("/foo/foo.XML"); @@ -98,7 +98,7 @@ public final class TestContentTypeManage * Test the addition then removal of content types. */ @Test - public void testContentTypeRemoval() throws Exception { + void testContentTypeRemoval() throws Exception { ContentTypeManager ctm = new ZipContentTypeManager(null, null); PackagePartName name1 = PackagingURIHelper.createPartName("/foo/foo.xml"); @@ -128,7 +128,7 @@ public final class TestContentTypeManage */ @Disabled @Test - public void testContentTypeRemovalPackage() { + void testContentTypeRemovalPackage() { // TODO } Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/util/TestZipSecureFile.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/util/TestZipSecureFile.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/util/TestZipSecureFile.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/util/TestZipSecureFile.java Sat Jan 9 00:46:52 2021 @@ -29,7 +29,7 @@ import static org.junit.jupiter.api.Asse public class TestZipSecureFile { @Test - public void testThresholdInputStream() throws Exception { + void testThresholdInputStream() throws Exception { // This fails in Java 10 because our reflection injection of the ThresholdInputStream causes a // ClassCastException in ZipFile now // The relevant change in the JDK is http://hg.openjdk.java.net/jdk/jdk10/rev/85ea7e83af30#l5.66 Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureConfig.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureConfig.java?rev=1885283&r1=1885282&r2=1885283&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureConfig.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureConfig.java Sat Jan 9 00:46:52 2021 @@ -29,7 +29,7 @@ public class TestSignatureConfig { @Test @Disabled("failing in automated builds, due to issues loading security classes") - public void testDigestAlgo() throws Exception { + void testDigestAlgo() throws Exception { SignatureConfig sc = new SignatureConfig(); assertEquals(HashAlgorithm.sha256, sc.getDigestAlgo()); sc.setDigestAlgo(HashAlgorithm.sha1); @@ -37,7 +37,7 @@ public class TestSignatureConfig { } @Test - public void testHashOids() throws IOException { + void testHashOids() throws IOException { final String[][] checks = { { "sha1", "MCEwCQYFKw4DAhoFAAQU" }, { "sha224", "MC0wDQYJYIZIAWUDBAIEBQAEHA==" }, --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org For additional commands, e-mail: commits-h...@poi.apache.org