Author: mariusvolkhart Date: Sun Mar 14 10:42:15 2021 New Revision: 1887630
URL: http://svn.apache.org/viewvc?rev=1887630&view=rev Log: Limit which tests can run in parallel Some tests modify global resources. Those tests cannot be run in parallel with others, as they cause problems or become flaky. Where possible, indicate to JUnit the resources in contention. Otherwise, mark the tests as needing to run in isolation. Modified: poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestEFBiffViewer.java poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestReSave.java poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java Modified: poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestEFBiffViewer.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestEFBiffViewer.java?rev=1887630&r1=1887629&r2=1887630&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestEFBiffViewer.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestEFBiffViewer.java Sun Mar 14 10:42:15 2021 @@ -26,7 +26,10 @@ import org.apache.poi.hssf.record.Record import org.apache.poi.util.NullPrintStream; import org.apache.poi.util.RecordFormatException; import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.parallel.ResourceLock; +import org.junit.jupiter.api.parallel.Resources; +@ResourceLock(Resources.SYSTEM_OUT) class TestEFBiffViewer extends BaseTestIteratingXLS { @BeforeAll public static void setup() { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java?rev=1887630&r1=1887629&r2=1887630&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java Sun Mar 14 10:42:15 2021 @@ -27,7 +27,10 @@ import org.apache.poi.hssf.record.Record import org.apache.poi.util.NullPrintStream; import org.apache.poi.util.RecordFormatException; import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.parallel.ResourceLock; +import org.junit.jupiter.api.parallel.Resources; +@ResourceLock(Resources.SYSTEM_OUT) class TestFormulaViewer extends BaseTestIteratingXLS { @BeforeAll public static void setup() { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestReSave.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestReSave.java?rev=1887630&r1=1887629&r2=1887630&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestReSave.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestReSave.java Sun Mar 14 10:42:15 2021 @@ -30,10 +30,12 @@ import org.apache.poi.util.RecordFormatE import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; -import org.junit.jupiter.api.parallel.Execution; -import org.junit.jupiter.api.parallel.ExecutionMode; +import org.junit.jupiter.api.parallel.Isolated; +import org.junit.jupiter.api.parallel.ResourceLock; +import org.junit.jupiter.api.parallel.Resources; -@Execution(ExecutionMode.CONCURRENT) +@Isolated("Modifies the test data directory") +@ResourceLock(Resources.SYSTEM_OUT) class TestReSave extends BaseTestIteratingXLS { @BeforeAll public static void setup() { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java?rev=1887630&r1=1887629&r2=1887630&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java Sun Mar 14 10:42:15 2021 @@ -24,7 +24,10 @@ import org.apache.poi.hssf.OldExcelForma import org.apache.poi.util.NullPrintStream; import org.apache.poi.util.RecordFormatException; import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.parallel.ResourceLock; +import org.junit.jupiter.api.parallel.Resources; +@ResourceLock(Resources.SYSTEM_OUT) class TestRecordLister extends BaseTestIteratingXLS { @BeforeAll public static void setup() { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
