svn commit: r1896288 - in /poi/trunk/poi-ooxml/src: main/java/org/apache/poi/xssf/eventusermodel/XSSFReader.java test/java/org/apache/poi/xssf/eventusermodel/TestXSSFReader.java test/java/org/apache/poi/xssf/usermodel/TestXSSFFont.java

[fanningpj]

Author: fanningpj
Date: Wed Dec 22 19:40:44 2021
New Revision: 1896288

URL: http://svn.apache.org/viewvc?rev=1896288&view=rev
Log:
add tests

Modified:
    
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/eventusermodel/XSSFReader.java
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFReader.java
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFFont.java

Modified: 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/eventusermodel/XSSFReader.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/eventusermodel/XSSFReader.java?rev=1896288&r1=1896287&r2=1896288&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/eventusermodel/XSSFReader.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/eventusermodel/XSSFReader.java
 Wed Dec 22 19:40:44 2021
@@ -131,7 +131,7 @@ public class XSSFReader {
      * or {@link ReadOnlySharedStringsTable}.
      * @since POI 5.2.0
      */
-    public boolean useReadOnlySharedStringsTable(boolean 
useReadOnlySharedStringsTable) {
+    public boolean useReadOnlySharedStringsTable() {
         return useReadOnlySharedStringsTable;
     }
 

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFReader.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFReader.java?rev=1896288&r1=1896287&r2=1896288&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFReader.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFReader.java
 Wed Dec 22 19:40:44 2021
@@ -44,9 +44,7 @@ import org.apache.poi.ss.usermodel.Workb
 import org.apache.poi.util.IOUtils;
 import org.apache.poi.util.XMLHelper;
 import org.apache.poi.xssf.XSSFTestDataSamples;
-import org.apache.poi.xssf.model.Comments;
-import org.apache.poi.xssf.model.CommentsTable;
-import org.apache.poi.xssf.model.StylesTable;
+import org.apache.poi.xssf.model.*;
 import org.apache.poi.xssf.streaming.SXSSFWorkbook;
 import org.apache.poi.xssf.usermodel.XSSFComment;
 import org.apache.poi.xssf.usermodel.XSSFShape;
@@ -72,9 +70,18 @@ public final class TestXSSFReader {
             assertNotNull(r.getWorkbookData());
             assertNotNull(r.getSharedStringsData());
             assertNotNull(r.getStylesData());
-
-            assertNotNull(r.getSharedStringsTable());
             assertNotNull(r.getStylesTable());
+
+            SharedStrings sst1 = r.getSharedStringsTable();
+            assertNotNull(sst1);
+            assertTrue(sst1 instanceof SharedStringsTable, "instanceof 
SharedStringsTable");
+
+            assertFalse(r.useReadOnlySharedStringsTable(), 
"useReadOnlySharedStringsTable defaults to false");
+            r.setUseReadOnlySharedStringsTable(true);
+            assertTrue(r.useReadOnlySharedStringsTable(), 
"useReadOnlySharedStringsTable changed to true");
+            SharedStrings sst2 = r.getSharedStringsTable();
+            assertNotNull(sst2);
+            assertTrue(sst2 instanceof ReadOnlySharedStringsTable, "instanceof 
ReadOnlySharedStringsTable");
         }
     }
 

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFFont.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFFont.java?rev=1896288&r1=1896287&r2=1896288&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFFont.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFFont.java
 Wed Dec 22 19:40:44 2021
@@ -299,7 +299,7 @@ public final class TestXSSFFont extends
 
         byte[] bytes = 
Integer.toHexString(0xF1F1F1).getBytes(LocaleUtil.CHARSET_1252);
         color.setRgb(bytes);
-        XSSFColor newColor=XSSFColor.from(color, null);
+        XSSFColor newColor = XSSFColor.from(color);
         xssfFont.setColor(newColor);
         assertEquals(ctFont.getColorArray(0).getRgb()[2],newColor.getRGB()[2]);
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org