Author: centic
Date: Thu Dec 30 23:03:16 2021
New Revision: 1896552
URL: http://svn.apache.org/viewvc?rev=1896552&view=rev
Log:
Bug 52447: Allow HyperLinkRecord to appear as part of the RowRecordsAggregate
Added:
poi/trunk/test-data/spreadsheet/52447.xls
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java
poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java?rev=1896552&r1=1896551&r2=1896552&view=diff
==============================================================================
---
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java
(original)
+++
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java
Thu Dec 30 23:03:16 2021
@@ -32,6 +32,7 @@ import org.apache.poi.hssf.record.DBCell
import org.apache.poi.hssf.record.DConRefRecord;
import org.apache.poi.hssf.record.DimensionsRecord;
import org.apache.poi.hssf.record.FormulaRecord;
+import org.apache.poi.hssf.record.HyperlinkRecord;
import org.apache.poi.hssf.record.IndexRecord;
import org.apache.poi.hssf.record.MergeCellsRecord;
import org.apache.poi.hssf.record.MulBlankRecord;
@@ -90,6 +91,9 @@ public final class RowRecordsAggregate e
// end of 'Row Block'. Should only occur after cell
records
// ignore DBCELL records because POI generates them upon
re-serialization
continue;
+ case HyperlinkRecord.sid:
+ // some files contain a HyperlinkRecord here which we
ignore for now
+ continue;
}
if (rec instanceof UnknownRecord) {
// might need to keep track of where exactly these belong
Modified:
poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java?rev=1896552&r1=1896551&r2=1896552&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java
(original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/hssf/usermodel/TestBugs.java Thu
Dec 30 23:03:16 2021
@@ -2603,5 +2603,10 @@ final class TestBugs extends BaseTestBug
}
}
-
+ @Test
+ void test52447() throws IOException {
+ try (Workbook wb = openSampleWorkbook("52447.xls")) {
+ assertNotNull(wb);
+ }
+ }
}
Added: poi/trunk/test-data/spreadsheet/52447.xls
URL:
http://svn.apache.org/viewvc/poi/trunk/test-data/spreadsheet/52447.xls?rev=1896552&view=auto
==============================================================================
Binary files poi/trunk/test-data/spreadsheet/52447.xls (added) and
poi/trunk/test-data/spreadsheet/52447.xls Thu Dec 30 23:03:16 2021 differ
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]