Author: fanningpj
Date: Fri Jan  7 11:59:40 2022
New Revision: 1896790

URL: http://svn.apache.org/viewvc?rev=1896790&view=rev
Log:
test code refactor

Modified:
    xmlbeans/trunk/src/test/java/scomp/common/BaseCase.java

Modified: xmlbeans/trunk/src/test/java/scomp/common/BaseCase.java
URL: 
http://svn.apache.org/viewvc/xmlbeans/trunk/src/test/java/scomp/common/BaseCase.java?rev=1896790&r1=1896789&r2=1896790&view=diff
==============================================================================
--- xmlbeans/trunk/src/test/java/scomp/common/BaseCase.java (original)
+++ xmlbeans/trunk/src/test/java/scomp/common/BaseCase.java Fri Jan  7 11:59:40 
2022
@@ -53,39 +53,37 @@ public class BaseCase {
 
     //TODO: compare regardless of order
     public boolean compareErrorCodes(String[] expected) {
-        if ( errorList.size() != expected.length){
-            System.err.println(stringOfCodes(expected,errorList));
+        if (errorList.size() != expected.length) {
+            System.err.println(stringOfCodes(expected, errorList));
 
-           return false;
+            return false;
         }
         StringBuilder errMessage = new StringBuilder();
         for (int i = 0; i < errorList.size(); i++) {
-            XmlError error = (XmlError) errorList.get(i);
-            if ( error.getErrorCode() == null )
-              errMessage.append("Kevin needs a code here 
"+error.getMessage()+"\n");
+            XmlError error = errorList.get(i);
+            if (error.getErrorCode() == null)
+                errMessage.append("Kevin needs a code here " + 
error.getMessage() + "\n");
 
-            if (!expected[i].equals(error.getErrorCode())){
+            if (!expected[i].equals(error.getErrorCode())) {
                 if (errMessage.length() > 0)
                     System.err.println(errMessage);
-                ArrayList exp=new ArrayList();
 
-                System.err.println(stringOfCodes(expected,errorList));
+                System.err.println(stringOfCodes(expected, errorList));
                 return false;
             }
         }
         return true;
     }
 
-    public String stringOfCodes(String[] errorCodes, ArrayList 
actual_errorCodes)
-    {
+    public String stringOfCodes(String[] errorCodes, ArrayList<XmlError> 
actual_errorCodes) {
         StringBuilder res = new StringBuilder();
         res.append("\n Expected codes:\n");
-        int i=0;
-        for (;i < errorCodes.length; i++ )
-            res.append( errorCodes[i]+"\n" );
+        int i = 0;
+        for (; i < errorCodes.length; i++)
+            res.append(errorCodes[i] + "\n");
         res.append("\nBut Got: \n");
-        for ( i=0 ;i < actual_errorCodes.size(); i++ )
-            res.append( actual_errorCodes.get(i)+"\n" );
+        for (i = 0; i < actual_errorCodes.size(); i++)
+            res.append(actual_errorCodes.get(i) + "\n");
 
         return res.toString();
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to