Author: fanningpj
Date: Tue Feb 1 21:16:05 2022
New Revision: 1897675
URL: http://svn.apache.org/viewvc?rev=1897675&view=rev
Log:
sonar issues
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java?rev=1897675&r1=1897674&r2=1897675&view=diff
==============================================================================
---
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java
(original)
+++
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java
Tue Feb 1 21:16:05 2022
@@ -114,8 +114,7 @@ public abstract class BaseXSSFFormulaEva
XSSFCell cell = row.getCell(cellIndex);
String cellValue = cell.getRawValue();
String cellR = new
CellReference(cell).formatAsString(false);
-
externalLinksTable.cacheData(sheet.getSheetName(), rowIndex + 1, cellR,
cellValue);
-
+
externalLinksTable.cacheData(sheet.getSheetName(), (long)rowIndex + 1, cellR,
cellValue);
}
}
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java?rev=1897675&r1=1897674&r2=1897675&view=diff
==============================================================================
---
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
(original)
+++
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
Tue Feb 1 21:16:05 2022
@@ -76,7 +76,8 @@ public final class NumberValueFunction i
return e.getErrorEval();
}
- if("".equals(text)) text = "0"; //If an empty string ("") is specified
as the Text argument, the result is 0.
+ if("".equals(text) || text == null) text = "0"; //If an empty string
("") is specified as the Text argument, the result is 0.
+
text = text.replace(" ", ""); //Empty spaces in the Text argument are
ignored, even in the middle of the argument. For example, " 3 000 " is returned
as 3000.
String[] parts = text.split("["+decSep+"]");
String sigPart = "";
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
