svn commit: r1897693 - in /poi/trunk: poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFSheetXMLHandler.java poi/src/test/java/org/apache/poi/ss/formula/functions/TestNumberValue.java

[fanningpj]

Author: fanningpj
Date: Wed Feb  2 11:16:39 2022
New Revision: 1897693

URL: http://svn.apache.org/viewvc?rev=1897693&view=rev
Log:
sonarqube

Modified:
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFSheetXMLHandler.java
    
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestNumberValue.java

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFSheetXMLHandler.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFSheetXMLHandler.java?rev=1897693&r1=1897692&r2=1897693&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFSheetXMLHandler.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFSheetXMLHandler.java
 Wed Feb  2 11:16:39 2022
@@ -28,13 +28,14 @@ import org.xml.sax.XMLReader;
 import java.io.InputStream;
 import java.util.Iterator;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-public class TestXSSFSheetXMLHandler {
+class TestXSSFSheetXMLHandler {
     private static final POIDataSamples _ssTests = 
POIDataSamples.getSpreadSheetInstance();
 
     @Test
-    public void testInlineString() throws Exception {
+    void testInlineString() throws Exception {
         try (OPCPackage xlsxPackage = 
OPCPackage.open(_ssTests.openResourceAsStream("InlineString.xlsx"))) {
             final XSSFReader reader = new XSSFReader(xlsxPackage);
 
@@ -64,13 +65,13 @@ public class TestXSSFSheetXMLHandler {
                     }
                 }, false));
 
-                sheetParser.parse(new InputSource(stream));
+                assertDoesNotThrow(() -> sheetParser.parse(new 
InputSource(stream)));
             }
         }
     }
 
     @Test
-    public void testNumber() throws Exception {
+    void testNumber() throws Exception {
         try (OPCPackage xlsxPackage = 
OPCPackage.open(_ssTests.openResourceAsStream("sample.xlsx"))) {
             final XSSFReader reader = new XSSFReader(xlsxPackage);
 
@@ -95,7 +96,7 @@ public class TestXSSFSheetXMLHandler {
                     }
                 }, false));
 
-                sheetParser.parse(new InputSource(stream));
+                assertDoesNotThrow(() -> sheetParser.parse(new 
InputSource(stream)));
             }
         }
     }

Modified: 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestNumberValue.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestNumberValue.java?rev=1897693&r1=1897692&r2=1897693&view=diff
==============================================================================
--- 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestNumberValue.java
 (original)
+++ 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestNumberValue.java
 Wed Feb  2 11:16:39 2022
@@ -36,7 +36,7 @@ import static org.junit.jupiter.api.Asse
 /**
  * Testcase for function NUMBERVALUE()
  */
-public class TestNumberValue {
+class TestNumberValue {
 
     
//https://support.microsoft.com/en-us/office/numbervalue-function-1b05c8cf-2bfa-4437-af70-596c7ea7d879
     @Test



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org