Author: fanningpj
Date: Fri Jul 15 21:06:30 2022
New Revision: 1902749
URL: http://svn.apache.org/viewvc?rev=1902749&view=rev
Log:
[github-347] make some inner classes static to save memory. Thanks to
XenoAmess. This closes #347
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java
poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java?rev=1902749&r1=1902748&r2=1902749&view=diff
==============================================================================
---
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
(original)
+++
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xddf/usermodel/chart/XDDFChartData.java
Fri Jul 15 21:06:30 2022
@@ -142,7 +142,7 @@ public abstract class XDDFChartData {
public abstract XDDFChartData.Series addSeries(XDDFDataSource<?> category,
XDDFNumericalDataSource<? extends Number> values);
- public abstract class Series {
+ public abstract static class Series {
protected abstract CTSerTx getSeriesText();
public abstract void setShowLeaderLines(boolean showLeaderLines);
Modified:
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java?rev=1902749&r1=1902748&r2=1902749&view=diff
==============================================================================
---
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java
(original)
+++
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java
Fri Jul 15 21:06:30 2022
@@ -165,7 +165,7 @@ class TestXSSFBReader {
}
- private class TestSheetHandler implements
XSSFSheetXMLHandler.SheetContentsHandler {
+ private static class TestSheetHandler implements
XSSFSheetXMLHandler.SheetContentsHandler {
private final StringBuilder sb = new StringBuilder();
void startSheet(String sheetName) {
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java
URL:
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java?rev=1902749&r1=1902748&r2=1902749&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java
(original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFChart.java
Fri Jul 15 21:06:30 2022
@@ -1120,7 +1120,7 @@ public final class HSSFChart {
}
}
- linkedDataRecord.setFormulaOfLink(ptgList.toArray(new Ptg[0]));
+
linkedDataRecord.setFormulaOfLink(ptgList.toArray(Ptg.EMPTY_PTG_ARRAY));
return rowCount * colCount;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
