svn commit: r1902759 - in /poi/trunk: poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/ poi/src/main/java/org/apache/poi/ss/formula/functions/ poi/src/test/java/org/apache/poi/ss/formula/functions/

[fanningpj]

Author: fanningpj
Date: Fri Jul 15 23:03:51 2022
New Revision: 1902759

URL: http://svn.apache.org/viewvc?rev=1902759&view=rev
Log:
[github-355] Tidy up some boxed variables. Thanks to XenoAmess. This closes #355

Modified:
    
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFSheet.java
    
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
    
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java
    
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java

Modified: 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFSheet.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFSheet.java?rev=1902759&r1=1902758&r2=1902759&view=diff
==============================================================================
--- 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFSheet.java
 (original)
+++ 
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFSheet.java
 Fri Jul 15 23:03:51 2022
@@ -98,7 +98,7 @@ class TestXSLFSheet {
             XMLSlideShow[] sourceSlideShows = new XMLSlideShow[] { 
textureSlideShow, pictureSlideShow };
             XMLSlideShow targetSlideShow = textureSlideShow;
             for (XMLSlideShow sourceSlideShow : sourceSlideShows) {
-                Boolean sameSlideShow = sourceSlideShow == targetSlideShow;
+                boolean sameSlideShow = sourceSlideShow == targetSlideShow;
                 String assertMessage = "importing charts " + (sameSlideShow ? 
"within the same slide show" : "from another slideshow") + ": ";
                 XSLFSlide sourceSlide = sourceSlideShow.getSlides().get(0);
                 XSLFSlide slide = targetSlideShow.createSlide();

Modified: 
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java?rev=1902759&r1=1902758&r2=1902759&view=diff
==============================================================================
--- 
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
 (original)
+++ 
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
 Fri Jul 15 23:03:51 2022
@@ -50,7 +50,7 @@ public final class NumberValueFunction i
         String decSep = 
String.valueOf(decimalFormatSymbols.getDecimalSeparator());
         String groupSep = 
String.valueOf(decimalFormatSymbols.getGroupingSeparator());
 
-        Double result = Double.NaN;
+        double result = Double.NaN;
         ValueEval v1 = null;
         ValueEval v2 = null;
         ValueEval v3 = null;
@@ -105,7 +105,7 @@ public final class NumberValueFunction i
         }
 
         try {
-            result = Double.valueOf(text);
+            result = Double.parseDouble(text);
             result = result / Math.pow(100, countPercent); //If the Text 
argument ends in one or more percent signs (%), they are used in the 
calculation of the result.
             checkValue(result);
         } catch (EvaluationException e) {

Modified: 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java?rev=1902759&r1=1902758&r2=1902759&view=diff
==============================================================================
--- 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java
 (original)
+++ 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java
 Fri Jul 15 23:03:51 2022
@@ -59,7 +59,7 @@ final class TestIntercept {
 
     @Test
     void testBasic() {
-        Double exp = Math.pow(10, 7.5);
+        double exp = Math.pow(10, 7.5);
         ValueEval[] yValues = {
             new NumberEval(3+exp),
             new NumberEval(4+exp),

Modified: 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java
URL: 
http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java?rev=1902759&r1=1902758&r2=1902759&view=diff
==============================================================================
--- 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java 
(original)
+++ 
poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java 
Fri Jul 15 23:03:51 2022
@@ -54,7 +54,7 @@ final class TestSlope {
 
     @Test
     void testBasic() {
-        Double exp = Math.pow(10, 7.5);
+        double exp = Math.pow(10, 7.5);
         ValueEval[] yValues = {
             new NumberEval(3+exp),
             new NumberEval(4+exp),



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org